[$1500] [Due for payment 2025-10-31] Remove call to `getReportNameValuePairs()` in method `canUserPerformWriteAction` from `ReportUtils.ts`

[tgolen]

This is part of #59961 and will ensure that the function is a pure function.

No proposals are necessary for this.

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021984347805897219017
• Upwork Job ID: 1984347805897219017
• Last Price Increase: 2025-10-31

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thelullabyy]

No proposals are necessary for this.

@tgolen I see we don't need the proposal here. Can I work on this one?

[DylanDylann]

🔔 Note for Contributors: Please ensure that you are responsible in the PR phase to try to get it done soon

The function canUserPerformWriteAction() is not a pure function because it references the report's NVPs from a global variable here. This is considered an anti-pattern that we are actively working to eliminate.

✅ Your Task

1. Verify that a unit test exists for canUserPerformWriteAction() in its current form. If it doesn't, create one — and aim for high-quality, thorough coverage.

2. Refactor canUserPerformWriteAction() into a pure function, and introduce a new parameter: isReportArchived = false (It is recommended to use useReportIsArchived to get isReportArchived). And update all instances in the codebase where canUserPerformWriteAction() is called to accommodate the new isReportArchived parameter.

⚠️ Best Practices to Follow

1. Avoid adding new global references to data via Onyx.connect.
2. Avoid using isArchivedReport(nameValuePairs) unless absolutely necessary.
3. Prefer fetching data in a UI component, then pass it down via parameters.
4. Consider using the useReportIsArchived() React hook — it’s designed for this.
5. Before making changes, check if the report's NVPs are already available or if isReportArchived is already calculated or passed.

[DylanDylann]

@thelullabyy Please read the above guideline and let us know if you want to work on this issue

[thelullabyy]

@thelullabyy Please read the above guideline and let us know if you want to work on this issue

@DylanDylann, I got it, and I'd like to work on this issue.