[Due for payment 2025-08-19] [$250] Onboarding - Search can be opened via CMD+K during "What features are you interested in" step

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.84-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://github.com/Expensify/Expensify/issues/450237
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: macOS Sequoia 15.5
App Component: Onboarding

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with a new Gmail account.
3. Click Skip on work email step.
4. Select Manage my team's expenses.
5. Select 1-10 employees > Continue.
6. Select QBO > Continue.
7. On "What features are you interested in" page, open search modal via CMD+K.
8. Select Concierge chat.

Expected Result:

Search modal should be blocked during "What features are you interested in" step.

Actual Result:

Search modal can be opened via CMD+K during "What features are you interested in" step.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6897505_1753366037633.20250724_220217.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021951165746952373212
• Upwork Job ID: 1951165746952373212
• Last Price Increase: 2025-08-01
• Automatic offers:
• mkzie2 | Contributor | 108275207

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[ryntgh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Onboarding - Search can be opened via CMD+K during "What features are you interested in" step

What is the root cause of that problem?

SCREENS.ONBOARDING.INTERESTED_FEATURES is not included in the ONBOARDING_SCREENS array here

App/src/libs/Navigation/helpers/isNavigatorName.ts

Lines 6 to 20 in 4b68aa8

	const ONBOARDING_SCREENS = [
	SCREENS.ONBOARDING.PERSONAL_DETAILS,
	SCREENS.ONBOARDING.PURPOSE,
	SCREENS.ONBOARDING_MODAL.ONBOARDING,
	SCREENS.ONBOARDING.EMPLOYEES,
	SCREENS.ONBOARDING.ACCOUNTING,
	SCREENS.ONBOARDING.PRIVATE_DOMAIN,
	SCREENS.ONBOARDING.WORKSPACES,
	SCREENS.ONBOARDING.WORK_EMAIL,
	SCREENS.ONBOARDING.WORK_EMAIL_VALIDATION,
	SCREENS.ONBOARDING.WORKSPACE_OPTIONAL,
	SCREENS.ONBOARDING.WORKSPACE_CONFIRMATION,
	SCREENS.ONBOARDING.WORKSPACE_CURRENCY,
	SCREENS.ONBOARDING.WORKSPACE_INVITE,
	];

This causes the Navigation.isOnboardingFlow to return false during this step, which allows the search modal keyboard shortcut (CMD+K) to work when it should be blocked

App/src/libs/Navigation/AppNavigator/AuthScreens.tsx

Lines 400 to 403 in 4b68aa8

	if (Navigation.isOnboardingFlow()) {
	return;
	}
	toggleSearch();

What changes do you think we should make in order to solve the problem?

Add SCREENS.ONBOARDING.INTERESTED_FEATURES to the ONBOARDING_SCREENS

App/src/libs/Navigation/helpers/isNavigatorName.ts

Lines 6 to 20 in 4b68aa8

	const ONBOARDING_SCREENS = [
	SCREENS.ONBOARDING.PERSONAL_DETAILS,
	SCREENS.ONBOARDING.PURPOSE,
	SCREENS.ONBOARDING_MODAL.ONBOARDING,
	SCREENS.ONBOARDING.EMPLOYEES,
	SCREENS.ONBOARDING.ACCOUNTING,
	SCREENS.ONBOARDING.PRIVATE_DOMAIN,
	SCREENS.ONBOARDING.WORKSPACES,
	SCREENS.ONBOARDING.WORK_EMAIL,
	SCREENS.ONBOARDING.WORK_EMAIL_VALIDATION,
	SCREENS.ONBOARDING.WORKSPACE_OPTIONAL,
	SCREENS.ONBOARDING.WORKSPACE_CONFIRMATION,
	SCREENS.ONBOARDING.WORKSPACE_CURRENCY,
	SCREENS.ONBOARDING.WORKSPACE_INVITE,
	];

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A

[aadil42]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search modal is opening when pressing CMD+K shortcut during "What features are you interested in" step when logging in.

What is the root cause of that problem?

in AuthScreens we subscribe the cmd+k for the search. When we press the shortcut while on "What features are you interested in" modal the shortuct-command key gets captured on the AuthScreens and it opens the modal.

App/src/libs/Navigation/AppNavigator/AuthScreens.tsx

Lines 393 to 409 in 4b68aa8

	// Listen for the key K being pressed so that focus can be given to
	// Search Router, or new group chat
	// based on the key modifiers pressed and the operating system
	const unsubscribeSearchShortcut = KeyboardShortcut.subscribe(
	searchShortcutConfig.shortcutKey,
	() => {
	Session.callFunctionIfActionIsAllowed(() => {
	if (Navigation.isOnboardingFlow()) {
	return;
	}
	toggleSearch();
	})();
	},
	shortcutsOverviewShortcutConfig.descriptionKey,
	shortcutsOverviewShortcutConfig.modifiers,
	true,
	);

What changes do you think we should make in order to solve the problem?

We need to stop the shortcut from being capture when on "What features are you interested in" modal by using useKeyboardShortcut in OnboardingInterestedFeatures here:

App/src/pages/OnboardingInterestedFeatures/index.tsx

Line 6 in 4b68aa8

function OnboardingInterestedFeatures(props: OnboardingInterestedFeaturesProps) {

This is what we will add in that component so the search shortcut doesn't propagate up to the AuthScreens.

useKeyboardShortcut(CONST.KEYBOARD_SHORTCUTS.SEARCH, () => {}, {
        shouldStopPropagation: true,
 });

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search modal can be opened via CMD+K during "What features are you interested in" step.

What is the root cause of that problem?

We missed adding the interested in screen to the ONBOARDING_SCREENS

App/src/libs/Navigation/helpers/isNavigatorName.ts

Lines 6 to 20 in 4b68aa8

	const ONBOARDING_SCREENS = [
	SCREENS.ONBOARDING.PERSONAL_DETAILS,
	SCREENS.ONBOARDING.PURPOSE,
	SCREENS.ONBOARDING_MODAL.ONBOARDING,
	SCREENS.ONBOARDING.EMPLOYEES,
	SCREENS.ONBOARDING.ACCOUNTING,
	SCREENS.ONBOARDING.PRIVATE_DOMAIN,
	SCREENS.ONBOARDING.WORKSPACES,
	SCREENS.ONBOARDING.WORK_EMAIL,
	SCREENS.ONBOARDING.WORK_EMAIL_VALIDATION,
	SCREENS.ONBOARDING.WORKSPACE_OPTIONAL,
	SCREENS.ONBOARDING.WORKSPACE_CONFIRMATION,
	SCREENS.ONBOARDING.WORKSPACE_CURRENCY,
	SCREENS.ONBOARDING.WORKSPACE_INVITE,
	];

then Navigation.isOnboardingFlow() returns false for this screen and the search page is opened via shotcut

App/src/libs/Navigation/AppNavigator/AuthScreens.tsx

Lines 396 to 402 in fa218a9

	const unsubscribeSearchShortcut = KeyboardShortcut.subscribe(
	searchShortcutConfig.shortcutKey,
	() => {
	Session.callFunctionIfActionIsAllowed(() => {
	if (Navigation.isOnboardingFlow()) {
	return;
	}

What changes do you think we should make in order to solve the problem?

I don't think we need a new variable here since the SCREENS.ONBOARDING already contains all onboarding screens. Additionally, using a separate variable here can cause the same problem if we have a new screen in the onboarding flow and forget to add this screen to ONBOARDING_SCREENS variable. In the same way we create a new set for other variables in this file, we can use Object.values(SCREENS.ONBOARDING).

const ONBOARDING_SCREENS_SET = new Set(Object.values(SCREENS.ONBOARDING));

App/src/libs/Navigation/helpers/isNavigatorName.ts

Line 24 in 4b68aa8

const ONBOARDING_SCREENS_SET = new Set(ONBOARDING_SCREENS);

The SCREENS.ONBOARDING_MODAL.ONBOARDING is also outdated and isn't a screen in the navigator anymore so we should remove this screen as well.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@muttmuure Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021951165746952373212

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)