[Due for payment 2025-09-02] [$250] Tags - X: Y tag name in the system message thread header is displayed as X\: Y

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.84-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://github.com/Expensify/Expensify/issues/432638
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: macOS Sequoia 15.5
App Component: Workspace settings

Action Performed:

1. Go to staging.new.expensify.com
2. Create a new workspace.
3. Go to workspace settings > More features.
4. Enable Tags.
5. Go to Tags.
6. Click Add tag.
7. Enter X: Y as tag name and save it.
8. Disable the same tag.
9. Go to #admins.
10. Click 1 Reply on the system message thread.

Expected Result:

The system message thread header will show X: Y tag correctly.

Actual Result:

X: Y tag name in the system message thread header is displayed as X: Y.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6897530_1753368274136.20250724_224111.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021951311591957955548
• Upwork Job ID: 1951311591957955548
• Last Price Increase: 2025-08-08
• Automatic offers:
• mkzie2 | Contributor | 108417810

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

X: Y tag name in the system message thread header is displayed as X: Y.

What is the root cause of that problem?

We don't handle the thread report name for the case tag modify action

App/src/libs/ReportUtils.ts

Line 5085 in fa8f507

if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.REJECTED) {

What changes do you think we should make in order to solve the problem?

We should add a case for the thread of tag modify action like the same here

if (isTagModificationAction(parentReportAction?.actionName)) {
    return getCleanedTagName(getWorkspaceTagUpdateMessage(parentReportAction) ?? '');
}

App/src/libs/ReportUtils.ts

Line 5085 in fa8f507

if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.REJECTED) {

Optional: We can also improve getWorkspaceTagUpdateMessage by clean up the tag name inside this function before returning the translation.

App/src/libs/ReportActionsUtils.ts

Line 2350 in fa8f507

const {tagListName, tagName, enabled, newName, newValue, oldName, oldValue, updatedField, count} =

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Update getReportNameInternal unit test to verify the report name is correct for tag modify action.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[aadil42]

@mkzie2, wouldn't lastAction be undefined here?

if (isTagModificationAction(parentReportAction?.actionName)) {
    return getCleanedTagName(getWorkspaceTagUpdateMessage(lastAction) ?? '');
}

You are suggesting to add this logic in the blow location right? In the getReportNameInternal function? we'll check if the tag was modified and if it was, we'll get the changed tag name but where are we getting lastAction from? it would be undefined I think.

App/src/libs/ReportUtils.ts

Lines 5043 to 5044 in fa8f507

	function getReportNameInternal({
	report,

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021951311591957955548

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[melvin-bot]

@rojiphil Eep! 4 days overdue now. Issues have feelings too...