[Due for payment 2025-10-30] [$250] Create no-object-keys-includes lint rule

[roryabraham]

Coming from https://expensify.slack.com/archives/C05LX9D6E07/p1753812175447629?thread_ts=1753810372.474349&cid=C05LX9D6E07

---

Problem

When we write code like this to check if a key exists in an object:

Object.keys(policyRates).includes(customUnitRateID)

We incur performance overhead in that we are doing an O(n) operation:

1. Copy the object keys into an array - O(n)
2. Iterate the array searching for a matching key - also O(n)

Solution

Write a lint rule to disallow that pattern, enforcing that instead we do an O(1) lookup in the object:

customUnitRateID in policyRates

or

!!policyRates[customUnitRateID]

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021968163942954970101
• Upwork Job ID: 1968163942954970101
• Last Price Increase: 2025-09-24

Issue Owner

Current Issue Owner: @VictoriaExpensify

[roryabraham]

https://expensify.slack.com/archives/C05LX9D6E07/p1755719761872409?thread_ts=1755719385.116499&cid=C05LX9D6E07

[roryabraham]

Looking for a team of two volunteers to take this on: https://expensify.slack.com/archives/C08CZDJFJ77/p1756853317764529

[roryabraham]

main PR is awaiting my review, and I'll try to do it tomorrow: Expensify/eslint-config-expensify#153