[Due for payment 2025-09-12] [BACK BUTTON] [$250] Company card - After changing export settings to Vendor bill, card details page is opened twice

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.90-4
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-115/folder/13176706/41236845/827410846
Email or phone of affected tester (no customers): applausetester+kh20080230e7@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Add Chase bank account in Company cards settings and assign card 0000 to yourself.
• Workspace is connected to QBO.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Members.
3. Click on your profile.
4. Click on the assigned card.
5. Click "QuickBooks Online credit card export".
6. Click "export option" link.
7. Click "Export company card expenses as".
8. Click "Export as".
9. Select Vendor bill.
10. Click RHP back button twice, which will return to card details RHP.
11. On card details RHP, click RHP back button.

Expected Result:

RHP will return to member profile.

Actual Result:

RHP opens "QuickBooks Online vendor bill export". Back button on this page returns to card details page again.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021953514456641995020
• Upwork Job ID: 1953514456641995020
• Last Price Increase: 2025-08-14
• Automatic offers:
• daledah | Contributor | 108482331

Issue Owner

Current Issue Owner: @clarajones-expensify

[melvin-bot]

Triggered auto assignment to @clarajones-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021953514456641995020

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

RHP opens "QuickBooks Online vendor bill export". Back button on this page returns to card details page again.

What is the root cause of that problem?

From workspace member details page, we navigate to company card details page with backTo param:

App/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

Line 232 in bdec6b1

Navigation.navigate(ROUTES.WORKSPACE_COMPANY_CARD_DETAILS.getRoute(policyID, card.cardID.toString(), card.bank, Navigation.getActiveRoute()));

This backTo param is changed to a new param, which is QuickBooks Online credit card export page url in here:

App/src/pages/workspace/companyCards/WorkspaceCompanyCardAccountSelectCardPage.tsx

Line 44 in 36559d4

const exportMenuItem = getExportMenuItem(connectedIntegration, policyID, translate, policy, card, Navigation.getActiveRoute());

And then after changing Export company card expenses as option, we go back to company card details page without backTo param:

App/src/libs/Navigation/helpers/goBackFromExportConnection.ts

Lines 15 to 16 in 36559d4

	const companyCardDetailsPage = replaceCompanyCardsRoute(backTo);
	return Navigation.goBack(companyCardDetailsPage);

So navigation tree sees these company card details pages as two different screens, so going back doesn't take user back to initial company card details page, but pop the current screen and replace it with another company card details page. So when pressing back button, we go back to the previous page, which is QuickBooks Online credit card export page.

What changes do you think we should make in order to solve the problem?

We should add param compareParams as false to Navigation.goBack here

App/src/libs/Navigation/helpers/goBackFromExportConnection.ts

Line 16 in 36559d4

return Navigation.goBack(companyCardDetailsPage);

return Navigation.goBack(companyCardDetailsPage, {compareParams: false});

Screen.Recording.2025-08-08.at.03.10.50.mp4

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None, Navigation issue

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Company card - After changing export settings to Vendor bill, card details page is opened twice

What is the root cause of that problem?

For credit or debit card export option we get the QuickBooks Online credit card export page but to choose an account for export but if use "Vendor bill" there is no choose account page and user directly navigate back to "Card details" where we use backTo param here

App/src/pages/workspace/companyCards/WorkspaceCompanyCardDetailsPage.tsx

Line 110 in 0754dfc

onBackButtonPress={() => Navigation.goBack(backTo)}

but this return undefined and user goback to "choose an account" that was not available for "Vendor bill"

What changes do you think we should make in order to solve the problem?

we should pass the defult route in WorkspaceCompanyCardDetailsPage

onBackButtonPress={() => Navigation.goBack(ROUTES.WORKSPACE_MEMBERS.getRoute(policyID))}

here

App/src/pages/workspace/companyCards/WorkspaceCompanyCardDetailsPage.tsx

Lines 108 to 111 in 0754dfc

	<HeaderWithBackButton
	title={translate('workspace.moreFeatures.companyCards.cardDetails')}
	onBackButtonPress={() => Navigation.goBack(backTo)}
	/>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

we can also check backTo like this

  onBackButtonPress={() => Navigation.goBack(backTo ?? ROUTES.WORKSPACE_MEMBERS.getRoute(policyID))}

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Results

macOS.chorome.mp4

[cosmicvulpes]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After changing the QuickBooks Online export setting for company cards to “Vendor bill,” pressing the RHP back button does not return to the member profile as expected. Instead, it reopens the “QuickBooks Online vendor bill export” page, effectively trapping the user in a loop when navigating back from the company card details page.

What is the root cause of that problem?

Back-navigation relies on a backTo route and a helper that rewrites the company card export URL (…/edit/export) back to the card details URL. The helper replaceCompanyCardsRoute only removed a trailing “/edit/export” when it appeared at the end of the string. When a ?backTo=… query was present, the route ended with the querystring and the helper failed to strip “/edit/export”, so the stack retained the export page. This caused the subsequent back from card details to reopen the vendor bill export screen.

Relevant code:

• src/libs/Navigation/helpers/replaceCompanyCardsRoute.ts
• Navigation flows via getRoute(..., backTo) and Navigation.goBack(backTo) for:
  • WorkspaceCompanyCardDetailsPage
  • QBO export pages under src/pages/workspace/accounting/qbo/export/

What changes do you think we should make in order to solve the problem?

• Make replaceCompanyCardsRoute robust to querystrings by removing “/edit/export” even when followed by ?… so the card details route is produced correctly while preserving existing backTo.
• Ensure we preserve backTo when navigating back to card details after setting a card export account, so the final back returns to the member profile, not export settings.

Concrete edits:

App/src/libs/Navigation/helpers/replaceCompanyCardsRoute.ts

Lines 3 to 5 in 206a0e6

	const replaceCompanyCardsRoute = (route: string): Routes => {
	return route?.replace(/\/edit\/export$/, '') as Routes;
	};

• Update replaceCompanyCardsRoute regex to: /\/edit\/export(?=(\?.*)?$)/ so it strips the segment before optional query params.
• In WorkspaceCompanyCardAccountSelectCardPage, pass the original backTo when calling Navigation.goBack(ROUTES.WORKSPACE_COMPANY_CARD_DETAILS.getRoute(..., backTo)) after selection.

These changes are minimal, do not alter UX outside the bug, and align with existing routing patterns in ROUTES.getRoute(..., backTo).

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• Back rewrite helper:
  • Input: …/edit/export → Output: … (without edit/export)
  • Input: …/edit/export?backTo=ENCODED → Output preserves query and strips edit/export.

What alternative solutions did you explore? (Optional)

• Forcing a replace/pop sequence on the export screens. Rejected in favor of a targeted fix that preserves the existing back stack semantics and minimizes risk.

[clarajones-expensify]

Hi @sobitneupane - would you review the above proposals?