[HOLD for payment 2022-01-11] Button is overlapping with the text in New Room page - Reported by: @thesahindia

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to app
2. Create a new workspace if you dont have one
3. Click "+" > New room

Expected Result:

Buttons and text should not overlap

Actual Result:

Button is overlapping with the text in New Room page.
Issue repro on smaller screen devices

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Mobile Web

Version Number: 1.1.19-0
Reproducible in staging?: Y
Reproducible in production?:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1639335083137500

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[tgolen]

Issue looks legit, so let's get it out to our open-source community.

[thesahindia]

Proposal

replacing View with <ScrollView style={styles.flex1} contentContainerStyle={styles.p5}> will solve the overlap issue and it will also make it scrollable as it is not scrollable right now.

App/src/pages/workspace/WorkspaceNewRoomPage.js

Line 144 in 213751e

<View style={[styles.flex1, styles.w100, styles.pRelative, styles.p5]}>

[tgolen]

👍 Proposal looks good and this is consistent with what we do on many other views. Are there any more views that are missed that this needs to be added to?

🟢 to hire @thesahindia for that proposal.

[thesahindia]

@tgolen, will report if I find any.

[Christinadobrzyn]

Created Job in Upwork:
Internal posting: https://www.upwork.com/ab/applicants/1473110323714453505/job-details
External posting: https://www.upwork.com/jobs/~01c73faed55a1b6c12

Hired @thesahindia for the job!