[Due for payment 2025-09-09] [$250] Red dot appears on Workspaces tab instead of Account tab for subscription issues

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.94-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dubielzyk-expensify
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Use an account that has subscription issues
2. Open the app
3. Observe that a red dot appears on the Workspaces tab
4. Check the workspace list and editor — no red dots are visible there.

Expected Result:

For subscription-related issues, the red dot should appear on the Account tab (or wherever the issue can be resolved) and not on the Workspaces tab.

Actual Result:

A red dot is incorrectly shown on the Workspaces tab. No red dot appears on any specific workspace or in the workspace editor.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021956104851436892327
• Upwork Job ID: 1956104851436892327
• Last Price Increase: 2025-08-14
• Automatic offers:
• nkdengineer | Contributor | 108470747

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A red dot is incorrectly shown on the Workspaces tab. No red dot appears on any specific workspace or in the workspace editor.

What is the root cause of that problem?

We're checking the subscription info/error in the workspace tab status instead of account tab status

App/src/hooks/useWorkspacesTabIndicatorStatus.ts

Lines 42 to 49 in 32a0cf3

	const errorChecking: Partial<Record<WorkspacesTabIndicatorStatus, boolean>> = {
	...(Object.fromEntries(Object.entries(policyErrors).map(([error, policy]) => [error, !!policy])) as Record<keyof typeof policyErrors, boolean>),
	[CONST.INDICATOR_STATUS.HAS_SUBSCRIPTION_ERRORS]: hasSubscriptionRedDotError(),
	};
	const infoChecking: Partial<Record<WorkspacesTabIndicatorStatus, boolean>> = {
	[CONST.INDICATOR_STATUS.HAS_SUBSCRIPTION_INFO]: hasSubscriptionGreenDotInfo(),
	};

What changes do you think we should make in order to solve the problem?

We should move the subscription info/error checking from here to the account tab status check here

const errorChecking: Partial<Record<AccountTabIndicatorStatus, boolean>> = {
...
[CONST.INDICATOR_STATUS.HAS_SUBSCRIPTION_ERRORS]: hasSubscriptionRedDotError(),
}
const infoChecking: Partial<Record<AccountTabIndicatorStatus, boolean>> = {
    [CONST.INDICATOR_STATUS.HAS_LOGIN_LIST_INFO]: !!loginList && hasLoginListInfo(loginList, session?.email),
    [CONST.INDICATOR_STATUS.HAS_SUBSCRIPTION_INFO]: hasSubscriptionGreenDotInfo(),
};

App/src/hooks/useAccountTabIndicatorStatus.ts

Lines 33 to 47 in 32a0cf3

	const errorChecking: Partial<Record<AccountTabIndicatorStatus, boolean>> = {
	[CONST.INDICATOR_STATUS.HAS_USER_WALLET_ERRORS]: Object.keys(userWallet?.errors ?? {}).length > 0,
	[CONST.INDICATOR_STATUS.HAS_PAYMENT_METHOD_ERROR]: hasPaymentMethodError(bankAccountList, fundList),
	[CONST.INDICATOR_STATUS.HAS_REIMBURSEMENT_ACCOUNT_ERRORS]: Object.keys(reimbursementAccount?.errors ?? {}).length > 0,
	[CONST.INDICATOR_STATUS.HAS_LOGIN_LIST_ERROR]: !!loginList && hasLoginListError(loginList),
	// Wallet term errors that are not caused by an IOU (we show the red brick indicator for those in the LHN instead)
	[CONST.INDICATOR_STATUS.HAS_WALLET_TERMS_ERRORS]: Object.keys(walletTerms?.errors ?? {}).length > 0 && !walletTerms?.chatReportID,
	[CONST.INDICATOR_STATUS.HAS_CARD_CONNECTION_ERROR]: hasBrokenFeedConnection,
	[CONST.INDICATOR_STATUS.HAS_PHONE_NUMBER_ERROR]: !!privatePersonalDetails?.errorFields?.phoneNumber ?? undefined,
	};
	const infoChecking: Partial<Record<AccountTabIndicatorStatus, boolean>> = {
	[CONST.INDICATOR_STATUS.HAS_LOGIN_LIST_INFO]: !!loginList && hasLoginListInfo(loginList, session?.email),
	};

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

If need we can update useAccountTabIndicatorStatusTest test to cover the subscription error.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021956104851436892327

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[sobitneupane]

Thanks for the proposal @nkdengineer

Proposal from @nkdengineer looks good to me.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @Julesssss, see https://stackoverflow.com/c/expensify/questions/7972 for more details.