[HOLD for payment 2022-01-11] Update the Invite option to ignore leading/trailing spaces

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app
2. Navigate to Workspace
3. Go to Members >Manage Members
4. Invite any email with leading/trailing spaces

Expected Result:

Invite option should ignore leading/trailing spaces.

Actual Result:

If there is an extra space, the Invite option is grayed out until the space is removed.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.23-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @alexpensify
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1640035809422700

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mananjadhav]

Proposed Solution

This looks like a problem with all OptionsSelector instances.

1. Primarily all OptionsSelector except one, internally call OptionListUtils/getNewChatOptions. We can just .trim() in getNewchatOptions.

    return getOptions(reports, personalDetails, 0, {
        betas,
        searchValue.trim(), // Added .trim() here

2. The odd one out in SearchPage, we've already added .trim() in getSearchOptions function call.

[MelvinBot]

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[aldo-expensify]

Issue looks well described, adding External label.

[sobitneupane]

Proposal
In WorkSpaceInvite.js, we need to replace searchValue by searchValue.trim() in OnChangeText function

<OptionsSelector
                                    ---
                                    onChangeText={(searchValue = '') => {
                                        const {
                                            personalDetails,
                                            userToInvite,
                                        } = OptionsListUtils.getNewChatOptions(
                                            [],
                                            this.props.personalDetails,
                                            this.props.betas,
                                            searchValue.trim(), // <--- Change Made
                                            [],
                                            this.getExcludedUsers(),
                                        );
                                        this.setState({
                                            searchValue,
                                            userToInvite,
                                            personalDetails,
                                        });
                                    }}
                                    ---
                                />

[MitchExpensify]

Upwork Job