Android - White screen displayed after log out

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the app
2. Log in with any account
3. Send some messages or request money
4. Log out

Expected Result:

User should log out from the account and login screen appears

Actual Result:

White screen displayed after log out

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Android

Version Number: v1.1.24.0

Reproducible in staging?: Yes

Reproducible in production?: No

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Bug5390623_20211229_172356.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mananjadhav]

This has cropped up in #6898. The undefined check for the appStateSubscription is missing.

App/src/libs/AppStateMonitor/index.js

Lines 27 to 30 in 29e469a

	const appStateChangeSubscription = AppState.addEventListener('change', appStateChangeCallback);
	return () => {
	appStateChangeSubscription.remove();
	};

Change it to:

if (!appStateChangeSubscription) {
    return;
}
appStateChangeSubscription.remove();

As I commented in slack, there's a follow up PR being worked on to upgrade RN which would be the ideal fix.

cc - @aswin-s @parasharrajat Since you guys were involved in the PR.

[aldo-expensify]

Is it possible for AppState.addEventListener('change', appStateChangeCallback); to return undefined? I failed to find what it returns in the documentation :(

Documentation: https://reactnative.dev/docs/appstate#addeventlistener

[parasharrajat]

Unfortunately, PR was merged before I was able to test it.
But we are planning to upgrade the RN to v65 and this problem will be resolved there. cc: @roryabraham

[aswin-s]

Thanks @parasharrajat. Yes as explained over here, removeEventListener was deprecated only in version 0.65 and we are still on 0.64.x. So the real fix is to upgrade react native version. I already tested @roryabraham's PR on iOS and everything looks good. We might want more eyes on that PR.

[mananjadhav]

@parasharrajat @roryabraham Are we going to merge the RN upgrade PR soon? If not then we should merge the null check PR so that it can be removed from DeployBlocker. If we'll merge soon then that's the ideal fix.

[aldo-expensify]

Yes as explained over here, removeEventListener was deprecated only in version 0.65 and we are still on 0.64.x.

But... removeEventListener doesn't seem to be used here, the new way .remove() is being used.

Are we going to merge the RN upgrade PR soon

I don't think that the PR upgrading RN will be cherry picked to staging, so I agree with we should merge the null check PR so that it can be removed from DeployBlocker.