[$125] Flaky test: IOURequestEditReportCommonTest.tsx

[roryabraham]

Problem

tests/ui/IOURequestEditReportCommonTest.tsx is flaky.

Example: https://github.com/Expensify/App/actions/runs/17279245486/job/49043749500?pr=68536 (see a failing run followed by a successful one, with no code changes between.

Solution

Fix it!

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021961122968364853159
• Upwork Job ID: 1961122968364853159
• Last Price Increase: 2025-08-28

Issue Owner

Current Issue Owner: @hungvu193

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021961122968364853159

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ Failed to update price automatically. The BZ team member will need to update the price manually in Upwork.

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Flaky test: IOURequestEditReportCommonTest.tsx

What is the root cause of that problem?

The root cause looks similar with this issue #68451

It is caused by a race condition between component rendering and derived value computation in Onyx. Onyx Derived Values are computed automatically when their dependencies change. So outstandingReportsByPolicyID is a derived value that depends on:

1. ONYXKEYS.COLLECTION.REPORT (all reports)
2. ONYXKEYS.COLLECTION.POLICY (all policies)

However, it doesn't happen instantly when dependencies change

So why does it happen?
Here is the flow to demonstrate the reason

1. Test sets report data in Onyx → triggers derived value recomputation
2. Component renders immediately → derived value might not be ready yet
3. Component checks outstandingReportsByPolicyID → finds empty/undefined
4. Component shows "Not Found" page instead of expense reports
5. Test fails looking for "Expense Report" text

What changes do you think we should make in order to solve the problem?

Replace waitForBatchedUpdatesWithAct by waitForNetworkPromises which waits for async operations to complete. Thus, we ensure the derived value is computed before the component renders

App/tests/ui/IOURequestEditReportCommonTest.tsx

Line 106 in 5d9444f

await waitForBatchedUpdatesWithAct();

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.