[Due for payment 2025-10-17] [$250] Expense - Submit option is missing in More if retract and hold expense

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.2-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Explore
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Win 11/Chrome
App Component: Money Requests

Action Performed:

Precondition: Create a workspace, enable Delay submissions manually, Add approvals and Make or track payments

1. Open https://staging.new.expensify.com
2. Go to workspace chat
3. Create and submit a manual expense
4. Click on this expense
5. Click More
6. Click Retract
7. Click More
8. Click Hold and type reason hold expense
9. Click More
10. Find Submit option

Expected Result:

Submit option should display in More menu (as expected that user can submit a report with held expenses)

Actual Result:

Submit option isn't displayed in More menu

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021965438283632682136
• Upwork Job ID: 1965438283632682136
• Last Price Increase: 2025-09-16
• Automatic offers:
• nkdengineer | Contributor | 108810763

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @Ollyws

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Submit option is missing in More if retract and hold expense

What is the root cause of that problem?

The isSubmitAction function in ReportSecondaryActionUtils has incorrect logic that prevents submission for retracted reports:

App/src/libs/ReportSecondaryActionUtils.ts

Lines 176 to 179 in a81a3fd

	const hasReportBeenRetracted = hasReportBeenReopenedUtils(report, reportActions) || hasReportBeenRetractedUtils(report, reportActions);
	if (hasReportBeenRetracted && isReportSubmitter) {
	return false;
	}

This creates an inconsistency with other parts of the codebase (like ReportPrimaryActionUtils and IOU) that correctly allow submission for retracted reports.

What changes do you think we should make in order to solve the problem?

Change the return conidtion from return false to return true when a report has been retracted and the current user is the submitter.

if (hasReportBeenRetracted && isReportSubmitter) {
    return true; 
}

This aligns the More menu behavior with the existing correct behavior in other parts of the codebase.

Note: No need to copy other conditions from other proposal as all other validation conditions are done before the retract check.

Result:

Screen.Recording.2025-09-07.at.20.44.17.mov

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Add a test case in ReportSecondaryActionUtilsTest that verifies the Submit option is available for retracted reports with held expenses, ensuring the More menu shows the Submit option when expected.

code changes

    it('includes SUBMIT option for retracted report with held expenses', async () => {
        const report = {
            reportID: REPORT_ID,
            type: CONST.REPORT.TYPE.EXPENSE,
            ownerAccountID: EMPLOYEE_ACCOUNT_ID,
            stateNum: CONST.REPORT.STATE_NUM.OPEN,
            statusNum: CONST.REPORT.STATUS_NUM.OPEN,
            total: 10,
            hasReportBeenRetracted: true,
        } as unknown as Report;
        const policy = {
            autoReportingFrequency: CONST.POLICY.AUTO_REPORTING_FREQUENCIES.MANUAL,
            harvesting: {
                enabled: false,
            },
        } as unknown as Policy;
        await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${REPORT_ID}`, report);

        const transaction = {
            transactionID: 'TRANSACTION_ID',
            amount: 10,
            merchant: 'Merchant',
            date: '2025-01-01',
            comment: {
                hold: 'HOLD_ACTION_ID',
            },
        } as unknown as Transaction;

        const result = getSecondaryReportActions({report, chatReport, reportTransactions: [transaction], violations: {}, policy});
        expect(result.includes(CONST.REPORT.SECONDARY_ACTIONS.SUBMIT)).toBe(true);
    });

What alternative solutions did you explore? (Optional)

NA

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Submit option isn't displayed in More menu

What is the root cause of that problem?

We don't show the submit option in More if retract and hold expenese because of this logic

App/src/libs/ReportSecondaryActionUtils.ts

Lines 176 to 179 in 2c4dcba

	const hasReportBeenRetracted = hasReportBeenReopenedUtils(report, reportActions) || hasReportBeenRetractedUtils(report, reportActions);
	if (hasReportBeenRetracted && isReportSubmitter) {
	return false;
	}

What changes do you think we should make in order to solve the problem?

As per test steps 3 submit button after reopening a report in this PR, we only want to show submit action in More button for admin

    const hasReportBeenRetracted = hasReportBeenReopenedUtils(report, reportActions) || hasReportBeenRetractedUtils(report, reportActions);
    if (hasReportBeenRetracted && isReportSubmitter && !isAdmin && !isManager) {
        return false;
    }

App/src/libs/ReportSecondaryActionUtils.ts

Lines 176 to 179 in 2c4dcba

	const hasReportBeenRetracted = hasReportBeenReopenedUtils(report, reportActions) || hasReportBeenRetractedUtils(report, reportActions);
	if (hasReportBeenRetracted && isReportSubmitter) {
	return false;
	}

Note: We can remove the !isManager in this condition then check the other place that has the same logic

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

we should update the test for the isSubmitAction function to cover this case

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user creates a manual expense, submits it, retracts it, holds it with a reason, and then tries to submit it again, the Submit option is not displayed in the More menu. This prevents users from submitting reports that contain held expenses, which should be allowed according to the expected behavior.

What is the root cause of that problem?

The root cause is in the isSubmitAction function in

App/src/libs/ReportSecondaryActionUtils.ts

Lines 177 to 179 in c1381a6

	if (hasReportBeenRetracted && isReportSubmitter) {
	return false;
	}

The current logic incorrectly prevents submission for any retracted report when the current user is the report submitter.

This logic doesn't consider whether the report is ready to be submitted again after retraction. The logic is inconsistent with the primary action utility (src/libs/ReportPrimaryActionUtils.ts) and report preview utility (src/libs/ReportPreviewActionUtils.ts), which both correctly allow submission for retracted reports when basic submission conditions are met.

What changes do you think we should make in order to solve the problem?

Replace the incorrect logic in src/libs/ReportSecondaryActionUtils.ts with the correct logic that matches the other utilities:

// Use this correct logic:
const baseCanSubmit = isReportSubmitter && (!!isScheduledSubmitEnabled || primaryAction !== CONST.REPORT.SECONDARY_ACTIONS.SUBMIT);

// If a report has been retracted, we allow submission regardless of the auto reporting frequency.
if (hasReportBeenRetracted && baseCanSubmit) {
    return true;
}

This change aligns the secondary action logic with the primary action and report preview logic, ensuring consistent behavior across the app.

Screen.Recording.2025-09-08.at.12.52.03.AM.mov

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Create a test that verifies the Submit option appears in the More menu when:

• A report is created and submitted
• The report is retracted
• An expense in the report is held with a reason
• The user tries to access the More menu options

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Submit option is missing in the More menu when the expense is retracted and held

What is the root cause of that problem?

Currently, isSubmitAction blocks submission for retracted reports when the user is the submitter, without considering that retracted reports with held expenses should still be submittable

App/src/libs/ReportSecondaryActionUtils.ts

Lines 176 to 179 in 2c4dcba

	const hasReportBeenRetracted = hasReportBeenReopenedUtils(report, reportActions) || hasReportBeenRetractedUtils(report, reportActions);
	if (hasReportBeenRetracted && isReportSubmitter) {
	return false;
	}

What changes do we think we should make in order to solve the problem?

We can check if the report has held expenses and allow submission in that case

    const hasReportBeenRetracted = hasReportBeenReopenedUtils(report, reportActions) || hasReportBeenRetractedUtils(report, reportActions);
    const reportHasOnlyHeldExpenses = hasOnlyHeldExpenses(report?.reportID);
    if (hasReportBeenRetracted && isReportSubmitter && !reportHasOnlyHeldExpenses) {
        return false;
    }

App/src/libs/ReportSecondaryActionUtils.ts

Lines 176 to 179 in 2c4dcba

	const hasReportBeenRetracted = hasReportBeenReopenedUtils(report, reportActions) || hasReportBeenRetractedUtils(report, reportActions);
	if (hasReportBeenRetracted && isReportSubmitter) {
	return false;
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can add a test case in ReportSecondaryActionUtilsTest that verifies if it should allow submit action for retracted report with held expenses

What alternative solutions did you explore? (Optional)

None

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Submit option is missing in More if retract and hold expense

What is the root cause of that problem?

The isSubmitAction function was preventing submission for ANY report that had ever been retracted, even if the report was currently in a submittable state (like after being retracted and then held).

App/src/libs/ReportSecondaryActionUtils.ts

Lines 176 to 179 in a81a3fd

	const hasReportBeenRetracted = hasReportBeenReopenedUtils(report, reportActions) || hasReportBeenRetractedUtils(report, reportActions);
	if (hasReportBeenRetracted && isReportSubmitter) {
	return false;
	}

What changes do you think we should make in order to solve the problem?

We should check if the report is currently in a non-submittable state, not if it was ever retracted. A retracted report that is now open (e.g., after being held) should be submittable again

    const isCurrentlyRetracted = !isOpenReport && hasReportBeenRetractedUtils(report, reportActions) && !hasReportBeenReopenedUtils(report, reportActions);
    if (isCurrentlyRetracted && isReportSubmitter) {
        return false;
    }

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Update test ReportSecondaryActionUtilsTest to cover this new case

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Submit option isn't displayed in More menu

What is the root cause of that problem?

We return false here if the report is retracted, but it doesn't cover the primary action is not submit action.

App/src/libs/ReportSecondaryActionUtils.ts

Lines 177 to 179 in 5dcacfe

	if (hasReportBeenRetracted && isReportSubmitter) {
	return false;
	}

What changes do you think we should make in order to solve the problem?

We should only return false if the primary action is submit action. That ensures the submit action is displayed as primary action or secondary action when it's available

if (hasReportBeenRetracted && isReportSubmitter) {
    return primaryAction !== CONST.REPORT.SECONDARY_ACTIONS.SUBMIT;
}

App/src/libs/ReportSecondaryActionUtils.ts

Lines 177 to 179 in 5dcacfe

	if (hasReportBeenRetracted && isReportSubmitter) {
	return false;
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Add a test case in ReportSecondaryActionUtilsTest that verifies it includes the submit action in the case the report is retracted and the primary action is not submit action.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[sakluger]

I asked in Slack if we should make this external, or if the engineers who build Retract want to work on it: https://expensify.slack.com/archives/C07HPDRELLD/p1757377400357879

[sakluger]

We can make this external.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021965438283632682136