[HOLD for payment 2022-01-21] Wrong regex is being used for account number which allows alphabets on web/desktop - Reported by @thesahindia

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app
2. Navigate to settings > Workspace > Add bank account
3. Proceed to the manual flow
4. Enter IBAN

Expected Result:

No error appear when the wrong value is entered

Actual Result:

Wrong regex is being used for account number which allows alphabets on web/desktop

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• Desktop App

Version Number: 1.1.25-0
Reproducible in staging?: Y
Reproducible in production?:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43995119/148335464-396b7ab1-4af0-4291-81cb-bcdbe885a9dd.mov

Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1640031757416400

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[thesahindia]

Proposal

we need to add another regex for US bank accounts to use only numbers and we have to use it instead of IBAN

question: What should be the min-max for this input? (is it 4-17 digits for US bank accounts?)

App/src/pages/ReimbursementAccount/BankAccountStep.js

Line 91 in 580c9db

if (!CONST.BANK_ACCOUNT.REGEX.IBAN.test(this.state.accountNumber.trim())) {

Update: after @puneetlath's input

New regex for validating account number -

US_ACCOUNT_NUMBER: /^[0-9]{4,17}$/,

[MelvinBot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.