[Due for payment 2025-10-15] [$250] Scan - Scan multiple is not displayed when clicking Add expense on empty report preview

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.15-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/folder/13176932/test-cases/41237694
Issue reported by: Applause - Internal Team

Action Performed:

1. Sign in to ND
2. Open workspace chat, create a report
3. On the empty report preview tap "Add expense" - "Create expense"
4. Verify there's a scan multiple expenses option on the bottom right next to the camera trigger

Expected Result:

There's a scan multiple expenses option on the bottom right next to the camera trigger

Actual Result:

The "Scan multiple" icon is not displayed. There is a Flash icon instead

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6946594_1758064814750.Scan_multiple.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021970487285192864682
• Upwork Job ID: 1970487285192864682
• Last Price Increase: 2025-09-23
• Automatic offers:
• dominictb | Contributor | 108943794
• nkdengineer | Contributor | 108969720

Issue Owner

Current Issue Owner: @dominictb

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Scan multiple is not displayed when clicking Add expense on empty report preview

What is the root cause of that problem?

The !backToReport condition is causing the issue. When users tap "Add expense" -> "Create expense" from a report preview, the startMoneyRequest function is called with a backToReport parameter to maintain navigation context.

App/src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

Line 108 in 836c8b8

const canUseMultiScan = !isEditing && iouType !== CONST.IOU.TYPE.SPLIT && !backTo && !backToReport;

What changes do you think we should make in order to solve the problem?

Update to

    const canUseMultiScan = !isEditing && iouType !== CONST.IOU.TYPE.SPLIT && !backTo;

Can do similar to non-native file

App/src/pages/iou/request/step/IOURequestStepScan/index.tsx

Line 124 in d23040e

const canUseMultiScan = !isEditing && iouType !== CONST.IOU.TYPE.SPLIT && !backTo && !backToReport;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

There are several other ways to fix this issue, we can discuss and use the best solution based on actual expectation.

We can only disable multi-scan for specific backTo scenarios, example:

const isEditingExistingReceipt = backTo && backTo.includes('receipt');
const canUseMultiScan = !isEditing && iouType !== CONST.IOU.TYPE.SPLIT && !isEditingExistingReceipt;

Or we could keep the backToReport check but only use it for navigation purposes:

const canUseMultiScan = !isEditing && iouType !== CONST.IOU.TYPE.SPLIT && !backTo;
const shouldNavigateBackToReport = !!backToReport;

Or we could differentiate based on how the user got to the scan screen

const isFromReportPreview = !!backToReport;
const isFromEditFlow = !!backTo;
const canUseMultiScan = !isEditing && iouType !== CONST.IOU.TYPE.SPLIT && !isFromEditFlow;

Or even we could check the actual route pattern to determine if multi-scan should be available

const isCreateNewExpenseFlow = action === CONST.IOU.ACTION.CREATE && !isEditing;
const canUseMultiScan = isCreateNewExpenseFlow && iouType !== CONST.IOU.TYPE.SPLIT && !backTo;

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-09-24 16:59:38 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The "Scan multiple" icon is not displayed. There is a Flash icon instead

What is the root cause of that problem?

We're using backTo and backToReport to detect we can use multi scan

App/src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

Line 108 in 836c8b8

const canUseMultiScan = !isEditing && iouType !== CONST.IOU.TYPE.SPLIT && !backTo && !backToReport;

This way will prevent to display multi scan option when users edit the receipt, for example in

App/src/components/AttachmentModal.tsx

Line 442 in cbd519a

ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute(

but this way is not reliable since the backTo and backToReport tend to use to preserve the navigation context. In this case we add backToReport to the URL so canUseMultiScan is false

What changes do you think we should make in order to solve the problem?

We shouldn't rely on backTo or backToReport, instead we can

Solution 1: Use isReplacingReceipt when calculating canUseMultiScan

    const canUseMultiScan = !isEditing && iouType !== CONST.IOU.TYPE.SPLIT && !backTo && !isReplacingReceipt;

Solution 2: add the isReplaceReceipt to url to indicate we're editing the receipt, so don't allow for multi scan

1. Add isReplaceReceipt to MONEY_REQUEST_STEP_SCAN route

MONEY_REQUEST_STEP_SCAN: {
...
            return getUrlWithBackToParam(`${action as string}/${iouType as string}/scan/${transactionID}/${reportID}${isReplaceReceipt ? '?isReplaceReceipt=true' : ''}`, backTo);
        },
    },

2. Pass isReplaceReceipt: true when users want to edit the receipt here
3. Update

App/src/pages/iou/request/step/IOURequestStepScan/index.tsx

Line 127 in cbd519a

const canUseMultiScan = !isEditing && iouType !== CONST.IOU.TYPE.SPLIT && !backTo && !backToReport;

to

    const canUseMultiScan = !isEditing && iouType !== CONST.IOU.TYPE.SPLIT && !isReplaceReceipt;

We'll check other place that can edit the receipt to pass isReplaceReceipt

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@bfitzexpensify Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021970487285192864682