[Due for payment 2025-10-09] [$250] Reports - Search query shows "feed:" when workspace has Expensify Card

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.15-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #69197
Email or phone of affected tester (no customers): applausetester+160901kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Workspace is set up with Expensify Card feature.
• Assign at least one card to any user.

1. Go to staging.new.expensify.com
2. Go to Reports.
3. Click Unapproved card.

Expected Result:

Search query will not show "feed:".

Actual Result:

Search query shows "feed:" when workspace has Expensify Card.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6946952_1758104904546.Screen_Recording_2025-09-17_at_18.24.53.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021968705813242457077
• Upwork Job ID: 1968705813242457077
• Last Price Increase: 2025-09-25
• Automatic offers:
• truph01 | Reviewer | 108917813
• thelullabyy | Contributor | 108917815

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[abzokhattab]

🚨 Edited by proposal-police: This proposal was edited at 2025-09-25 19:01:29 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search query shows "feed:" when workspace has Expensify Card but no default feed ID is available.

What is the root cause of that problem?

• In SearchUIUtils, when defaultFeedID is not available, the code sets feed: [''] here
  The buildQueryStringFromFilterFormValues function processes this empty string and adds feed:"" to the query string
• This results in the unwanted "feed:" prefix appearing in search queries

What changes do you think we should make in order to solve the problem?

• Update getSuggestedSearches to use CONST.EXPENSIFY_CARD.BANK as fallback when no default feed ID is available:

  feed: defaultFeedID ? [defaultFeedID] : [CONST.EXPENSIFY_CARD.BANK],

• Additionally, harden the query builder to filter out empty strings from array filters:

       if (
                (filterKey === FILTER_KEYS.CATEGORY ||
                    filterKey === FILTER_KEYS.CARD_ID ||
                    filterKey === FILTER_KEYS.TAX_RATE ||
                    filterKey === FILTER_KEYS.EXPENSE_TYPE ||
                    filterKey === FILTER_KEYS.TAG ||
                    filterKey === FILTER_KEYS.CURRENCY ||
                    filterKey === FILTER_KEYS.PURCHASE_CURRENCY ||
                    filterKey === FILTER_KEYS.FROM ||
                    filterKey === FILTER_KEYS.TO ||
                    filterKey === FILTER_KEYS.FEED ||
                    filterKey === FILTER_KEYS.IN ||
                    filterKey === FILTER_KEYS.ASSIGNEE ||
                    filterKey === FILTER_KEYS.POLICY_ID ||
                    filterKey === FILTER_KEYS.HAS ||
                    filterKey === FILTER_KEYS.EXPORTER ||
                    filterKey === FILTER_KEYS.ATTENDEE) &&
                Array.isArray(filterValue) &&
                filterValue.length > 0
            ) {
                const filterValueArray = [...new Set<string>(filterValue.filter((value) => value.trim() !== ''))];
                const keyInCorrectForm = (Object.keys(CONST.SEARCH.SYNTAX_FILTER_KEYS) as FilterKeys[]).find((key) => CONST.SEARCH.SYNTAX_FILTER_KEYS[key] === filterKey);

                if (keyInCorrectForm && filterValueArray.length > 0) {
                    return `${CONST.SEARCH.SYNTAX_FILTER_KEYS[keyInCorrectForm]}:${filterValueArray.map(sanitizeSearchValue).join(',')}`;
                }
            }

`

This approach uses the established "Expensify Card" fallback that users expect to see and prevents empty feed filters from appearing in search queries.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reports - Search query shows "feed:" when workspace has Expensify Card

What is the root cause of that problem?

We set feed: defaultFeedID ? [defaultFeedID] : [''] here

App/src/libs/SearchUIUtils.ts

Line 477 in b1af723

feed: defaultFeedID ? [defaultFeedID] : [''],

When defaultFeedID is undefined or empty, this creates an array with an empty string [''], which gets processed by the query builder and "feed:" prefix displayed in search queries

What changes do you think we should make in order to solve the problem?

We can conditionally include the feed filter only when a valid defaultFeedID exists to prevents empty feed values from being created in the first place

            searchQuery: buildQueryStringFromFilterFormValues({
                type: CONST.SEARCH.DATA_TYPES.EXPENSE,
                ...(defaultFeedID && { feed: [defaultFeedID] }),
                groupBy: CONST.SEARCH.GROUP_BY.CARD,
                status: [CONST.SEARCH.STATUS.EXPENSE.DRAFTS, CONST.SEARCH.STATUS.EXPENSE.OUTSTANDING],
            }),

App/src/libs/SearchUIUtils.ts

Lines 475 to 480 in b1af723

	searchQuery: buildQueryStringFromFilterFormValues({
	type: CONST.SEARCH.DATA_TYPES.EXPENSE,
	feed: defaultFeedID ? [defaultFeedID] : [''],
	groupBy: CONST.SEARCH.GROUP_BY.CARD,
	status: [CONST.SEARCH.STATUS.EXPENSE.DRAFTS, CONST.SEARCH.STATUS.EXPENSE.OUTSTANDING],
	}),

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can add test for getSuggestedSearches

What alternative solutions did you explore? (Optional)

None

[lorretheboy]

🚨 Edited by proposal-police: This proposal was edited at 2025-09-24 01:23:29 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search query shows "feed:" when workspace has Expensify Card.

What is the root cause of that problem?

When we don't have feed ID, we set its default value to [''] in SEARCH_KEYS.STATEMENTS and SEARCH_KEYS.UNAPPROVED_CARD

App/src/libs/SearchUIUtils.ts

Line 435 in 29c8229

feed: defaultFeedID ? [defaultFeedID] : [''],

App/src/libs/SearchUIUtils.ts

Line 477 in 29c8229

feed: defaultFeedID ? [defaultFeedID] : [''],

So that it uses empty string values to generate query key

App/src/libs/SearchQueryUtils.ts

Line 559 in 29c8229

const filterValueArray = [...new Set<string>(filterValue)];

What changes do you think we should make in order to solve the problem?

We should fall back to CONST.EXPENSIFY_CARD.BANK (We don't have to check workspace condition since Unapproved card tab only shows under specific conditions) - Just in case we still want to check, we could check in the parent component and pass it to new props fallBackFeedId

App/src/libs/SearchUIUtils.ts

Line 477 in 29c8229

feed: defaultFeedID ? [defaultFeedID] : [''],

Optional: To highlight the expensify card default value, we can add

        case CONST.SEARCH.SYNTAX_FILTER_KEYS.FEED:
            return substitutionMap[`${range.key}:${range.value}`] !== undefined || range.value === CONST.EXPENSIFY_CARD.BANK;

App/src/libs/SearchAutocompleteUtils.ts

Line 153 in 9cc8853

Optional: I think we should not show the selection button since Expensify Card is just a fallback value. However, if needed, we can add the selection button by update the values here to check if CONST.EXPENSIFY_CARD.BANK then we should show Expensify card option

App/src/components/Search/SearchPageHeader/SearchFiltersBar.tsx

Line 444 in 47516da

...(shouldDisplayGroupByFilter

And seed the default values here

App/src/components/Search/SearchPageHeader/SearchFiltersBar.tsx

Line 483 in 47516da

: []),

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Can add test to cover empty cases for getSuggestedSearches

What alternative solutions did you explore? (Optional)

We should not show UNAPPROVED_CARD section if user doesn't have any feed

        const isEligibleForUnapprovedCardSuggestion = isPaidPolicy && isAdmin && isApprovalEnabled && hasCardFeed;

App/src/libs/SearchUIUtils.ts

Line 555 in 4f37d8c

const isEligibleForUnapprovedCardSuggestion = isPaidPolicy && isAdmin && isApprovalEnabled && (hasCardFeed || isECardEnabled);

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[ShridharGoel]

🚨 Edited by proposal-police: This proposal was edited at 2025-09-23 20:05:40 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

In workspaces where Expensify Cards are enabled but no company card feed record loads, the "Unapproved card" search shows feed: in the input field.

What is the root cause of that problem?

• getSuggestedSearches seeds the canned searches with feed: defaultFeedID ? [defaultFeedID] : [''], so when defaultFeedID is missing the query still receives an array containing an empty string.
• buildQueryStringFromFilterFormValues only checks filterValue.length > 0, therefore [''] is considered valid and rendered as feed: with no value.
• getSuggestedSearchesVisibility marks the Unapproved Card shortcut as visible whenever a paid policy has Expensify Cards enabled, even if no feed metadata exists - so the empty array path is exercised whenever the feature is enabled via toggle alone.

What changes do you think we should make in order to solve the problem?

• Resolve the canned search feed identifier before building the query so we never inject placeholder empty strings. Derive a fallback of CONST.EXPENSIFY_CARD.BANK when the shortcut is eligible but we lack a concrete feed ID.
• Harden the query builder to strip empty or whitespace-only entries from every array-based filter, ensuring future callers cannot surface blank filters.
• Keep the UI consistent by re-using the localized Expensify Card label when we depend on the fallback so admins still see an explicit feed:"Expensify Card" hint.

function getSuggestedSearches(
    accountID: number = CONST.DEFAULT_NUMBER_ID,
    defaultFeedID?: string,
    fallbackFeedID?: string,
): Record<ValueOf<typeof CONST.SEARCH.SEARCH_KEYS>, SearchTypeMenuItem> {
    const resolvedFeedID = defaultFeedID ?? fallbackFeedID;

    return {
        [CONST.SEARCH.SEARCH_KEYS.STATEMENTS]: {
            key: CONST.SEARCH.SEARCH_KEYS.STATEMENTS,
            translationPath: 'search.statements',
            type: CONST.SEARCH.DATA_TYPES.EXPENSE,
            icon: Expensicons.CreditCard,
            searchQuery: buildQueryStringFromFilterFormValues({
                type: CONST.SEARCH.DATA_TYPES.EXPENSE,
                ...(resolvedFeedID ? {feed: [resolvedFeedID]} : {}),
                groupBy: CONST.SEARCH.GROUP_BY.CARD,
                postedOn: CONST.SEARCH.DATE_PRESETS.LAST_STATEMENT,
            }),
            // ...
        },
        [CONST.SEARCH.SEARCH_KEYS.UNAPPROVED_CARD]: {
            key: CONST.SEARCH.SEARCH_KEYS.UNAPPROVED_CARD,
            translationPath: 'search.unapprovedCard',
            type: CONST.SEARCH.DATA_TYPES.EXPENSE,
            icon: Expensicons.CreditCardHourglass,
            searchQuery: buildQueryStringFromFilterFormValues({
                type: CONST.SEARCH.DATA_TYPES.EXPENSE,
                ...(resolvedFeedID ? {feed: [resolvedFeedID]} : {}),
                groupBy: CONST.SEARCH.GROUP_BY.CARD,
                status: [CONST.SEARCH.STATUS.EXPENSE.DRAFTS, CONST.SEARCH.STATUS.EXPENSE.OUTSTANDING],
            }),
            // ...
        },
        // ...
    };
}

function createTypeMenuSections(
    currentUserEmail: string | undefined,
    currentUserAccountID: number | undefined,
    cardFeedsByPolicy: Record<string, CardFeedForDisplay[]>,
    defaultCardFeed: CardFeedForDisplay | undefined,
    policies: OnyxCollection<OnyxTypes.Policy>,
    activePolicyID: string | undefined,
    savedSearches: OnyxEntry<OnyxTypes.SaveSearch>,
    isOffline: boolean,
): SearchTypeMenuSection[] {
    const suggestedSearchesVisibility = getSuggestedSearchesVisibility(currentUserEmail, cardFeedsByPolicy, policies);
    const shouldFallbackToExpensifyCard =
        suggestedSearchesVisibility[CONST.SEARCH.SEARCH_KEYS.UNAPPROVED_CARD] &&
        !defaultCardFeed &&
        Object.values(policies ?? {}).some((policy) => policy && isPaidGroupPolicy(policy) && policy.areExpensifyCardsEnabled);

    const suggestedSearches = getSuggestedSearches(
        currentUserAccountID,
        defaultCardFeed?.id,
        shouldFallbackToExpensifyCard ? CONST.EXPENSIFY_CARD.BANK : undefined,
    );

    // ...
}

function buildQueryStringFromFilterFormValues(filterValues: Partial<SearchAdvancedFiltersForm>) {
    // ...
            if (
                (filterKey === FILTER_KEYS.CATEGORY ||
                    filterKey === FILTER_KEYS.CARD_ID ||
                    filterKey === FILTER_KEYS.TAX_RATE ||
                    filterKey === FILTER_KEYS.EXPENSE_TYPE ||
                    filterKey === FILTER_KEYS.TAG ||
                    filterKey === FILTER_KEYS.CURRENCY ||
                    filterKey === FILTER_KEYS.PURCHASE_CURRENCY ||
                    filterKey === FILTER_KEYS.FROM ||
                    filterKey === FILTER_KEYS.TO ||
                    filterKey === FILTER_KEYS.FEED ||
                    filterKey === FILTER_KEYS.IN ||
                    filterKey === FILTER_KEYS.ASSIGNEE ||
                    filterKey === FILTER_KEYS.POLICY_ID ||
                    filterKey === FILTER_KEYS.HAS ||
                    filterKey === FILTER_KEYS.IS ||
                    filterKey === FILTER_KEYS.EXPORTER ||
                    filterKey === FILTER_KEYS.ATTENDEE) &&
                Array.isArray(filterValue)
            ) {
                const filterValueArray = [...new Set<string>(filterValue.filter((value) => value.trim() !== ''))];
                if (filterValueArray.length === 0) {
                    return undefined;
                }

                const keyInCorrectForm = (Object.keys(CONST.SEARCH.SYNTAX_FILTER_KEYS) as FilterKeys[]).find(
                    (key) => CONST.SEARCH.SYNTAX_FILTER_KEYS[key] === filterKey,
                );

                if (keyInCorrectForm) {
                    return `${CONST.SEARCH.SYNTAX_FILTER_KEYS[keyInCorrectForm]}:${filterValueArray.map(sanitizeSearchValue).join(',')}`;
                }
            }
    // ...
}

Note: It will not show as a dropdown if we have just the single Expensify Card feed.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• Unit test buildQueryStringFromFilterFormValues to confirm arrays containing only empty strings produce no filter and mixed values retain only the non-empty entries.
• Test covering the normal path where a real feed ID exists to ensure we still surface that ID and do not overwrite it with the fallback.

What alternate solutions did you explore?

The feed filter can be removed for this scenario.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021968705813242457077

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @truph01 (External)