[HOLD for payment 2022-01-27] [HOLD for payment 2022-01-25] Login form and setPassword form overlap with the footer on iPod - reported by @anthony-hull

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app
2. Sign up for a new account
3. Navigate from email link to the App to set the password
4. Log out
5. Log back in and check password page

Expected Result:

Test should not overlap on smaller screens

Actual Result:

Text overlaps with the the fine print in the footer

Workaround:

unknown

Platform:

Where is this issue occurring?

• iOS

Version Number: 1.1.26-0
Reproducible in staging?: Y
Reproducible in production?:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @anthony-hull
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1640888289276500

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[MelvinBot]

Current assignee @puneetlath is eligible for the Exported assigner, not assigning anyone new.

[puneetlath]

Upwork job here: https://www.upwork.com/jobs/~016e2bf25a63e93117

[mdneyazahmad]

Proposal

Reason

Signingpage has a custom style for iOS, where we are resetting the page height to fixed styles.flex1. On a large screen there are more spaces and the content don't have to overflow. But on iPod, the screen size is smaller and the page content does not fit in the screen, the result, it overflows the bottom content.

App/src/pages/signin/SignInPageLayout/signInPageStyles/index.js

Lines 1 to 5 in b9d9dc1

	import styles from '../../../../styles/styles';
	const scrollViewContentContainerStyles = styles.mnh100;
	export default scrollViewContentContainerStyles;

App/src/pages/signin/SignInPageLayout/signInPageStyles/index.ios.js

Lines 1 to 3 in b9d9dc1

	import styles from '../../../../styles/styles';
	const scrollViewContentContainerStyles = styles.flex1;

Solution

Set the page minimum height to 100% always and not flex 1 so that it will grow if the content does not fit in the screen. Just remove file src/pages/signin/SignInPageLayout/signInPageStyles/index.ios.js.

Result