[HOLD for payment 2022-02-09] Saving self-select pronoun with a space at the end doesn't disable save button - reported by @Tushu17

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app
2. Navigate to Settings > Profile
3. Select Self select pronoun in dropdown
4. Enter any text with a space at the end
5. Save

Expected Result:

Save button should be disabled after saving

Actual Result:

Save button stays active after saving

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.27-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.380.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Tushu17
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1641494947043600

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @Luke9389 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[sobitneupane]

Reason
Here, we have saved the pronoun by trimming it. But, to disable or activate the button we are comparing trimmed and untrimmed pronouns.
Proposal
We need to change following line of code in ProfilePage.js

App/src/pages/settings/Profile/ProfilePage.js

Line 180 in b9d9dc1

const arePronounsUnchanged = this.props.myPersonalDetails.pronouns === this.state.pronouns;

by

        const arePronounsUnchanged = this.props.myPersonalDetails.pronouns === this.state.pronouns.trim();

Later arePronounsUnchanged is used to disable the button.

[MelvinBot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[Luke9389]

@sobitneupane, thanks for your proposal. We actually haven't exported this issue yet, so proposals aren't really supposed to happen at this stage. That said, your idea is spot on, so when a contributor manager gets assigned here, I'll have them hire you on upwork. Just remember, in the future, wait to see the Exported label on the issue before submitting a proposal.

Thanks!

[sobitneupane]

Thank You for the suggestion. I will follow your suggestion moving forward.