No results show up when multiple separate card feeds are applied on Reports > Statements

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.23-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #67450
Email or phone of affected tester (no customers): applausetester+041001kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Search

Action Performed:

Precondition:

• Workspace is set up with Expensify card.
• Workspace has a Wells Fargo direct feed with imported transactions.

1. Go to staging.new.expensify.com
2. Go to Reports > Unapproved card.
3. Click Feed.
4. Select both Wells Fargo and Expensify Card feed.
5. Click Apply.
   → Transactions from Wells Fargo feed show up when both Wells Fargo and Expensify Card feed are applied.
6. Go to Reports > Statements.
7. Click Feed.
8. Select both Wells Fargo and Expensify Card feed.
9. Click Apply.

Expected Result:

Transactions from Wells Fargo feed will show up when both Wells Fargo and Expensify Card feed are applied on Reports > Statements.

Actual Result:

Transactions from Wells Fargo feed disappear when both Wells Fargo and Expensify Card feed are applied on Reports > Statements.
It shows no results.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

11.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @luacmartins

Issue Owner

Current Issue Owner: @luacmartins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mukhrr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When users navigate to Reports > Statements and select both Wells Fargo and Expensify Card feed filters, transactions from the Wells Fargo feed disappear and show no results. However, the same filter combination works correctly on the Reports > Unapproved Card page where all transactions from both feeds are displayed properly.

What is the root cause of that problem?

The Statements view defaults to the "Last statement" date preset (posted:on last-statement), which is tied to a single feed's statement close date. When multiple feeds are selected (e.g., Wells Fargo + Expensify Card), each feed has its own distinct statement close date.

What changes do you think we should make in order to solve the problem?

In the buildQueryStringFromFilterFormValues function, we need to add logic to automatically replace the "Last statement" preset with "Last month" (the closest option to "Last Statment") when multiple feeds are selected:

    const selectedFeeds = supportedFilterValues[FILTER_KEYS.FEED];
    const postedOnKey = `${CONST.SEARCH.SYNTAX_FILTER_KEYS.POSTED}${CONST.SEARCH.DATE_MODIFIERS.ON}` as const;
    if (Array.isArray(selectedFeeds) && selectedFeeds.length > 1 && supportedFilterValues[postedOnKey] === CONST.SEARCH.DATE_PRESETS.LAST_STATEMENT) {
        supportedFilterValues[postedOnKey] = CONST.SEARCH.DATE_PRESETS.LAST_MONTH;
    }

We shouldn't just remove posted:last-statement as it badly affects performance in case there a lots of transactions from all feeds. By replacing it with "last month", we support user's intent to see recent transactions.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can add tests to tests/unit/Search/SearchQueryUtilsTest.ts to check we replace Last statement with Last month when more than one feeds are applied on feed filter.

What alternative solutions did you explore? (Optional)

[andriivitiv]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No results appear when multiple feeds are applied on Reports > Statements page.

What is the root cause of that problem?

The issue is that posted:last-statement filter only works when a single feed is selected. When multiple feeds are selected, the backend does not return any statements.

What changes do you think we should make in order to solve the problem?

Remove posted:last-statement from the query when more than 1 feed is selected

App/src/components/Search/SearchPageHeader/SearchFiltersBar.tsx

Line 368 in 1c97603

updateFilterForm({feed: items.map((item) => item.value)});

updateFilterForm({
     feed: items.map((item) => item.value),
     postedOn: items.length === 1 
         ? filterFormValues.postedOn
         : filterFormValues.postedOn === CONST.SEARCH.DATE_PRESETS.LAST_STATEMENT ? undefined : filterFormValues.postedOn,
});

Optionally, hide "Last statement" option from the "Posted" selector page when more than 1 feed is selected

App/src/components/Search/SearchDatePresetFilterBasePage.tsx

Lines 44 to 47 in 1c97603

	const presets = useMemo(() => {
	const hasFeed = !!searchAdvancedFiltersForm?.feed?.length;
	return getDatePresets(dateKey, hasFeed);
	}, [dateKey, searchAdvancedFiltersForm?.feed]);

const presets = useMemo(() => {
    const hasSingleFeedSelected = searchAdvancedFiltersForm?.feed.length === 1;
    return getDatePresets(dateKey, hasSingleFeedSelected);
}, [dateKey, searchAdvancedFiltersForm?.feed]);

and apply similar logic on the search bar pop-up selector here and on the autocomplete here.

What alternative solutions did you explore? (Optional)

Maybe it's a bug on backend that posted:last-statement doesn't work when more that 1 feed is selected.

[mukhrr]

Updated proposal

[RachCHopkins]

There is no Wells Fargo feed on that account/workspace. But why would we show two statements mixed into one? I don't think I understand this issue.

Is this specific to Wells Fargo direct feeds?

Testing...

[RachCHopkins]

I do not have Reports > Statements.

Help docs say:

Who can access Statement Matching and Reconciliation
Workspace Admins with:

• the Expensify Card, or
• at least one company card feed connected,

I have two feeds connected, so in theory I should see it.

[RachCHopkins]

I don't see anything in Testrail that would suggest you should see a mélange of two different feeds in a "statement". TBH that would be a bit weird.

We should probably make it so that only one feed can be selected at a time. What do you think @luacmartins?

And do you have any insight into why manager.rach+BZ@expensicorp.com can't see Reports > Statements?

[mukhrr]

• the Expensify Card, or
• at least one company card feed connected,

@RachCHopkins make sure it is "AND" not "OR". I mean you should have assigned expensify card and at least one company card feed connected. And it's not Wells Fargo specific. You can connect any other card

[mukhrr]

We should probably make it so that only one feed can be selected at a time

@RachCHopkins I think it makes more sense that we can select as many as possible. At least, we do that in Reports > Unapproved card page

[luacmartins]

I think this is a bug. The Accounting > Statements page is used for statement matching, so we do want users to be able to select multiple feeds and see the totals per card. The BE should be handling the multiple statement closing dates, but it seems to be doing that incorrectly. I'll investigate this in the BE.