[HOLD for payment 2022-02-08] When you enter wrong password on VBA page, incorrect error displayed - reported by @Tushu17

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app
2. Navigate to Workspace > Add bank account or Settings > Payment > Add Payment > Add bank account
3. Select Plaid > Wells Fargo & login
4. Select Savings account and enter incorrect account password

Expected Result:

Error should only show incorrect password not incorrect login.

Actual Result:

On bank account page when you enter wrong password it shows Incorrect login or password. Please try again.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.30-0
Reproducible in staging?: Y
Reproducible in production?:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @Tushu17
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1642111626448100

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Tushu17]

Proposal (if considered external)

we need to add incorrectPassword: 'Incorrect password. Please try again.' here -

App/src/languages/en.js

Lines 422 to 425 in 74cf52f

	error: {
	incorrectLoginOrPassword: 'Incorrect login or password. Please try again.',
	twoFactorAuthenticationEnabled: 'You have 2FA enabled on this account. Please sign in using your email or phone number.',
	invalidLoginOrPassword: 'Invalid login or password. Please try again or reset your password.',

and we need to add incorrectPassword: 'Contraseña incorrecta. Por favor inténtalo de nuevo' here -

App/src/languages/es.js

Lines 422 to 425 in 74cf52f

	error: {
	incorrectLoginOrPassword: 'Usuario o clave incorrectos. Por favor inténtalo de nuevo',
	twoFactorAuthenticationEnabled: 'Tienes autenticación de 2 factores activada en esta cuenta. Por favor conéctate usando su email o número de teléfono',
	invalidLoginOrPassword: 'Usuario o clave incorrectos. Por favor inténtalo de nuevo o resetea tu clave',

then we need to use passwordForm.error.incorrectPassword on line 120

App/src/components/AddPlaidBankAccount.js

Lines 119 to 121 in 74cf52f

	this.getErrorText = inputKey => ReimbursementAccountUtils.getErrorText(this.props, {
	password: 'passwordForm.error.incorrectLoginOrPassword',
	}, inputKey);

correct me if the spanish is wrong.

[robertjchen]

Thanks for the proposal, those changes look correct! 👍 I can also confirm that the Spanish translation is correct.

[MelvinBot]

Triggered auto assignment to @bfitzexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[bfitzexpensify]

Upwork post here - @Tushu17, please apply there for a reporting bonus.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)