[Due for payment 2025-12-23] [Due for payment 2025-11-20] [$250] Expense - Error submitting expense after changing submission frequency from Manual to Instant

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.32-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1307/folder/13176741/41237125/955760209
Email or phone of affected tester (no customers): jsdoijsdnoidnsjodj@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Create a workspace
3. Go to workspace chat
4. Create an expense in workspace chat
5. Click Submit on the expense preview
6. Go to workspace settings > Workflows
7. Disable Add approvals and Make or track payments
8. Change Submission frequency to Instantly
9. Go back to workspace chat
10. Create another expense

Expected Result:

New expense will be created without issue after disabling Add approvals and Make or track payments and changing Submission frequency to Instantly

Actual Result:

Error shows up when creating new expense after disabling Add approvals and Make or track payments and changing Submission frequency to Instantly

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6976562_1760617722513.Screen_Recording_2025-10-16_at_20.22.54.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021978870049204851526
• Upwork Job ID: 1978870049204851526
• Last Price Increase: 2025-10-16
• Automatic offers:
• FitseTLT | Contributor | 109226875

Issue Owner

Current Issue Owner: @brunovjk

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Error submitting expense after changing submission frequency from Manual to Instant

What is the root cause of that problem?

Whenever the policy is instant submit and approval is disabled and there is no payment to do we cannot add transaction to an expense report. But here we are only checking for the case where all transactions are non-reimbursable and we missing the case where payment is disabled

App/src/libs/ReportUtils.ts

Lines 2585 to 2591 in ec0568b

	if (isInstantSubmitEnabled(policy) && isSubmitAndClose(policy) && hasOnlyNonReimbursableTransactions(moneyRequestReport?.reportID)) {
	return false;
	}
	return canAddOrDeleteTransactions(moneyRequestReport, isReportArchived);
	}

What changes do you think we should make in order to solve the problem?

We should also return false in canAddTransaction if the reimbursementChoice is no even if there are reimbursable transactions

if (
        isInstantSubmitEnabled(policy) &&
        isSubmitAndClose(policy) &&
        (hasOnlyNonReimbursableTransactions(moneyRequestReport?.reportID) || policy?.reimbursementChoice === CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_NO)
    ) {
        return false;

We use canAddTransaction for IOURequestEditReportCommon here

App/src/pages/iou/request/step/IOURequestEditReportCommon.tsx

Line 143 in ec0568b

.filter((report) => canAddTransaction(report))

but from my testing moving transactions to the report doesn't return error so if that is an expected behavior then we will not apply this condition for IOURequestEditReportCommon case.

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021978870049204851526

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

[melvin-bot]

@brunovjk Whoops! This issue is 2 days overdue. Let's get this updated quick!

[brunovjk]

Not overdue, it's on my list, reviewing ASAP.