[Due for payment 2025-12-16] [$250] Expense - Self DM chat is created when "Upgrade" on "Rate" option

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.35-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1390/folder/13176744/41237135/964486553
Email or phone of affected tester (no customers): gocemate+b2154df625@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Preconditions: User has no workspace and no Self DM chat

1. Login with gmail account> Finish the onboarding process
2. Go to FAB> Track distance> Manual> Add amount> Next
3. On Choose recipient modal add any user email address
4. On Confirm details modal click on Rate> Upgrade> Got it thanks
5. On Rate page add a rate> Safe
6. On Confirm details page click on To:
7. Verify Choose recipient modal opens

Expected Result:

There should be no Self DM chat in the list

Actual Result:

Self DM chat appears in Choose recipient modal list

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6980700_1761060293818.Recording__6259.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021985790101976019434
• Upwork Job ID: 1985790101976019434
• Last Price Increase: 2025-11-04

[melvin-bot]

Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mukhrr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user tracks a distance expense and returns to the Choose recipient modal, their Self DM chat appears in the recipient list

What is the root cause of that problem?

In MoneyRequestParticipantsSelector.tsx we always passed includeSelfDM: true for the track distance

App/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

Line 199 in b40a833

includeSelfDM: !isMovingTransactionFromTrackExpense(action) && iouType !== CONST.IOU.TYPE.INVOICE,

The code above causes Self DM to appear for all iouTypes by default, including TRACK, CREATE, and SUBMIT flows where sending money to yourself doesn't make sense.

What changes do you think we should make in order to solve the problem?

we need to show self dm where only paying or sending to user's himself is valid.

includeSelfDM: (iouType === CONST.IOU.TYPE.SEND || iouType === CONST.IOU.TYPE.PAY) && !isMovingTransactionFromTrackExpense(action)

What alternative solutions did you explore? (Optional)

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Onboarding choice is "Something else" but Self DM chat is created when "Upgrade" on "Rate" option
• Open the self DM has "Report not found" error and it disappears

What is the root cause of that problem?

From this PR #71015, if the onboarding choice is TRACK_WORKSPACE, we automatically create the self DM. And when creating workspace from upgrade flow, the onboarding choice is also TRACK_WORKSPACE:

App/src/pages/iou/request/step/IOURequestStepUpgrade.tsx

Line 117 in 31d26b1

engagementChoice: CONST.ONBOARDING_CHOICES.TRACK_WORKSPACE,

App/src/libs/ReportUtils.ts

Lines 11158 to 11164 in 092472e

	if (engagementChoice === CONST.ONBOARDING_CHOICES.PERSONAL_SPEND || engagementChoice === CONST.ONBOARDING_CHOICES.TRACK_WORKSPACE) {
	const selfDMReportID = findSelfDMReportID();
	let selfDMReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${selfDMReportID}`];
	let createdAction: ReportAction;
	if (!selfDMReport) {
	const currentTime = DateUtils.getDBTime();
	selfDMReport = buildOptimisticSelfDMReport(currentTime);

That was added to fix the issue where user initially selected "Track and budget expenses" (PERSONAL_SPEND) then create workspace in the next step (TRACK_WORKSPACE) but the self DM is not created. See #64120.

But in this issue, user's initial selected onboarding purpose is "Something else" which is supposed not to have a self DM. You can check this by going to the self DM directly and the BE will responds Report not found error.

What changes do you think we should make in order to solve the problem?

Improve this condition by checking user's initial selected onboarding purpose as well:

App/src/libs/ReportUtils.ts

Line 11158 in 092472e

if (engagementChoice === CONST.ONBOARDING_CHOICES.PERSONAL_SPEND || engagementChoice === CONST.ONBOARDING_CHOICES.TRACK_WORKSPACE) {

if (engagementChoice === CONST.ONBOARDING_CHOICES.PERSONAL_SPEND || (introSelected?.choice === CONST.ONBOARDING_CHOICES.PERSONAL_SPEND && engagementChoice === CONST.ONBOARDING_CHOICES.TRACK_WORKSPACE)) {

Or we can use the ONBOARDING_PURPOSE_SELECTED Onyx data instead of introSelected.choice.

What alternative solutions did you explore? (Optional)

None

[melvin-bot]

@heyjennahay 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@heyjennahay Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot]

@heyjennahay 12 days overdue. Walking. Toward. The. Light...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021985790101976019434