[HOLD for payment 2022-02-08] Close Account warning modal shown on opening the page - reported by @parasharrajat

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the close account page from Settings => Close Account.
2. fill required info, Click close account.
3. Now there is a modal is shown for some accounts.
4. Now close the app without closing the modal.
5. Restart the app and go back the close account page.

Expected Result:

Modal should not display on opening

Actual Result:

Close Account warning modal shown on opening the page

Workaround:

unknown

Platform:

Where is this issue occurring?

• iOS
• Android

Version Number: 1.1.31-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-2022-01-15_23.57.25.mp4

Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1642271359491600

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[parasharrajat]

Waiting for triage before putting a proposal...

[mountiny]

cc @Julesssss might be the best one to handle this CME if this would be made External.

[danieldoglas]

Confirmed this is a bug that can be fixed through updates in the App only.

[MelvinBot]

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[parasharrajat]

Yeah, we can fix it from the app easily.

Proposal

1. We should use initWithStoredValues: false for this key

   App/src/pages/settings/Security/CloseAccountPage.js

   Line 143 in 7dfe96f

   key: ONYXKEYS.IS_CLOSE_ACCOUNT_MODAL_OPEN,

   .

so that it does not take stored values. This key is supposed to be used on runtime in one session.