[$250] Expensify card - After re-login the Add approvals toggle is not locked and can de disabled

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.36-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176890/test-cases/41237379
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: MacBook Air 15.6.1 Chrome, iPhone 15 iOS 18.5 Safari
App Component: Workspace Settings

Action Performed:

Preconditions:
Use new expensifail account, create a new workspace, disable Workflows in More features
Enable Expensify card in More features, click "Issue a card", "Log in to your bank account" and connect Regions Saving 1111
Assign a virtual card with fixed amount to yourself

1. Go to workspace settings > Workflows, enable Add approvals.
2. Go to workspace settings > Expensify card.
3. Click on the virtual card assigned.
4. Click Limit type, select Smart limit and save it.
5. Go to workspace settings > Workflows.
6. Verify Workflows toggle switch on Add approvals is locked
7. Sign out and sign in again with the same Admin's account
8. Open the workspace settings, Workflows, observe the toggle on the Add approvals
9. Try to disable the toggle

Expected Result:

Workflows toggle switch on Add approvals remains locked after re-logging

Actual Result:

Workflows toggle switch on Add approvals is not locked after re-logging, and can be disabled

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021984269290519629850
• Upwork Job ID: 1984269290519629850
• Last Price Increase: 2025-10-31
• Automatic offers:
• truph01 | Reviewer | 109504854

Issue Owner

Current Issue Owner: @getusha

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After re-login, the "Add approvals" toggle is not locked when an Expensify Card has a Smart Limit enabled.

What is the root cause of that problem?

• The WorkspaceWorkflowsPage calculates whether the toggle should be locked by checking if any workspace cards have Smart Limits enabled via isSmartLimitEnabled(workspaceCards) here
• This check depends on card data being loaded in Onyx from the WORKSPACE_CARDS_LIST collection
• When the page loads, the fetchData function only calls openPolicyWorkflowsPage() and getPaymentMethods(), but does not call openPolicyExpensifyCardsPage() to fetch the card data
• Without the API call to load card data, the cardList remains empty, causing isSmartLimitEnabled to incorrectly return false
• This makes the toggle appear unlocked even when it should be locked

What changes do you think we should make in order to solve the problem?

In WorkspaceWorkflowsPage.tsx:

• Add openPolicyExpensifyCardsPage() call inside the fetchData callback to ensure Expensify Card data is loaded when the page opens

    const fetchData = useCallback(() => {
        openPolicyWorkflowsPage(route.params.policyID);
        openPolicyExpensifyCardsPage(route.params.policyID, workspaceAccountID);
        getPaymentMethods();
    }, [route.params.policyID, workspaceAccountID]);

This ensures the card data is available for the isSmartLimitEnabled check to work correctly after re-login.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify card - After re-login the Add approvals toggle is not locked and can de disabled

What is the root cause of that problem?

The root cause is that the WorkspaceWorkflowsPage component

We subscribes to the entire WORKSPACE_CARDS_LIST collection instead of a specific workspace's cards

App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

Line 73 in cad0499

const [cardList] = useOnyx(`${ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST}`, {canBeMissing: false});

We does NOT fetch the Expensify cards data when the page loads - it only calls openPolicyWorkflowsPage() which doesn't fetch card data

App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

Line 113 in cad0499

openPolicyWorkflowsPage(route.params.policyID);

So that when a user signs out and signs back in, the Onyx cache for workspace cards may not be populated yet, so isSmartLimitEnabled returns false even though there are cards with smart limits

What changes do you think we should make in order to solve the problem?

We should call openPolicyExpensifyCardsPage with appropriate workspaceAccountID

        openPolicyExpensifyCardsPage(route.params.policyID, workspaceAccountID);

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@NicMendonca Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021984269290519629850

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @truph01 (External)