[Due for payment 2025-11-13] [$250] LHN - Whisper to categorize expense, still visible on LHN after removing expense from report

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.40-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1559/folder/13176730/41237113/979830734
Email or phone of affected tester (no customers): ibellicotest+1977@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 / Android 12 / Chrome ( mWeb / Hybrid app) - Windows 11 / Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Account has at least one workspace.
Prerequisite 2: Account has a Self DM.

1. Open the Expensify app.
2. Open any workspace chat.
3. Create a manual expense but don´t add any category to it.
4. Open the report of the just created expense.
5. Note that a whisper to categorize expense appears.
6. Tap on the report field and select "Remove from report"
7. Navigate to "Inbox"
8. Note that the "How do you want to categorize this expense?" message is still visible on expense report preview.
9. Open report.
10. Note that whisper is not displayed inside the report.

Expected Result:

Whisper message to categorize expense, shouldn´t be visible on report preview on "Inbox", after the expense is removed from report.

Actual Result:

Whisper message to categorize expense, disappears from expense report when removing expense, but is still visible on report preview on "Inbox":

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021983959240608603081
• Upwork Job ID: 1983959240608603081
• Last Price Increase: 2025-10-30

Issue Owner

Current Issue Owner: @Gonals

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[hasib711]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Whisper message to categorize expense, shouldn´t be visible on report preview on "Inbox", after the expense is removed from report.

What is the root cause of that problem?

We get the ordered report list from the SidebarOrderedReportsContextProvider in the sidebar.

App/src/pages/iou/request/step/IOURequestStepReport.tsx

Lines 167 to 168 in c8298b2

	changeTransactionsReport([transaction.transactionID], isASAPSubmitBetaEnabled, session?.accountID ?? CONST.DEFAULT_NUMBER_ID, session?.email ?? '');
	removeTransaction(transaction.transactionID);

However, when we remove a report, we only update the ordered report list in the SearchContextProvider.

App/src/pages/home/sidebar/SidebarLinksData.tsx

Lines 26 to 27 in c8298b2

	const {orderedReports, currentReportID} = useSidebarOrderedReports(SidebarLinksData.displayName);

App/src/pages/iou/request/step/IOURequestStepReport.tsx

Line 49 in c8298b2

const {removeTransaction, setSelectedTransactions} = useSearchContext();

App/src/components/Search/SearchContext.tsx

Lines 159 to 189 in c8298b2

	const removeTransaction: SearchContextProps['removeTransaction'] = useCallback(
	(transactionID) => {
	if (!transactionID) {
	return;
	}
	const selectedTransactionIDs = searchContextData.selectedTransactionIDs;
	if (!isEmptyObject(searchContextData.selectedTransactions)) {
	const newSelectedTransactions = Object.entries(searchContextData.selectedTransactions).reduce((acc, [key, value]) => {
	if (key === transactionID) {
	return acc;
	}
	acc[key] = value;
	return acc;
	}, {} as SelectedTransactions);
	setSearchContextData((prevState) => ({
	...prevState,
	selectedTransactions: newSelectedTransactions,
	}));
	}
	if (selectedTransactionIDs.length > 0) {
	setSearchContextData((prevState) => ({
	...prevState,
	selectedTransactionIDs: selectedTransactionIDs.filter((ID) => transactionID !== ID),
	}));
	}
	},
	[searchContextData.selectedTransactionIDs, searchContextData.selectedTransactions],
	);

What changes do you think we should make in order to solve the problem?

We can fix this problem by updating the SidebarContextProvider data when a report is removed.

App/src/pages/iou/request/step/IOURequestStepReport.tsx

Lines 167 to 168 in c8298b2

	changeTransactionsReport([transaction.transactionID], isASAPSubmitBetaEnabled, session?.accountID ?? CONST.DEFAULT_NUMBER_ID, session?.email ?? '');
	removeTransaction(transaction.transactionID);

What alternative solutions did you explore? (Optional)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Whisper message to categorize still shown as last message after moving expense to self DM.

What is the root cause of that problem?

After we moved the self DM, the transaction thread last message is still the concierge message. This is a BE problem. Then, we get the last message from getLastMessageTextForReport which returns the last message based on the last action.

App/src/libs/SidebarUtils.ts

Line 778 in e1f7959

lastMessageTextFromReport = getLastMessageTextForReport({report, lastActorDetails, movedFromReport, movedToReport, policy, isReportArchived});

The last action is the moved expense message, but getLastMessageTextForReport doesn't handle it, so it returns the report lastMessageText, which is the concierge message.

What changes do you think we should make in order to solve the problem?

We need to move the moved expense message to self DM from here to getLastMessageTextForReport.

App/src/libs/SidebarUtils.ts

Lines 905 to 906 in e1f7959

	} else if (isActionOfType(lastAction, CONST.REPORT.ACTIONS.TYPE.UNREPORTED_TRANSACTION)) {
	result.alternateText = Parser.htmlToText(getUnreportedTransactionMessage());

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021983959240608603081

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[dukenv0307]

@bernhardoj's proposal looks good to me

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details.