[Due for payment 2025-12-04] [$250] Reports - Submit button is not shown if the expense report is not opened first

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.43-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exp https://test-management.browserstack.com/projects/2219752/test-runs/TR-1741/folder/13176730/41237110/991935376?sort=-identifier
Email or phone of affected tester (no customers): njsodisjodnsijdo@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat that has no unsettled expense.
3. Create an expense.
4. Do not open expense report.
5. Go to Reports > Expenses.
6. Click on the expense row.
   → Submit button is not shown on the report.
7. Go to Reports > Reports.
8. Open the same report.
9. Go back to Reports > Expenses.
10. Click on the expense row.
    → Submit button is only shown after opening the expense report.

Expected Result:

In Step 6, Submit button will be shown on the report when the expense report is not opened.

Actual Result:

In Step 6, Submit button is not shown on the report when the expense report is not opened.
In Step 10, Submit button is only shown after opening the expense report.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6993181_1762211644029.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021988740760666908987
• Upwork Job ID: 1988740760666908987
• Last Price Increase: 2025-11-12

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Submit button is not shown when open the report for the first time from Reports > Expense

What is the root cause of that problem?

When we open it the first time, we are navigated to the transaction thread which doesn't have the report-level actions (submit, approve, pay, etc.). We already have a logic to navigate to the expense report if it's a one-transaction report,

App/src/components/Search/index.tsx

Lines 676 to 679 in 28ede48

	const reportID =
	isTransactionItem && (!item.isFromOneTransactionReport || isFromSelfDM) && item.transactionThreadReportID !== CONST.REPORT.UNREPORTED_REPORT_ID
	? item.transactionThreadReportID
	: item.reportID;

But above the code, we have a logic to create the transaction thread if it doesn't have one yet, navigate to it, and early return.

App/src/components/Search/index.tsx

Lines 629 to 633 in 28ede48

	// If we're trying to open a transaction without a transaction thread, let's create the thread and navigate the user
	if (isTransactionItem && item.transactionThreadReportID === CONST.REPORT.UNREPORTED_REPORT_ID) {
	createAndOpenSearchTransactionThread(item, hash, backTo);
	return;
	}

It doesn't account the case when the transaction is a one-transaction report.

What changes do you think we should make in order to solve the problem?

Don't early return and navigate to the transaction thread if it's a one-transaction report.

if (isTransactionItem && item.transactionThreadReportID === CONST.REPORT.UNREPORTED_REPORT_ID) {
    createAndOpenSearchTransactionThread(item, hash, backTo, undefined, !item.isFromOneTransactionReport);
    if (!item.isFromOneTransactionReport) {
        return;
    }
}

[annaweber830]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 6, Submit button will be shown on the report when the expense report is not opened.

What is the root cause of that problem?

Because of this issue, when open report, update type of report to chat.

App/src/components/Search/index.tsx

Lines 630 to 633 in 5b9b2b8

	if (isTransactionItem && item.transactionThreadReportID === CONST.REPORT.UNREPORTED_REPORT_ID) {
	createAndOpenSearchTransactionThread(item, hash, backTo);
	return;
	}

App/src/libs/SearchUIUtils.ts

Lines 1309 to 1310 in 5b9b2b8

	const transactionThreadReport = createTransactionThreadReport(item.report, {reportActionID: item.moneyRequestReportActionID} as OnyxTypes.ReportAction);
	if (transactionThreadReport?.reportID) {

App/src/libs/actions/Report.ts

Lines 1406 to 1407 in 5b9b2b8

	const optimisticTransactionThread = buildTransactionThread(iouReportAction, reportToUse, undefined, optimisticTransactionThreadReportID);
	openReport(optimisticTransactionThreadReportID, undefined, currentUserEmail ? [currentUserEmail] : [], optimisticTransactionThread, iouReportAction?.reportActionID);

App/src/libs/ReportUtils.ts

Lines 8413 to 8422 in 5b9b2b8

	return buildOptimisticChatReport({
	participantList: participantAccountIDs,
	reportName: getTransactionReportName({reportAction}),
	policyID: moneyRequestReport?.policyID,
	ownerAccountID: CONST.POLICY.OWNER_ACCOUNT_ID_FAKE,
	notificationPreference: CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN,
	parentReportActionID: reportAction?.reportActionID,
	parentReportID: moneyRequestReport?.reportID,
	optimisticReportID: optimisticTransactionThreadReportID,
	});

So we get report that type is chat from server when open report

What changes do you think we should make in order to solve the problem?

We change report type to origin type when open report

if (moneyRequestReport?.type == CONST.REPORT.TYPE.EXPENSE) {

        return buildOptimisticExpenseReport(
            moneyRequestReport?.chatReportID, 
            moneyRequestReport?.policyID, 
            payeeAccountID, 
            moneyRequestReport?.total, 
            moneyRequestReport?.currency, 
            nonReimbursable,
            parentReportActionID,
            optimisticTransactionThreadReportID
        )
    } 

What alternative solutions did you explore? (Optional)

[melvin-bot]

📣 @annaweber830! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[annaweber830]

Contributor details
email: hasibuljoy81@gmail.com
Upwork profile link: https://www.upwork.com/freelancers/~01b7ae97c31592cd7b

[melvin-bot]

@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021988740760666908987