[RCA #72674] Report - Both expenses shown as held if approving a report with a held "0,00" amount expense

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.60-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #72674
Email or phone of affected tester (no customers): ibellicotest+2082@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 / Android 12 / Chrome ( mWeb / Hybrid app) - Windows 11 / Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Account has at least one workspace.
Prerequisite 2: Delayed submissions and approvals enabled.

1. Open the Expensify app.
2. Open any workspace chat.
3. Create two manual expenses with "0,00" as amount.
4. Open the report of the just created expenses.
5. Long tap and select one of the expenses.
6. Tap on the dropdown menu and hold the expense.
7. Tap on "Submit" and "Approve"
8. Note that a modal with a "These expenses are on hold" message appears, despite only one of the expenses being held.

Expected Result:

After tapping "Approve" on a report with only one expense held, a confirm modal should appear, giving the option to approve only the unheld amount or the total amount.

Actual Result:

When trying to partially approve a report with two expenses with "0,00" as amount and only one of them held, a confirm modal with a "These expenses are on hold" message appears, despite only one expense being on hold.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[mountiny]

#75433 should fix this