[Due for payment 2025-12-11] [$250] Multi tags - System message thread header shows different system message

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.60-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exp https://test-management.browserstack.com/projects/2219752/test-runs/TR-2009/folder/13176676/41237320/1022757471
Email or phone of affected tester (no customers): djosijnoijsoijsoi@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Workspace has dependent multi-level tags (use the attached file).

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create an expense without tag.
4. Open the expense thread.
5. Click State > select California.
6. Click Region > select North+test.
7. Click State > deselect California.
8. Right click on "set the State to "California"" system message > Reply in thread.
9. Go back to expense thread.
10. Right click on "set the Region to "North+test"" system message > Reply in thread.
11. Go back to expense thread.
12. Right click on "removed the State (previously "California") and the Region (previously "North+test")" system message > Reply in thread.

Expected Result:

In Step 8, 10 and 12, the thread header show match the system message.

Actual Result:

In Step 8, thread header shows "set the tag to "California"", when the system message is "set the State to "California"".

In Step 10, thread header shows "changed the expense", when the system message is "set the Region to "North+test"".

In Step 12, thread header shows "removed the tag (previously "California")", when the system message is "removed the State (previously "California") and the Region (previously "North+test")" .

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug7008141_1763547844703!Dependent_-_Multi_Level_tags_NEWW.csv

Bug7008141_1763547844707.26.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021993070524688637162
• Upwork Job ID: 1993070524688637162
• Last Price Increase: 2025-11-24
• Automatic offers:
• daledah | Contributor | 109621528

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

🚨 Edited by proposal-police: This proposal was edited at 2025-11-25 09:21:12 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 8, thread header shows "set the tag to "California"", when the system message is "set the State to "California"".

What is the root cause of that problem?

We don't pass the reports param here

App/src/pages/home/HeaderView.tsx

Lines 148 to 149 in 5717a04

	// Use sorted display names for the title for group chats on native small screen widths
	const title = getReportName(reportHeaderData, policy, parentReportAction, personalDetails, invoiceReceiverPolicy, undefined, undefined, isReportHeaderDataArchived);

=> policyID here will be undefined

App/src/libs/ReportUtils.ts

Lines 5877 to 5889 in 5717a04

	if (!isEmptyObject(parentReportAction) && isModifiedExpenseAction(parentReportAction)) {
	const policyID = reports?.find((r) => r.reportID === report?.reportID)?.policyID;
	const movedFromReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${getMovedReportID(parentReportAction, CONST.REPORT.MOVE_TYPE.FROM)}`];
	const movedToReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${getMovedReportID(parentReportAction, CONST.REPORT.MOVE_TYPE.TO)}`];
	const modifiedMessage = getForReportAction({
	reportAction: parentReportAction,
	policyID,
	movedFromReport,
	movedToReport,
	});
	return formatReportLastMessageText(modifiedMessage);
	}

=> we'll use DEFAULT_TAG_LIST fallback here => Tag is displayed

App/src/libs/ModifiedExpenseMessage.ts

Lines 310 to 311 in 5717a04

	const policyIDForTags = policyID === CONST.POLICY.OWNER_EMAIL_FAKE && policyForMovingExpensesID ? policyForMovingExpensesID : policyID;
	const policyTags = allPolicyTags?.[`${ONYXKEYS.COLLECTION.POLICY_TAGS}${policyIDForTags}`] ?? CONST.POLICY.DEFAULT_TAG_LIST;

What changes do you think we should make in order to solve the problem?

I searched every invocation of getReportName but there is no place to pass params reports

=> so the reports?.find logic inside getReportName is never hit in practice.

So we should remove this logic and use report?.policyID

    const policyID = report?.policyID

App/src/libs/ReportUtils.ts

Line 5878 in 5717a04

const policyID = reports?.find((r) => r.reportID === report?.reportID)?.policyID;

What alternative solutions did you explore? (Optional)

Or we can pass reports to getReportName function in HeaderView component

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 8, thread header shows "set the tag to "California"", when the system message is "set the State to "California"".

What is the root cause of that problem?

When a user replies to a MODIFIEDEXPENSE system message (like "set the State to 'California'"), the thread header was showing a simplified message (like "set the tag to 'California'") instead of the detailed message with the actual tag list name.

In getReportActionMessage function: This function is called to get the message text for a report action. For MODIFIEDEXPENSE actions, it was falling through to parseReportActionHtmlToText, which just parses the raw HTML message

App/src/libs/ReportUtils.ts

Line 5457 in fea749b

function getReportActionMessage({

App/src/libs/ReportUtils.ts

Line 5518 in fea749b

return parseReportActionHtmlToText(reportAction, reportID, childReportID);

In getReportName function: When generating thread names, there was a check for MODIFIEDEXPENSE actions that should call getForReportAction to generate the detailed message. However, this check was placed AFTER a check for archived reports, which could cause it to return early with the simplified message.

App/src/libs/ReportUtils.ts

Line 5588 in fea749b

function getReportName(

App/src/libs/ReportUtils.ts

Lines 5842 to 5844 in fea749b

	if (reportActionMessage && isArchivedNonExpense) {
	return generateArchivedReportName(reportActionMessage);
	}

What changes do you think we should make in order to solve the problem?

We need to handle the isModifiedExpenseAction case as well in getReportActionMessage

    if (isModifiedExpenseAction(reportAction)) {
        const policyID = reports?.find((r) => r.reportID === reportID)?.policyID;
        const movedFromReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${getMovedReportID(reportAction, CONST.REPORT.MOVE_TYPE.FROM)}`];
        const movedToReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${getMovedReportID(reportAction, CONST.REPORT.MOVE_TYPE.TO)}`];
        return getForReportAction({
            reportAction,
            policyID,
            movedFromReport,
            movedToReport,
        });
    }

App/src/libs/ReportUtils.ts

Line 5517 in fea749b

We should remove this

App/src/libs/ReportUtils.ts

Lines 5842 to 5844 in fea749b

	if (reportActionMessage && isArchivedNonExpense) {
	return generateArchivedReportName(reportActionMessage);
	}

Then place it here

            const formattedMessage = formatReportLastMessageText(modifiedMessage);
            if (isArchivedNonExpense) {
                return generateArchivedReportName(formattedMessage);
            }
            return formattedMessage;
        }
        if (reportActionMessage && isArchivedNonExpense) {
            return generateArchivedReportName(reportActionMessage);
        }

App/src/libs/ReportUtils.ts

Lines 5856 to 5857 in fea749b

	return formatReportLastMessageText(modifiedMessage);
	}

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[RachCHopkins]

Reproed!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021993070524688637162

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)