[Due for payment 2025-12-04] [$250] Rules - Cash expense default field does not update after changing settings

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.61-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): djosijnoijsoijsoi@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > More features
3. Enable Rules
4. Upgrade the workspace
5. Go to Rules
6. Click Cash expense default
7. Select any other option

Expected Result:

Cash expense default field will update after changing the settings

Actual Result:

Cash expense default field does not update after changing the settings

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug7008494_1763570448999.2.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021991670420536198742
• Upwork Job ID: 1991670420536198742
• Last Price Increase: 2025-11-21
• Automatic offers:
• aimane-chnaif | Reviewer | 109583025

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Eskalifer1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Rules - Cash expense default field does not update after changing settings

What is the root cause of that problem?

Here is the part where we get current state for this field:

App/src/pages/workspace/rules/IndividualExpenseRulesSection.tsx

Lines 100 to 101 in f2115ab

	const reimbursableMode = getCashExpenseReimbursableMode(policyID) ?? CONST.POLICY.CASH_EXPENSE_REIMBURSEMENT_CHOICES.REIMBURSABLE_DEFAULT;
	const reimbursableModeText = translate(`workspace.rules.individualExpenseRules.${reimbursableMode}`);

But field reimbursableMode is not changed whether this field changes in policy, since it doesnt have any useMemo around and will be changed only when policyID changes

What changes do you think we should make in order to solve the problem?

We can rewrite function getCashExpenseReimbursableMode to accept policy (not policyID)

What alternative solutions did you explore? (Optional)

1. We can wrap this to useMemo and to deps pass all fields from polcy related to this feature:

    const reimbursableMode = useMemo(() => {
        return getCashExpenseReimbursableMode(policyID) ?? CONST.POLICY.CASH_EXPENSE_REIMBURSEMENT_CHOICES.REIMBURSABLE_DEFAULT;
    }, [policy?.defaultReimbursable, policy?.disabledFields?.reimbursable]);

2. We can rewrite function getCashExpenseReimbursableMode to accept only related data to this feature(policy?.defaultReimbursable, policy?.disabledFields?.reimbursable) - But in this case we will need to handle undefined or null policy outside the function
   Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021991670420536198742

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Cash expense default field does not update after changing the settings

What is the root cause of that problem?

getCashExpenseReimbursableMode is calculated based on policyID; the react-complier automatically memorizes this with a dependency on policyID. So it's not updated when the policy data is changed.

App/src/pages/workspace/rules/IndividualExpenseRulesSection.tsx

Lines 100 to 101 in f2115ab

	const reimbursableMode = getCashExpenseReimbursableMode(policyID) ?? CONST.POLICY.CASH_EXPENSE_REIMBURSEMENT_CHOICES.REIMBURSABLE_DEFAULT;
	const reimbursableModeText = translate(`workspace.rules.individualExpenseRules.${reimbursableMode}`);

What changes do you think we should make in order to solve the problem?

We need to update getCashExpenseReimbursableMode to pass policy data instead of policyID. And update all related places to get the policy data in Onyx via useOnyx to pass to this function.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.