Android-'Not here page' appears briefly when delete workspace in Overview

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.63-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #74438
Email or phone of affected tester (no customers): ndk.2303+134@gmail.com
Issue reported by: Applause Internal Team
Device used: Pixel 7a/ Android 16
App Component: Workspace Settings

Action Performed:

1. Open Hybrid app
2. Create a Workspace
3. Navigate to Workpsace setting
4. Tap on Overview
5. Tap on More
6. Tap on Delete
7. Confirm delete workspace

Expected Result:

Workspace is deleted without 'not here page'

Actual Result:

'Not here page' appears briefly when delete workspace in the Overview page.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug7012723_1764046163417.Not_Here_Page_Shown_Briefly.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

'Not here page' appears briefly when delete workspace in the Overview page.

What is the root cause of that problem?

When a workspace is deleted, the deleteWorkspace action immediately sets pendingAction: DELETE on the policy (optimistic update) but user remains on the WorkspaceOverviewPage. Then WorkspacePageWithSections component checks if the policy should be shown. So that when it detects isPendingDelete is true and prevIsPendingDelete is false, it briefly shows the NotFound page

What changes do you think we should make in order to solve the problem?

We ensure that navigation happens immediately when the delete is confirmed, before the optimistic update causes the NotFound page to show. This matches the pattern used for handleLeaveWorkspace

@@ -233,10 +233,8 @@ function WorkspaceOverviewPage({policyDraft, policy: policyProp, route}: Workspa
             reimbursementAccountError,
             lastUsedPaymentMethods: lastPaymentMethod,
         });
-        if (isOffline) {
-            setIsDeleteModalOpen(false);
-            goBackFromInvalidPolicy();
-        }
+        setIsDeleteModalOpen(false);
+        goBackFromInvalidPolicy();
     }, [
         policy?.id,
         policyName,
@@ -246,7 +244,6 @@ function WorkspaceOverviewPage({policyDraft, policy: policyProp, route}: Workspa
         transactionViolations,
         reimbursementAccountError,
         lastPaymentMethod,
-        isOffline,
         activePolicyID,
     ]);
 
@@ -273,14 +270,10 @@ function WorkspaceOverviewPage({policyDraft, policy: policyProp, route}: Workspa
     }, [isLoadingBill]);
 
     useEffect(() => {
-        if (!isFocused || !prevIsPendingDelete || isPendingDelete) {
+        if (!isFocused || !prevIsPendingDelete || isPendingDelete || !policyLastErrorMessage) {
             return;
         }
         setIsDeleteModalOpen(false);
-        if (!policyLastErrorMessage) {
-            goBackFromInvalidPolicy();
-            return;
-        }
         setIsDeleteWorkspaceErrorModalOpen(true);
     }, [isFocused, isPendingDelete, prevIsPendingDelete, policyLastErrorMessage]);

App/src/pages/workspace/WorkspaceOverviewPage.tsx

Line 69 in a496d83

function WorkspaceOverviewPage({policyDraft, policy: policyProp, route}: WorkspaceOverviewPageProps) {

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

'Not here page' appears briefly when delete workspace in the Overview page.

What is the root cause of that problem?

when the user confirmed deletion, the page immediately lost its policy data before navigation happened, so WorkspaceOverviewPage re-rendered with policy === undefined. Because shouldShowNotFoundPage only checked that condition, it briefly rendered the fallback “Not here” state while we were still on the page

App/src/pages/workspace/WorkspaceOverviewPage.tsx

Line 482 in 61ea62e

shouldShowNotFoundPage={policy === undefined}

What changes do you think we should make in order to solve the problem?

Added a local isSelfDeletingWorkspace flag. It turns true immediately when the user confirms delete, so we keep shouldShowNotFoundPage false even if policy briefly disappears. Once isPendingDelete clears, the flag resets. This prevents the overview page from flashing the “Not here” screen during the short gap before navigation.

    const [isSelfDeletingWorkspace, setIsSelfDeletingWorkspace] = useState(false);
    
    const confirmDelete = useCallback(() => {
    if (!policy?.id || !policyName) {
        return;
    }

    setIsSelfDeletingWorkspace(true);
     ...
    }

    useEffect(() => {
        if(isPendingDelete) {
            return;
        }
        setIsSelfDeletingWorkspace(false);
    }, [isPendingDelete]);

    shouldShowNotFoundPage={policy === undefined && !isSelfDeletingWorkspace}

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[samranahm]

Dupe of #73137 and being fixed here #75085

cc: @heyjennahay

[melvin-bot]

@heyjennahay Whoops! This issue is 2 days overdue. Let's get this updated quick!

[samranahm]

@mitarachim please retest, this one should no longer be reproduced.

[melvin-bot]

@heyjennahay Eep! 4 days overdue now. Issues have feelings too...

[heyjennahay]

Waiting on @mitarachim to retest

[mitarachim]

Hello @samranahm and @heyjennahay , sorry for late reply.
QA team unable to reproduce issue using latest build v9.2.67-0

az_recorder_20251202_151527.mp4

[samranahm]

@heyjennahay we are good to close this one as dupe of #73137