[Due for payment 2026-01-07] [$250] Company cards - CC page shows empty state when one of the feeds deleted on second device

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.66-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: MacBook Air 15.6.1 Chrome, iPhone 15 iOS 26.1
App Component: Other

Action Performed:

Preconditions: log in with expensifail account on Web Chrome and iOS
iOS steps 1-4:

1. Create a workspace, invite a member to the workspace
2. Open Company cards page, tap Add cards - US -Direct feed - Other - Regions bank - select all 3 options
3. Assign 3333 card to yourself
4. Add Wells Fargo direct feed the same way, as in step 2, select 3333 or 9999 card
5. On Web: open Company cards page, open Regions feed, then Wells Fargo feed
6. On iOS: remove Wells Fargo feed
7. On Web: observe the company cards page

Expected Result:

Regions bank cards feed is displayed on the Company cards page

Actual Result:

Company cards page turns to an empty state on the second device, when one of the two feeds was removed on the first device. The same issue occurs on iOS, when the feed was removed on Web.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021995492679196002980
• Upwork Job ID: 1995492679196002980
• Last Price Increase: 2025-12-15

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mohammadjafarinejad]

🚨 Edited by proposal-police: This proposal was edited at 2025-12-01 15:43:55 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Company cards page turns to an empty state on the second device when one of the two feeds is removed on the first device.

What is the root cause of that problem?

The getSelectedFeed function in CardUtils.ts doesn't validate if the lastSelectedFeed is still available. When a feed is deleted on one device, it syncs to other devices with pendingAction: DELETE, but the function still returns this deleted feed as the selected one, causing the empty state.

What changes do you think we should make in order to solve the problem?

SolutionA

Update WorkspaceCompanyCardsPage and other places to pass true for shouldFilterOutRemovedFeeds:

const companyCards = getCompanyFeeds(cardFeeds, true);

App/src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx

Line 75 in a60674a

const companyCards = getCompanyFeeds(cardFeeds);

SolutionB

Update getSelectedFeed in CardUtils.ts to check if the lastSelectedFeed exists in the available feeds before returning it. If the feed was deleted, fall back to the default feed by validating against the available feeds list (which already filters out deleted feeds).

function getSelectedFeed(lastSelectedFeed: OnyxEntry<CompanyCardFeedWithDomainID>, cardFeeds: OnyxEntry<CombinedCardFeeds>): CompanyCardFeedWithDomainID | undefined {
    const defaultFeed = Object.keys(getCompanyFeeds(cardFeeds, true)).at(0) as CompanyCardFeedWithDomainID | undefined;
    if (!lastSelectedFeed?.includes(CONST.COMPANY_CARD.FEED_KEY_SEPARATOR)) {
        return defaultFeed;
    }
    
    // Check if the last selected feed still exists and is not marked for deletion
    const availableFeeds = getCompanyFeeds(cardFeeds, true);
    if (availableFeeds[lastSelectedFeed]) {
        return lastSelectedFeed;
    }
    
    // If the last selected feed was deleted, fall back to the default feed
    return defaultFeed;
}

What alternative solutions did you explore? (Optional)

None

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021995492679196002980

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[melvin-bot]

@Ollyws Whoops! This issue is 2 days overdue. Let's get this updated quick!