[HOLD for payment 2022-03-17] Change the message that shows when trying to name a room using a name that already exists

[MitchExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click "+"
2. Click "New room"
3. Type a name into the "Room name" field that is already used as a room name

Expected Result:

See a message in red below the "Room name" field that reads "A room on this workspace already uses this name"

Actual Result:

See a message in red below the "Room name" field that reads "This name is reserved and cannot be used"

Workaround:

User can ignore

Platform:

All

Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Issue reported by: Mitch
Slack conversation: Internal Slack Thread

View all open jobs on GitHub

this job on upwork

[MelvinBot]

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[mateusbra]

PROPOSAL

We have to change within en.js/es.js the message to "A room on this workspace already uses this name"

App/src/languages/en.js

Line 899 in 0b58649

roomNameReservedError: 'This name is reserved and cannot be used',

to:

roomNameReservedError: 'A room on this workspace already uses this name',

Screenshot

[sobitneupane]

Reason:
'#admins' and '#announce' is considered as reserved_room_names RESERVED_ROOM_NAMES: ['#admins', '#announce'],

Proposal:
Removing following lines of code will solve the issue:

App/src/components/RoomNameInput.js

Lines 120 to 123 in bdf3a74

	// Certain names are reserved for default rooms and should not be used for policy rooms.
	if (_.contains(CONST.REPORT.RESERVED_ROOM_NAMES, finalRoomName)) {
	error = this.props.translate('newRoomPage.roomNameReservedError');
	}

Now en.js has 'A room with this name already exists' as roomAlreadyExistsError, if 'A room on this workspace already uses this name' makes more sense, we can use it.

[jboniface]

posted the job here https://www.upwork.com/jobs/~0197ef681e5c16d99a

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[MelvinBot]

Triggered auto assignment to @pecanoro (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.