[Due for payment 2026-04-14] [$500] iOS - The concierge task is not auto-completed after completing Test drive via Reports tab

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.71-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://github.com/Expensify/Expensify/issues/536068
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Apple iPhone 13 - iOS 18.6.2
App Component: Other

Action Performed:

Prerequisite: Invite a brand new account to a workspace

1. Open the app
2. Sign-in with the invited user
3. Go to the Reports tab > Expenses.
4. Tap the "Take a test drive" button
5. Finish Test Drive
6. Tap Get Started
7. Navigate to the Concierge chat

Expected Result:

The Test Drive task in the Concierge chat should be completed

Actual Result:

The concierge task is not auto-complete after the invited employee completes the Test drive via Reports tab

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug7010420_1763753118240.ScreenRecording_11-21-2025_14-19-29_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021996584871222053906
• Upwork Job ID: 1996584871222053906
• Last Price Increase: 2026-03-24
• Automatic offers:
• aimane-chnaif | Contributor | 110795596
• apeyada | Contributor | 110940190

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021996584871222053906

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[LorenzoBloedow]

🚨 Edited by proposal-police: This proposal was edited at 2025-12-18 13:31:55 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The concierge task is not completed after completing test drive via Reports tab.

What is the root cause of that problem?

The Onyx optimistic onboarding data is coupled with the openReport function.
This means, if openReport never executes, or it executes before it's supposed to (before OpenApp), the optimistic onboarding data, and therefore, its tasks (which are fully optimistic), are never created.

Currently, there are two scenarios where this happens:
Scenario 1 (this issue):

1. Invite a brand new account (A) through the workspace.
2. Log into Account A manually and open the app in a narrow screen (no report is opened).
3. Go straight to Reports > Expenses > "Take a test drive".
4. Finish the task and go to Concierge.
5. Notice the task in Concierge is not crossed off.

Scenario 2:

1. Invite a brand new account through the workspace.
2. Click on the "Get started" link in the invite email (either narrow or wide screen is fine).
3. Go to Reports > Expenses > "Take a test drive".
4. Finish the task and go to Concierge.
5. Notice the task in Concierge is not crossed off.

Scenario 1 happens because openReport is never executed.
Scenario 2 happens because OpenReport executes before OpenApp which makes the introSelected variable undefined, which means the onboarding Onyx data is also never created.

All of this means this doesn't ever get executed, which is why we have to decouple it from openReport:

App/src/libs/actions/Report.ts

Lines 1190 to 1194 in 4625fac

	const onboardingData = prepareOnboardingOnyxData({
	introSelected,
	engagementChoice: choice,
	onboardingMessage,
	});

What changes do you think we should make in order to solve the problem?

Since this is a very specific edge case, I think it's a good complexity<->correctness tradeoff to simply open the Concierge report if we do end up in this situation.

1. Remove these lines from openReport:
   

   App/src/libs/actions/Report.ts

   Lines 1160 to 1204 in 549b140

   	const isInviteOnboardingComplete = introSelected?.isInviteOnboardingComplete ?? false;
   	const isOnboardingCompleted = onboarding?.hasCompletedGuidedSetupFlow ?? false;
   	// Some cases we can have two open report requests with guide setup data because isInviteOnboardingComplete is not updated completely.
   	// Then we need to check the list request and prevent the guided setup data from being duplicated.
   	const allPersistedRequests = getAll();
   	const hasOpenReportWithGuidedSetupData = allPersistedRequests.some((request) => request.command === WRITE_COMMANDS.OPEN_REPORT && request.data?.guidedSetupData);
   	// Prepare guided setup data only when nvp_introSelected is set and onboarding is not completed
   	// OldDot users will never have nvp_introSelected set, so they will not see guided setup messages
   	if (introSelected && !isOnboardingCompleted && !isInviteOnboardingComplete && !hasOpenReportWithGuidedSetupData) {
   	const {choice, inviteType} = introSelected;
   	const isInviteIOUorInvoice = inviteType === CONST.ONBOARDING_INVITE_TYPES.IOU || inviteType === CONST.ONBOARDING_INVITE_TYPES.INVOICE;
   	const isInviteChoiceCorrect = choice === CONST.ONBOARDING_CHOICES.ADMIN || choice === CONST.ONBOARDING_CHOICES.SUBMIT || choice === CONST.ONBOARDING_CHOICES.CHAT_SPLIT;
   	if (isInviteChoiceCorrect && !isInviteIOUorInvoice) {
   	const onboardingMessage = getOnboardingMessages().onboardingMessages[choice];
   	if (choice === CONST.ONBOARDING_CHOICES.CHAT_SPLIT) {
   	const updatedTasks = onboardingMessage.tasks.map((task) => (task.type === 'startChat' ? {...task, autoCompleted: true} : task));
   	onboardingMessage.tasks = updatedTasks;
   	}
   	const onboardingData = prepareOnboardingOnyxData({
   	introSelected,
   	engagementChoice: choice,
   	onboardingMessage,
   	});
   	if (onboardingData) {
   	optimisticData.push(...onboardingData.optimisticData, {
   	onyxMethod: Onyx.METHOD.MERGE,
   	key: ONYXKEYS.NVP_INTRO_SELECTED,
   	value: {
   	isInviteOnboardingComplete: true,
   	},
   	});
   	successData.push(...onboardingData.successData);
   	failureData.push(...onboardingData.failureData);
   	parameters.guidedSetupData = JSON.stringify(onboardingData.guidedSetupData);
   	}
   	}
   	}

2. Create and export this function in src/libs/actions/Report.ts:

function openOnboardingDataOnce(conciergeReportID: string, introSelected: IntroSelected) {
    const optimisticData: OnyxUpdate[] = [];
    const successData: OnyxUpdate[] = [];
    const failureData: OnyxUpdate[] = [];
    const finallyData: OnyxUpdate[] = [];
    const parameters: OpenReportParams = {
        reportID: conciergeReportID
    };

    const isInviteOnboardingComplete = introSelected?.isInviteOnboardingComplete ?? false;
    const isOnboardingCompleted = onboarding?.hasCompletedGuidedSetupFlow ?? false;

    // Some cases we can have two open report requests with guide setup data because isInviteOnboardingComplete is not updated completely.
    // Then we need to check the list request and prevent the guided setup data from being duplicated.
    const allPersistedRequests = getAll();
    const hasOpenReportWithGuidedSetupData = allPersistedRequests.some((request) => request.command === WRITE_COMMANDS.OPEN_REPORT && request.data?.guidedSetupData);

    // Prepare guided setup data only when nvp_introSelected is set and onboarding is not completed
    // OldDot users will never have nvp_introSelected set, so they will not see guided setup messages
    if (!isOnboardingCompleted && !isInviteOnboardingComplete && !hasOpenReportWithGuidedSetupData) {
        const {choice, inviteType} = introSelected;
        const isInviteIOUorInvoice = inviteType === CONST.ONBOARDING_INVITE_TYPES.IOU || inviteType === CONST.ONBOARDING_INVITE_TYPES.INVOICE;
        const isInviteChoiceCorrect = choice === CONST.ONBOARDING_CHOICES.ADMIN || choice === CONST.ONBOARDING_CHOICES.SUBMIT || choice === CONST.ONBOARDING_CHOICES.CHAT_SPLIT;

        if (isInviteChoiceCorrect && !isInviteIOUorInvoice) {
            const onboardingMessage = getOnboardingMessages().onboardingMessages[choice];
            if (choice === CONST.ONBOARDING_CHOICES.CHAT_SPLIT) {
                const updatedTasks = onboardingMessage.tasks.map((task) => (task.type === 'startChat' ? {...task, autoCompleted: true} : task));
                onboardingMessage.tasks = updatedTasks;
            }

            const onboardingData = prepareOnboardingOnyxData({
                introSelected,
                engagementChoice: choice,
                onboardingMessage,
            });

            if (onboardingData) {
                optimisticData.push(...onboardingData.optimisticData, {
                    onyxMethod: Onyx.METHOD.MERGE,
                    key: ONYXKEYS.NVP_INTRO_SELECTED,
                    value: {
                        isInviteOnboardingComplete: true,
                    },
                });

                successData.push(...onboardingData.successData);

                failureData.push(...onboardingData.failureData);

                parameters.guidedSetupData = JSON.stringify(onboardingData.guidedSetupData);
            }
        }
    }

    API.write(WRITE_COMMANDS.OPEN_REPORT, parameters, {optimisticData, successData, failureData, finallyData});
}

3. In src/libs/Navigation/AppNavigator/AuthScreens listen for the Concierge report ID:

    const [conciergeReportID] = useOnyx(ONYXKEYS.CONCIERGE_REPORT_ID, {canBeMissing: true});

4. And then add this useEffect:

    useEffect(() => {
        if (!conciergeReportID || !introSelected) {
            return;
        }
        Report.openOnboardingDataOnce(conciergeReportID, introSelected);
    }, [conciergeReportID, introSelected]);

What alternative solutions did you explore? (Optional)

We can also work with the BE to create a new API such as OPEN_ONBOARDING_DATA, however tasks are still supposed to be fully optimistic so I'm not sure this is the best idea.

Result:

Scenario 1:

fix-1.mov

Scenario 2:

fix-2.mov

[shubham1206agra]

@trjExpensify This is a BE issue as complete data is not sent via OpenApp.