[$250] Expense - The details of an expense don't work after going back when writing a merchant

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.73-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2306/folder/13177075/41703290/1060194310
Email or phone of affected tester (no customers): joelarmandotester+610@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Open the Hybrid App
2. Create a new account
3. Start a chat 1:1 with other user
4. Create a new expense with amount only
5. Open the expense details and tap on the "Merchant" field
6. Type any merchant and swipe right to go back
7. Tap on other field

Expected Result:

The other areas of expense should function correctly

Actual Result:

After swiping right to go back, the expense fields don't work

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

+++ Add any screenshot/video evidence

+++

Bug7021973_1764965279061.Merchant_Issue.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021998344786748559397
• Upwork Job ID: 1998344786748559397
• Last Price Increase: 2025-12-09

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The details of an expense don't work after going back when writing a merchant

What is the root cause of that problem?

On ios native, when a user tries to go back from a MoneyRequest screen with unsaved changes the native back gesture/button removes the screen from the native stack. The JavaScript code tries to prevent navigation using beforeRemove (which calls e.preventDefault()). beforeRemove doesn’t fully prevent native navigation, so the screen is removed natively but stays in JavaScript state. This mismatch causes the error: The screen 'MoneyRequest' was removed natively but didn't get removed from JS state. Consider using a 'usePreventRemove' hook with 'headerBackButtonMenuEnabled: false' to prevent users from natively going back multiple screens.

App/src/pages/iou/request/step/DiscardChangesConfirmation/index.native.tsx

Lines 14 to 27 in d34df44

	useBeforeRemove(
	useCallback(
	(e) => {
	if (!getHasUnsavedChanges()) {
	return;
	}
	e.preventDefault();
	blockedNavigationAction.current = e.data.action;
	setIsVisible(true);
	},
	[getHasUnsavedChanges],
	),
	);

What changes do you think we should make in order to solve the problem?

As the other itself suggest we should use usePreventRemove hook. We can use usePreventRemove here instead of useBeforeRemove

App/src/pages/iou/request/step/DiscardChangesConfirmation/index.native.tsx

Lines 14 to 27 in d34df44

	useBeforeRemove(
	useCallback(
	(e) => {
	if (!getHasUnsavedChanges()) {
	return;
	}
	e.preventDefault();
	blockedNavigationAction.current = e.data.action;
	setIsVisible(true);
	},
	[getHasUnsavedChanges],
	),
	);

We can do something like

    usePreventRemove(shouldPreventRemove, useCallback(() => {
        setIsVisible(true);
    }, []));

and in here we can do

   onConfirm={() => {
                setIsVisible(false);
                navigationRef.current?.goBack();
            }}

Results

Screen.Recording.2025-12-07.at.4.30.46.AM.mov

Optional(not critical or important)
We can add headerBackButtonMenuEnabled: false, as the error suggests to the description and merchant screen. We can do something like this

[SCREENS.MONEY_REQUEST.STEP_MERCHANT]: {
        native: {
            headerBackButtonMenuEnabled: false,
        },
    },
    [SCREENS.MONEY_REQUEST.STEP_DESCRIPTION]: {
        native: {
            headerBackButtonMenuEnabled: false,
        },
    },

What alternative solutions did you explore? (Optional)

[JmillsExpensify]

Odd. I'll open up for proposals

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021998344786748559397

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

[ZhenjaHorbach]

This proposal makes sense to me!

🎀👀🎀 С+