Workspace - Travel is not enabled on duplicated workspace

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.85-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #71630
Email or phone of affected tester (no customers): isjdsoijsojnsiojisndj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Mac 26.1 / Chrome
App Component: Workspace Settings

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > More features.
3. Enable Travel.
4. Go back to main Workspaces page.
5. Click 3-dot menu on the workspace > Duplicate workspace.
6. Click Next > Continue.
7. Go to duplicated workspace settings > More features.

Expected Result:

Travel will be enabled.

Actual Result:

Travel is not enabled on duplicated workspace.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7034235_1766215366014.travel.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @brianlee-expensify

[melvin-bot]

Triggered auto assignment to @brianlee-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Eskalifer1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Travel is not enabled on duplicated workspace

What is the root cause of that problem?

We are fulfilling the request for a duplicate here:

App/src/pages/workspace/duplicate/WorkspaceDuplicateSelectFeaturesForm.tsx

Lines 209 to 228 in 251ab97

	duplicateWorkspaceAction(policy, {
	policyName: duplicateWorkspace.name,
	policyID: policy.id,
	targetPolicyID: duplicateWorkspace.policyID,
	welcomeNote: `${translate('workspace.duplicateWorkspace.welcomeNote')} ${duplicateWorkspace.name}`,
	policyCategories: selectedItems.includes('categories') ? policyCategories : undefined,
	parts: {
	people: selectedItems.includes('members'),
	reports: selectedItems.includes('reports'),
	connections: selectedItems.includes('accounting'),
	categories: selectedItems.includes('categories'),
	tags: selectedItems.includes('tags'),
	taxes: selectedItems.includes('taxes'),
	perDiem: selectedItems.includes('perDiem'),
	reimbursements: selectedItems.includes('invoices'),
	expenses: selectedItems.includes('rules'),
	customUnits: selectedItems.includes('distanceRates'),
	invoices: selectedItems.includes('invoices'),
	exportLayouts: selectedItems.includes('workflows'),
	},

But we don't include any information about travel, so nothing is displayed.

What changes do you think we should make in order to solve the problem?

We need to add one element from Travel to items (what exactly should be displayed can be discussed) in the case when isTravelEnabled === true:

App/src/pages/workspace/duplicate/WorkspaceDuplicateSelectFeaturesForm.tsx

Line 75 in 251ab97

const items = useMemo(() => {

Then pass this value as parts (here we need to clarify with the backend what value we should pass, since it seems that simply travel is not suitable or the backend simply does not have these changes yet):

App/src/pages/workspace/duplicate/WorkspaceDuplicateSelectFeaturesForm.tsx

Lines 215 to 228 in 251ab97

	parts: {
	people: selectedItems.includes('members'),
	reports: selectedItems.includes('reports'),
	connections: selectedItems.includes('accounting'),
	categories: selectedItems.includes('categories'),
	tags: selectedItems.includes('tags'),
	taxes: selectedItems.includes('taxes'),
	perDiem: selectedItems.includes('perDiem'),
	reimbursements: selectedItems.includes('invoices'),
	expenses: selectedItems.includes('rules'),
	customUnits: selectedItems.includes('distanceRates'),
	invoices: selectedItems.includes('invoices'),
	exportLayouts: selectedItems.includes('workflows'),
	},

travel: selectedItems.includes(‘travel’),

Then perform these operations in duplicateWorkspaceAction:

App/src/libs/actions/Policy/Policy.ts

Lines 2717 to 2727 in 251ab97

	const isMemberOptionSelected = parts?.people;
	const isReportsOptionSelected = parts?.reports;
	const isConnectionsOptionSelected = parts?.connections;
	const isCategoriesOptionSelected = parts?.categories;
	const isTaxesOptionSelected = parts?.taxes;
	const isTagsOptionSelected = parts?.tags;
	const isInvoicesOptionSelected = parts?.invoices;
	const isCustomUnitsOptionSelected = parts?.customUnits;
	const isRulesOptionSelected = parts?.expenses;
	const isWorkflowsOptionSelected = parts?.exportLayouts;
	const isPerDiemOptionSelected = parts?.perDiem;

const isTraveOptionSelected = parts?.travel;

App/src/libs/actions/Policy/Policy.ts

Line 2756 in 251ab97

arePerDiemRatesEnabled: isPerDiemOptionSelected,

isTravelEnabled: isTraveOptionSelected,

Additionally, we can consider adding values for pendingFields if necessary.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.