Expensify Card - RHP closes instead of returning to profile after assigning card from profile

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.85-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2453/folder/13176890/41237384/1086407608
Email or phone of affected tester (no customers): applausetester+khcategory20@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Mac 26.1 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Workspace is set up with Expensify card feature.
• User has assigned themselves a virtual card.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Members.
3. Click on your profile.
4. Click + New card.
5. Select virtual card and complete the steps.
6. On magic code page, enter magic code.

Expected Result:

After entering magic code, RHP will return to profile page.

Actual Result:

After entering magic code, RHP closes instead of returning to profile page.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify Card - RHP closes instead of returning to profile after assigning card from profile

What is the root cause of that problem?

In IssueNewCardConfirmMagicCodePage, currently we're using Navigation.goBack(backTo) when a backTo parameter is provided. The goBack method attempts to go back in the navigation stack, but since the member details page and the magic code confirmation page are in different navigation contexts, calling goBack is causing the entire RHP to close.

App/src/pages/workspace/expensifyCard/issueNew/IssueNewCardConfirmMagicCodePage.tsx

Lines 36 to 42 in df5234b

	useEffect(() => {
	if (!isSuccessful) {
	return;
	}
	if (backTo && shouldUseBackToParam) {
	Navigation.goBack(backTo);
	} else {

What changes do you think we should make in order to solve the problem?

We should change goBack to navigate

Navigation.navigate(backTo);

here

App/src/pages/workspace/expensifyCard/issueNew/IssueNewCardConfirmMagicCodePage.tsx

Lines 36 to 42 in df5234b

	useEffect(() => {
	if (!isSuccessful) {
	return;
	}
	if (backTo && shouldUseBackToParam) {
	Navigation.goBack(backTo);
	} else {

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@RachCHopkins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[RachCHopkins]

This seems weird, the expected behaviour seems incorrect. @jponikarchuk I can't access the test in browserstack - are you able to add something that shows me that we'd expect this?

[jponikarchuk]

@RachCHopkins The option to assign cards to members via the Members list is removed now #77798