User is navigate to main screen instead of previous step after deleting workspace - reported by @ahmdshrif

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to any chat
2. Open Settings> select workspace
3. Delete workspace

Expected Result:

User should navigate to Settings screen after deleting workspace

Actual Result:

User navigated to chat LHN

Workaround:

unknown

Platform:

Where is this issue occurring?

• iOS
• Android
• Mobile Web

Version Number: 1.1.39-1
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20220208-142335_New.Expensify.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ahmdshrif
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1644323126149709

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @sophiepintoraetz (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[sobitneupane]

PROPOSAL
To solve this issue, we should make some changes in /src/libs/actions/Policy.js

App/src/libs/actions/Policy.js

Lines 169 to 190 in d9355db

	function deletePolicy(policyID) {
	return API.Policy_Delete({policyID})
	.then((response) => {
	if (response.jsonCode !== 200) {
	// Show the user feedback
	const errorMessage = Localize.translateLocal('workspace.common.growlMessageOnDeleteError');
	Growl.error(errorMessage, 5000);
	return;
	}
	Growl.show(Localize.translateLocal('workspace.common.growlMessageOnDelete'), CONST.GROWL.SUCCESS, 3000);
	// Removing the workspace data from Onyx as well
	return Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, null);
	})
	.then(() => Report.fetchAllReports(false, true))
	.then(() => {
	Navigation.dismissModal();
	Navigation.navigate(ROUTES.HOME);
	return Promise.resolve();
	});
	}

Here I am proposing to navigate back to Settings Screen as it is mentioned to be the Expected Output.

function deletePolicy(policyID) {
    return API.Policy_Delete({policyID})
        .then((response) => {
            if (response.jsonCode !== 200) {
                // Show the user feedback
                const errorMessage = Localize.translateLocal('workspace.common.growlMessageOnDeleteError');
                Growl.error(errorMessage, 5000);
                return;
            }

            Growl.show(Localize.translateLocal('workspace.common.growlMessageOnDelete'), CONST.GROWL.SUCCESS, 3000);

            // Removing the workspace data from Onyx as well
            return Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, null);
        })
        .then(() => Report.fetchAllReports(false, true))
        .then(() => {
+           Navigation.navigate(ROUTES.SETTINGS)
-           Navigation.dismissModal();
-           Navigation.navigate(ROUTES.HOME);
            return Promise.resolve();
        });
}

[ahmdshrif]

proposal

we need to change

App/src/libs/actions/Policy.js

Lines 186 to 187 in d9355db

	Navigation.dismissModal();
	Navigation.navigate(ROUTES.HOME);

with

Navigation.goBack()

make it go back better than go to setting since maybe we able to open the workspace from another page in the future.
and on this case, we will expect to go to the previous page, not the setting screen.

[MelvinBot]

Triggered auto assignment to @nickmurray47 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[nickmurray47]

@ahmdshrif @sobitneupane appreciate the proposals but letting both of you know that this particular issue didn't follow our standard practice. We only accept contributor proposals on issues that are marked as External and/or Help Wanted. Please let me know if you have any questions and feel free to ask in our Slack channel, too!