[$250] Expense - In the offline state, the paid report disappears from the 'Pay' list

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.89-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2581/folder/13176923/53628502/1099720289?sort=%2Bidentifier
Email or phone of affected tester (no customers): n/a
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Mac 15.4.1 Safari, iPhone 13 iOS 18.6.2
App Component: Search

Action Performed:

Precondition: There are some expenses awaiting payments

1. Navigate to https://staging.new.expensify.com
   2.Navigate to the 'Reports' tab
   3.Click on the 'Pay' tab under the 'To-do' section
   4.Go offline (e.g., disable Wi-Fi/network)
   5.Click the 'Pay' button on the report header
   6.Navigate back to the 'Pay' list by clicking the 'Back' button

Expected Result:

Verify that all expense reports (including the one just paid) are still shown in the list

Actual Result:

In the offline state, the paid report disappears from the 'Pay' list

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022006147700033223570
• Upwork Job ID: 2006147700033223570
• Last Price Increase: 2026-01-13
• Automatic offers:
• tsa321 | Contributor | 110099469

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In the offline state, the paid report disappears from the 'Pay' list

What is the root cause of that problem?

When a user goes offline and clicks the 'Pay' button on a report from the 'Pay' list:

• The optimistic data removes the report from the snapshot (to provide immediate feedback)
• The API call fails because the user is offline
• The failureData didn't restore the report to the snapshot and leaving it permanently hidden

What changes do you think we should make in order to solve the problem?

If we removed the report from the 'Pay' suggested search due to optimistic success data, we need to restore the snapshot data on failure

if (currentSearchKey === CONST.SEARCH.SEARCH_KEYS.PAY) {
    failureData.push({
        onyxMethod: Onyx.METHOD.MERGE,
        key: `${ONYXKEYS.COLLECTION.SNAPSHOT}${hash}`,
        value: {
            data: null,
        },
    });
}

here

App/src/libs/actions/Search.ts

Lines 669 to 682 in 8d19e95

	const failureData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.REPORT_METADATA | typeof ONYXKEYS.COLLECTION.REPORT>> = [
	{
	onyxMethod: Onyx.METHOD.MERGE_COLLECTION,
	key: ONYXKEYS.COLLECTION.REPORT_METADATA,
	value: Object.fromEntries(paymentData.map((item) => [`${ONYXKEYS.COLLECTION.REPORT_METADATA}${item.reportID}`, {isActionLoading: false}])),
	},
	{
	onyxMethod: Onyx.METHOD.MERGE_COLLECTION,
	key: ONYXKEYS.COLLECTION.REPORT,
	value: Object.fromEntries(
	paymentData.map((item) => [`${ONYXKEYS.COLLECTION.REPORT}${item.reportID}`, {errors: getMicroSecondOnyxErrorWithTranslationKey('common.genericErrorMessage')}]),
	),
	},
	];

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.