Admin is removed despite the error message

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.99-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #77780
Email or phone of affected tester (no customers): applausetester+agadmin@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Windows 11/ Chrome, Samsung S23FE/ Android 16, iPhone 13 Mini/ iOS 26.1
App Component: Other

Action Performed:

1. Go to staging.new.expensify.com
2. Log in as a domain admin
3. On the Debug modal, select Simulate failing network requests
4. Navigate to the Admins page: https://staging.new.expensify.com/domain/5857801/admins
5. Click on the domain admin you are logged in to
6. Click "Revoke admin access", Confirm on a modal
7. Verify that an error is visible on the list, and the admin has not been removed
8. Dismiss the error message
9. On the Debug modal, disable Simulate failing network requests
10. Go to Troubleshoot > Clear cache and restart or log out/ log in
11. Navigate to the Admins page again

Expected Result:

The domain admin can access the Admins page because it has not been removed after step 8.

Actual Result:

The domain admin has been removed after step 8 despite the error message.
After step 12, the "It's not here page" is displayed when trying to access the Admins page.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @ZhenjaHorbach

[melvin-bot]

@mountiny recently merged #77780, but they are OOO right now, so I'll auto-assign someone else.

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @mollfpr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #77780 - "[Release 1] [Domain Control] Revoke admin access" by @jmusial (High confidence)
Related Issues: None identified

Recommendation: REVERT

The PR has a critical bug in the optimistic update logic that causes admins to be removed even when the API call fails. This breaks the expected rollback behavior and violates data integrity.

Detailed Analysis

Evidence

• The issue description explicitly mentions this is reproducible with PR [Release 1] [Domain Control] Revoke admin access #77780, which introduced the "Revoke admin access" feature
• This is a staging-only issue (new feature does not exist in production)
• The bug occurs specifically in the error handling flow when network requests are simulated to fail

Root Cause

The revokeDomainAdminAccess function in /src/libs/actions/Domain.ts (lines 646-702) is missing the optimistic update that removes the admin from the domain object.

Comparison with the correct implementation:

• addAdminToDomain (lines 520-644) correctly includes optimistic data that adds the admin to the domain:

  const PERMISSION_KEY = `${ONYXKEYS.COLLECTION.EXPENSIFY_ADMIN_ACCESS_PREFIX}${accountID}`;
  const optimisticData = [
    {
      key: `${ONYXKEYS.COLLECTION.DOMAIN}${domainAccountID}`,
      value: { [PERMISSION_KEY]: accountID }  // Adds admin
    }
  ];

• revokeDomainAdminAccess fails to remove the admin in optimistic data - it only sets the pending action but does not set [PERMISSION_KEY]: null

Why this causes the bug:

1. When "Simulate failing network requests" is enabled, the optimistic data is applied (but since it does not remove the admin, the admin stays visible)
2. The API call fails as expected
3. The failure data is applied, which shows an error
4. However, when the user dismisses the error via clearRemoveAdminError, it clears the pending action
5. On page refresh or cache clear, the domain data is fetched fresh from the backend, and since the API never actually removed the admin (it failed), but the local cache has no proper record, the admin appears removed

The correct behavior should be:

1. Optimistic: Remove admin from UI immediately
2. Failure: Restore admin to UI + show error
3. After dismissing error: Admin remains visible since removal failed

Instead, what happens is:

1. Optimistic: Admin stays visible (missing removal)
2. Failure: Error shown, admin still visible (correct at this point)
3. After dismissing + reload: Admin disappears (incorrect - cache inconsistency)