[Awaiting Checklist] [$250] Expense - Unable to edit the route after creating distance expense in selfDM

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.8-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-3390/folder/13176670/41236541/1146027637?p=2
Email or phone of affected tester (no customers): sustinov@applausemail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Windows 11/Chrome
App Component: Money Requests

Action Performed:

Prerequisites:
Use a new HT account

Steps:

1. Open https://staging.new.expensify.com/
2. Log in to your new HT account
3. Tap FAB - Track distance
4. Create a valid route
5. Send the expense to selfDM
6. Open the created expense
7. Try editing the route

Expected Result:

The user should be able to edit the route of a created distance expense in selfDM

Actual Result:

Unable to edit the route after creating distance expense in selfDM if there is no active WS

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @garrettmknight

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022034004340856583439
• Upwork Job ID: 2034004340856583439
• Last Price Increase: 2026-03-17

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user creates a distance expense in selfDM without an active workspace, they are unable to edit the route after creating the expense. The distance field should be editable for P2P (person-to-person) distance expenses.

What is the root cause of that problem?

The root cause is in MoneyRequestView.tsx. The canEditDistance and canEditDistanceRate conditions both require isPolicyAccessible(policy, currentUserEmailParam) to be true:

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 351 to 360 in c7e4101

	const canEditDistance =
	!isGPSDistanceRequest &&
	isEditable &&
	canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.DISTANCE, undefined, isChatReportArchived, undefined, transaction, moneyRequestReport, policy) &&
	isPolicyAccessible(policy, currentUserEmailParam);
	const canEditDistanceRate =
	isEditable &&
	canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.DISTANCE_RATE, undefined, isChatReportArchived, undefined, transaction, moneyRequestReport, policy) &&
	isPolicyAccessible(policy, currentUserEmailParam);

For selfDM distance expenses without an active workspace:

1. The transaction uses a P2P rate with customUnitRateID === CONST.CUSTOM_UNITS.FAKE_P2P_ID
2. There's no workspace policy associated with the transaction, so policy is null/undefined
3. isPolicyAccessible returns false for null/empty policies
4. This causes canEditDistance and canEditDistanceRate to be false, disabling the edit functionality

What changes do you think we should make in order to solve the problem?

In MoneyRequestView.tsx, modify the canEditDistance and canEditDistanceRate conditions to allow editing for P2P distance requests even when there's no accessible policy.

+import {isCustomUnitRateIDForP2P} from '@libs/TransactionUtils';

+const isP2PDistanceRequest = isCustomUnitRateIDForP2P(transaction);

 const canEditDistance =
     !isGPSDistanceRequest &&
     isEditable &&
     canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.DISTANCE, undefined, isChatReportArchived, undefined, transaction, moneyRequestReport, policy) &&
-    isPolicyAccessible(policy, currentUserEmailParam);
+    (isPolicyAccessible(policy, currentUserEmailParam) || isP2PDistanceRequest);

 const canEditDistanceRate =
     isEditable &&
     canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.DISTANCE_RATE, undefined, isChatReportArchived, undefined, transaction, moneyRequestReport, policy) &&
-    isPolicyAccessible(policy, currentUserEmailParam);
+    (isPolicyAccessible(policy, currentUserEmailParam) || isP2PDistanceRequest);

This allows users to edit the distance route and rate for P2P distance expenses in selfDM, while still requiring policy access for workspace-based distance expenses.

What alternative solutions did you explore? (Optional)

[cosmicvulpes]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Users cannot edit the route of a distance expense created in selfDM when there is no active workspace. The distance field becomes read-only after the expense is created.

What is the root cause of that problem?

The canEditDistance check in MoneyRequestView.tsx requires isPolicyAccessible(policy, currentUserEmailParam) to return true. However, for P2P distance requests (expenses created in selfDM without a workspace), the policy is null/empty, causing isPolicyAccessible() to return false.

This was introduced in commit f1aad3ea to make distance read-only when a policy is pending deletion, but it unintentionally broke P2P distance editing.

Relevant code:

https://github.com/Expensify/App/blob/87e6d666b4e/src/components/ReportActionItem/MoneyRequestView.tsx#L351-L355

What changes do you think we should make in order to solve the problem?

Allow distance editing for P2P distance requests by checking if the transaction uses the P2P rate ID (FAKE_P2P_ID). If it's a P2P request, skip the policy accessibility check.

const isP2PDistanceRequest = isCustomUnitRateIDForP2P(transaction);
const canEditDistance =
    !isGPSDistanceRequest &&
    isEditable &&
    canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.DISTANCE, undefined, isChatReportArchived, undefined, transaction, moneyRequestReport, policy) &&
    (isP2PDistanceRequest || isPolicyAccessible(policy, currentUserEmailParam));

This requires importing isCustomUnitRateIDForP2P from @libs/TransactionUtils.

What alternative solutions did you explore? (Optional)

N/A

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to edit the route after creating distance expense in selfDM if there is no active WS

What is the root cause of that problem?

If there's no active group policy, policyForMovingExpenses is undefined

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 214 to 219 in ad6d216

	let policy;
	let policyID;
	// If the expense is unreported the policy should be the user's default policy, if the expense is a per diem request and is unreported
	// the policy should be the one where the per diem rates are enabled, otherwise it should be the expense's report policy
	if (isExpenseUnreported && !isPerDiemRequest) {
	policy = policyForMovingExpenses;

isPolicyAccessible return false and the distance field is blocked based on this condition.

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 351 to 356 in ad6d216

	const canEditDistance =
	!isGPSDistanceRequest &&
	isEditable &&
	canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.DISTANCE, undefined, isChatReportArchived, undefined, transaction, moneyRequestReport, policy) &&
	isPolicyAccessible(policy, currentUserEmailParam);

What changes do you think we should make in order to solve the problem?

isPolicyAccessible check is added to fix this issue #77596 which blocking the user from editing the distance/rate of an archived report. This check cause the request which isn't related to any policy like DM or the selfDM when there's no active workspace can't edit the distance field.

1. Instead of checking isPolicyAccessible, I suggest a cleaner approach to fix Fix: Different error messages on invalid distance rate and inaccessible policy #77596. We will fix it in canEditFieldOfMoneyRequest since we already have isChatReportArchived to detech whether a workspace chat is deleted.

if (fieldToEdit === CONST.EDIT_REQUEST_FIELD.DISTANCE_RATE) {
        // The distance rate can be modified only on the distance expense reports
        return isExpenseReport(moneyRequestReport) && isDistanceRequest(transaction) && !isChatReportArchived;
    }

    if (fieldToEdit === CONST.EDIT_REQUEST_FIELD.DISTANCE) {
        return !isExpenseReport(moneyRequestReport) || !isChatReportArchived;
    }

App/src/libs/ReportUtils.ts

Line 4747 in b15b8d6

if (fieldToEdit === CONST.EDIT_REQUEST_FIELD.DISTANCE_RATE) {

2. Then we can remove isPolicyAccessible check here

const canEditDistance =
        !isGPSDistanceRequest &&
        isEditable &&
        canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.DISTANCE, undefined, isChatReportArchived, undefined, transaction, moneyRequestReport, policy)

    const canEditDistanceRate =
        isEditable &&
        canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.DISTANCE_RATE, undefined, isChatReportArchived, undefined, transaction, moneyRequestReport, policy) &&

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 351 to 365 in ad6d216

	const canEditDistance =
	!isGPSDistanceRequest &&
	isEditable &&
	canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.DISTANCE, undefined, isChatReportArchived, undefined, transaction, moneyRequestReport, policy) &&
	isPolicyAccessible(policy, currentUserEmailParam);
	const canEditDistanceRate =
	isEditable &&
	canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.DISTANCE_RATE, undefined, isChatReportArchived, undefined, transaction, moneyRequestReport, policy) &&
	isPolicyAccessible(policy, currentUserEmailParam);
	const canEditReport =
	isEditable &&
	canEditFieldOfMoneyRequest(
	parentReportAction,

What alternative solutions did you explore? (Optional)

For the point 1, we can replace isChatReportArchived with isPolicyAccessible check

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[annaweber830]

🚨 Edited by proposal-police: This proposal was edited at 2026-01-27 11:12:55 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

After creating a distance expense and sending it to selfDM (especially for a brand new account with no workspaces), the route/distance field on the expense is not editable. Users should be able to open the distance editor and adjust the route.

What is the root cause of that problem?

In src/components/ReportActionItem/MoneyRequestView.tsx, we derive the policy and policyID for the Money Request view from the parent report’s policyID unless the expense is “unreported”:

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 214 to 227 in 87e6d66

	let policy;
	let policyID;
	// If the expense is unreported the policy should be the user's default policy, if the expense is a per diem request and is unreported
	// the policy should be the one where the per diem rates are enabled, otherwise it should be the expense's report policy
	if (isExpenseUnreported && !isPerDiemRequest) {
	policy = policyForMovingExpenses;
	policyID = policyForMovingExpensesID;
	} else if (isExpenseUnreported && isPerDiemRequest) {
	policy = perDiemOriginalPolicy;
	policyID = perDiemOriginalPolicy?.id;
	} else {
	policy = expensePolicy;
	policyID = parentReport?.policyID;
	}

For selfDM distance expenses, parentReport?.policyID can be empty/undefined (e.g. new accounts with no active workspace). However, the distance/route menu item is gated by isPolicyAccessible(policy, currentUserEmailParam):

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 351 to 360 in 87e6d66

	const canEditDistance =
	!isGPSDistanceRequest &&
	isEditable &&
	canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.DISTANCE, undefined, isChatReportArchived, undefined, transaction, moneyRequestReport, policy) &&
	isPolicyAccessible(policy, currentUserEmailParam);
	const canEditDistanceRate =
	isEditable &&
	canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.DISTANCE_RATE, undefined, isChatReportArchived, undefined, transaction, moneyRequestReport, policy) &&
	isPolicyAccessible(policy, currentUserEmailParam);

canEditDistance is then used to set the distance row’s interactive / shouldShowRightIcon props and to decide whether tapping the row should navigate into the distance editor, so when it is false the route cannot be edited from the expense view.

isPolicyAccessible() returns false when policy is empty/missing (it requires a real policy with an id and a role):

App/src/libs/PolicyUtils.ts

Lines 1531 to 1538 in 87e6d66

	function isPolicyAccessible(policy: OnyxEntry<Policy>, currentUserLogin: string): boolean {
	return (
	!isEmptyObject(policy) &&
	(Object.keys(policy).length !== 1 || isEmptyObject(policy.errors)) &&
	!!policy?.id &&
	policy?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE &&
	!!getPolicyRole(policy, currentUserLogin)
	);

So for selfDM distance expenses without a workspace policy (policyID is undefined and policy is empty), isPolicyAccessible() returns false, which forces canEditDistance to be false. That makes the distance item non-interactive and blocks opening the route editor.

What changes do you think we should make in order to solve the problem?

Update the “policy accessibility” gate so it only applies when this money request is tied to a real workspace policy. If there is no policyID (e.g. selfDM / P2P distance expense), we should allow editing based on the existing edit-permissions checks.

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 351 to 355 in 87e6d66

	const canEditDistance =
	!isGPSDistanceRequest &&
	isEditable &&
	canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.DISTANCE, undefined, isChatReportArchived, undefined, transaction, moneyRequestReport, policy) &&
	isPolicyAccessible(policy, currentUserEmailParam);

const canEditDistance =
    !isGPSDistanceRequest &&
    isEditable &&
    canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.DISTANCE, undefined, isChatReportArchived, undefined, transaction, moneyRequestReport, policy) &&
    (!policyID || isPolicyAccessible(policy, currentUserEmailParam));

This keeps the safety check for workspace-linked expenses (where a user might lose access to the workspace), while unblocking editing for selfDM distance expenses that are not associated with any workspace policy.

What alternative solutions did you explore? (Optional)