[HOLD for payment 2022-03-31] Future dates in DOB date picker are not disabled. It is disabled for Incorporation Date - reported by @thesahindia

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to workspace > Connect Bank Account
2. Choose any option > Go to company step
3. Check Incorporation Date field date picker
4. Go to Personal details step and check DOB field date picker

Expected Result:

The future dates should be disabled for DOB date picker

Actual Result:

Future dates in DOB date picker are not disabled.

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.41-4
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2022-03-04.at.7.39.42.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1646403860813759

View all open jobs on GitHub

this job

[MelvinBot]

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mountiny]

@luacmartins Coming from the Slack thread, there was not more people who chimed in. As you worked on the Forms overhaul, you probably have the best idea about how we want to proceed with the forms in future.

Would you say then we would want to enable future dates, but throw error? We would need to do the validation (if it does not exist yet internally in backend)

[mountiny]

Although I feel like in this case we could go with disabling it in front end. We should still make sure we have validation steps that catch bugs or bad actors, but it seems like there should be no case when users will want to add future data, so so no reason to actually allow them to.

I can be persuaded differently though 😄

[luacmartins]

I agree that we should move forward with disabling future dates and "set the customer up for success". I agree that we should keep the validation checks. We are already doing those in the frontend and backend.

[MelvinBot]

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[mountiny]

@luacmartins Perfect, thank you so much!

[thesahindia]

Proposal

need to pass maximumDate={new Date()} in DatePicker

App/src/pages/ReimbursementAccount/IdentityForm.js

Lines 91 to 96 in 3696074

	<DatePicker
	label={`${props.translate('common.dob')}`}
	containerStyles={[styles.mt4]}
	placeholder={props.translate('common.dateFormat')}
	value={props.values.dob}
	onChange={value => props.onFieldChange({dob: value})}

[jboniface]

job: https://www.upwork.com/jobs/~012490be37ef1d4dec