[Due for payment 2026-04-14] [$250] Submit button is displayed on expense from archived workspace

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.18-7
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-5235/folder/13176686/41236629/1189009430?sort=-status_id
Email or phone of affected tester (no customers): gocemate+b21549011@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 10/Chrome
App Component: Other

Action Performed:

1. Admin creates workspace and invite a member
2. Admin goes offline
3. Admin remove the Member from workspace
4. Member create a expense in workspace chat
5. Admin goes online
6. Verify workspace chat disappears on Member's side
7. Member goes to search and open the expense details page
8. Member goes to Report> Submit section

Expected Result:

Submit section and submit button should not be displayed since workspace is archived

Actual Result:

Submit section and submit button are displayed in Report page

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7077058_1771001398583.Recording__226.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022025184464966947347
• Upwork Job ID: 2025184464966947347
• Last Price Increase: 2026-03-24
• Automatic offers:
• aimane-chnaif | Reviewer | 110898115

Issue Owner

Current Issue Owner: @mallenexpensify

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Submit button is displayed on expense from archived workspace

What is the root cause of that problem?

• The action button in the Search page is determined by the getActions function in src/libs/SearchUIUtils.ts. For the Submit action specifically, getActions calls canSubmitReport from src/libs/actions/IOU/index.ts (line 1833):

if (
    canSubmitReport(report, policy, allReportTransactions, allViolations,
        isIOUReportArchived || isChatReportArchived, currentUserLogin, currentUserAccountID) &&
    isAllowedToApproveExpenseReport
) {
    allActions.push(CONST.SEARCH.ACTION_TYPES.SUBMIT);
}

The canSubmitReport function checks:

return (
    isOpenExpenseReport &&
    (report?.ownerAccountID === currentUserAccountID || report?.managerID === currentUserAccountID || isAdmin) &&
    !hasOnlyPendingCardOrScanFailTransactions &&
    !hasAllPendingRTERViolations &&
    hasTransactionWithoutRTERViolation &&
    !isReportArchived &&
    !hasAnySubmissionBlockingViolations &&
    transactions.length > 0
);

However, the equivalent function isSubmitAction in src/libs/ReportSecondaryActionUtils.ts (used in report/header views) has an additional critical guard that canSubmitReport is missing:

// ReportSecondaryActionUtils.ts — line 226
if (!isExpenseReport || (report?.total === 0 && reportTransactions.length === 0) || !isPaidGroupPolicy(policy)) {
    return false;
}

The isPaidGroupPolicy(policy) check is absent from canSubmitReport. This is the root cause.

What changes do you think we should make in order to solve the problem?

• Add the isPaidGroupPolicy(policy) check to canSubmitReport in src/libs/actions/IOU/index.ts, aligning it with the existing check in isSubmitAction in ReportSecondaryActionUtils.ts:

function canSubmitReport(
    report: OnyxEntry<OnyxTypes.Report>,
    policy: OnyxEntry<OnyxTypes.Policy>,
    transactions: OnyxTypes.Transaction[],
    allViolations: OnyxCollection<OnyxTypes.TransactionViolations> | undefined,
    isReportArchived: boolean,
    currentUserEmailParam: string,
    currentUserAccountID: number,
) {
    const isOpenExpenseReport = isOpenExpenseReportReportUtils(report);
    const isAdmin = policy?.role === CONST.POLICY.ROLE.ADMIN;
    // ... existing checks ...

    return (
        isOpenExpenseReport &&
        isPaidGroupPolicy(policy) &&  // <-- Add this check
        (report?.ownerAccountID === currentUserAccountID || report?.managerID === currentUserAccountID || isAdmin) &&
        !hasOnlyPendingCardOrScanFailTransactions &&
        !hasAllPendingRTERViolations &&
        hasTransactionWithoutRTERViolation &&
        !isReportArchived &&
        !hasAnySubmissionBlockingViolations &&
        transactions.length > 0
    );
}

• In addition to adding the isPaidGroupPolicy check, we could introduce further conditions to better align the logic between canSubmitReport and isSubmitAction. However, within the scope of this issue, I suggest focusing only on the differences between canSubmitReport and isSubmitAction that directly lead to this bug.

What alternative solutions did you explore? (Optional)

[aimane-chnaif]

I asked for assignment as reviewer here

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When an admin removes a member from a workspace while offline, and the member has created an expense in the workspace chat, the member's expense report is moved to a personal policy once the admin goes back online. However, the Submit button and Submit section still appear on the Report page for the member, even though the report is no longer under a paid group policy and should not be submittable.

What is the root cause of that problem?

The isSubmitAction function in ReportPrimaryActionUtils.ts and canSubmitReport function in IOU/index.ts are both missing the isPaidGroupPolicy(policy) check. After the member is removed, their expense report moves to a personal policy, but these functions still return true because they don't verify the policy type.

isSubmitAction in ReportPrimaryActionUtils.ts — no isPaidGroupPolicy check in return condition:

App/src/libs/ReportPrimaryActionUtils.ts

Line 136 in a93a316

return isExpenseReport && isReportSubmitter && isOpenReport && reportTransactions.length !== 0 && transactionAreComplete;

canSubmitReport in IOU/index.ts — also missing isPaidGroupPolicy check:

App/src/libs/actions/IOU/index.ts

Lines 10447 to 10456 in a93a316

	return (
	isOpenExpenseReport &&
	(report?.ownerAccountID === currentUserAccountID || report?.managerID === currentUserAccountID || isAdmin) &&
	!hasOnlyPendingCardOrScanFailTransactions &&
	!hasAllPendingRTERViolations &&
	hasTransactionWithoutRTERViolation &&
	!isReportArchived &&
	!hasAnySubmissionBlockingViolations &&
	transactions.length > 0
	);

In contrast, canSubmitReport in ReportSecondaryActionUtils.ts correctly guards against this by checking isPaidGroupPolicy(policy):

App/src/libs/ReportSecondaryActionUtils.ts

Line 225 in a93a316

if (!isExpenseReport || (report?.total === 0 && reportTransactions.length === 0) || !isPaidGroupPolicy(policy)) {

This causes the Submit button to show in the report primary action, in search results (via SearchUIUtils.ts), and in the Home page todos (via configs/todos.ts).

If we open this expense report, we can see the submit button doesn't show because we've handled in the root function here

App/src/libs/ReportPrimaryActionUtils.ts

Line 434 in a93a316

if (isExpenseReportUtils(report) && !isPaidGroupPolicy(policy)) {

What changes do you think we should make in order to solve the problem?

Add isPaidGroupPolicy(policy) check to both functions, consistent with how ReportSecondaryActionUtils.ts already handles it.

1. In src/libs/ReportPrimaryActionUtils.ts, add the check to the return condition of isSubmitAction:

// Before
return isExpenseReport && isReportSubmitter && isOpenReport && reportTransactions.length !== 0 && transactionAreComplete;

// After
return isExpenseReport && isReportSubmitter && isOpenReport && isPaidGroupPolicy(policy) && reportTransactions.length !== 0 && transactionAreComplete;

App/src/libs/ReportPrimaryActionUtils.ts

Line 136 in a93a316

return isExpenseReport && isReportSubmitter && isOpenReport && reportTransactions.length !== 0 && transactionAreComplete;

2. In src/libs/actions/IOU/index.ts, add the check to the return condition of canSubmitReport:

// Before
return (
    isOpenExpenseReport &&
    (report?.ownerAccountID === currentUserAccountID || report?.managerID === currentUserAccountID || isAdmin) &&
    ...
);

// After
return (
    isOpenExpenseReport &&
    isPaidGroupPolicy(policy) &&
    (report?.ownerAccountID === currentUserAccountID || report?.managerID === currentUserAccountID || isAdmin) &&
    ...
);

App/src/libs/actions/IOU/index.ts

Lines 10447 to 10456 in a93a316

	return (
	isOpenExpenseReport &&
	(report?.ownerAccountID === currentUserAccountID || report?.managerID === currentUserAccountID || isAdmin) &&
	!hasOnlyPendingCardOrScanFailTransactions &&
	!hasAllPendingRTERViolations &&
	hasTransactionWithoutRTERViolation &&
	!isReportArchived &&
	!hasAnySubmissionBlockingViolations &&
	transactions.length > 0
	);

[melvin-bot]

Eep! 4 days overdue now. Issues have feelings too...