Skip to content

[BT-130] Migrate Reports - Core (Part 2) #83367

@mjasikowski

Description

@mjasikowski

Description

Current State:

  • 5 report participant routes use backTo parameter
  • These handle participants list, invites, and settings

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (5):

Route Constant Path
REPORT_PARTICIPANTS r/:reportID/participants
REPORT_PARTICIPANTS_INVITE r/:reportID/participants/invite
REPORT_PARTICIPANTS_DETAILS r/:reportID/participants/:accountID
REPORT_PARTICIPANTS_ROLE_SELECTION r/:reportID/participants/:accountID/role
REPORT_SETTINGS r/:reportID/settings

Usages

REPORT_PARTICIPANTS:

  • src/pages/ReportDetailsPage.tsx:400
  • src/pages/home/report/ReportActionItemSingle.tsx:134
  • src/pages/ReportParticipantDetailsPage.tsx:46
  • src/pages/InviteReportParticipantsPage.tsx:132
  • src/components/AvatarWithDisplayName.tsx:231

REPORT_PARTICIPANTS_INVITE:

  • src/pages/ReportParticipantsPage.tsx:237

REPORT_PARTICIPANTS_DETAILS:

  • src/pages/ReportParticipantsPage.tsx:378
  • src/pages/ReportParticipantRoleSelectionPage.tsx:33

REPORT_PARTICIPANTS_ROLE_SELECTION:

  • Search for usages in participant role flow

REPORT_SETTINGS:

  • src/pages/ReportDetailsPage.tsx:425
  • src/libs/ReportUtils.ts:6253
  • src/pages/settings/Report/WriteCapabilityPage.tsx:38

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • REPORT_PARTICIPANTS
  • REPORT_PARTICIPANTS_INVITE
  • REPORT_PARTICIPANTS_DETAILS
  • REPORT_PARTICIPANTS_ROLE_SELECTION
  • REPORT_SETTINGS
Issue OwnerCurrent Issue Owner: @suneox

Metadata

Metadata

Labels

InternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions