[$250] Concierge - Duplicated 'Take a test drive' task

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.43-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176677/test-cases/41237675
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Windows 11, Chrome | iPhone SE 3rd generation, iOS 26.3.1 | Samsung A15, Android 16
App Component: Other

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Sign up with a Gmail address (without +)
3. Click Skip > Track and budget expenses > Enter any name > Skip WS creation
4. Click FAB > New workspace > Confirm
5. Navigate to Inbox, then click Concierge chat

Expected Result:

Only one 'Take a test drive' task should appear.

Actual Result:

The system displays two identical 'Take a test drive' tasks, causing confusion and redundancy in the task list.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @hoangzinh

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022036500319898147935
• Upwork Job ID: 2036500319898147935
• Last Price Increase: 2026-03-24

[MelvinBot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After signing up, selecting "Track and budget expenses" (PERSONAL_SPEND), skipping workspace creation, and then creating a new workspace via the FAB menu, users see two identical "Take a test drive" tasks in the Concierge chat.

What is the root cause of that problem?

The "Take a test drive" task is created by prepareOnboardingOnyxData() in ReportUtils.ts, which is called from two separate code paths during this flow, and there is no deduplication guard:

1. First call (onboarding skip): When the user clicks "Skip" on the workspace optional page, completeOnboarding() → prepareOnboardingOnyxData() creates a testDriveEmployeeTask (type VIEW_TOUR) in Concierge. After this, introSelected.createWorkspace is set to undefined because PERSONAL_SPEND has no CREATE_WORKSPACE task, and hasCompletedGuidedSetupFlow is set to true.

2. Second call (workspace creation): When the user creates a workspace via FAB → New workspace → Confirm, the flow goes through savePolicyDraftByNewWorkspace() → createWorkspace() → buildPolicyData(). At Policy.ts:2827-2831, buildPolicyData checks:

   introSelected !== undefined  →  true
   !introSelected?.createWorkspace  →  true (undefined for PERSONAL_SPEND)
   engagementChoice  →  TRACK_WORKSPACE (truthy)
   shouldAddOnboardingTasks  →  true (default, not explicitly set to false)
   

   All conditions pass, so it calls prepareOnboardingOnyxData() again, creating a second testDriveAdminTask (also type VIEW_TOUR) in Concierge.

There is an existing VIEW_TOUR filter at ReportUtils.ts:11846-11858 designed to prevent this, but it only blocks when engagementChoice === MANAGE_TEAM. For PERSONAL_SPEND users (who get TRACK_WORKSPACE as their engagement choice), the filter does not apply.

Notably, the during-onboarding workspace creation path at BaseOnboardingWorkspaceOptional.tsx:170 correctly passes shouldAddOnboardingTasks: false, but the post-onboarding workspace creation path (savePolicyDraftByNewWorkspace in App.ts) does not set this flag, allowing the duplicate.

What changes do you think we should make in order to solve the problem?

The fix should be in buildPolicyData() in Policy.ts. Add a check for hasCompletedGuidedSetupFlow to the condition at line 2827 so that onboarding tasks are not re-created when the guided setup has already been completed:

The condition should additionally verify that the guided setup flow hasn't already been completed before calling prepareOnboardingOnyxData. This is the same pattern already used in getGuidedSetupDataForOpenReport() at Report/index.ts:1248, which properly checks isOnboardingCompleted before proceeding.

What alternative solutions did you explore? (Optional)

1. Extending the VIEW_TOUR filter in prepareOnboardingOnyxData to also cover TRACK_WORKSPACE engagement choice — this would fix the specific VIEW_TOUR duplication but would not prevent other task types from being duplicated via the same mechanism.
2. Passing shouldAddOnboardingTasks: false from savePolicyDraftByNewWorkspace when hasCompletedGuidedSetupFlow is already true — this would also work but pushes the responsibility to callers rather than having the central guard in buildPolicyData.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022036500319898147935

[gps949]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After signing up with PERSONAL_SPEND choice, skipping workspace creation, and then creating a new workspace via FAB > New workspace, two identical "Take a test drive" (VIEW_TOUR) tasks appear in the Concierge chat.

What is the root cause of that problem?

The root cause is the incomplete VIEW_TOUR deduplication filter in prepareOnboardingOnyxData() (ReportUtils.ts ~L11846-11858).

The first VIEW_TOUR task is created during completeOnboarding() when the user selects PERSONAL_SPEND and skips workspace creation. The second is created when the user later creates a workspace via FAB, which triggers savePolicyDraftByNewWorkspace() → createWorkspace() → buildPolicyData(). In savePolicyDraftByNewWorkspace (App.ts L720), when introSelected?.choice === PERSONAL_SPEND, the engagementChoice is remapped to TRACK_WORKSPACE.

The existing VIEW_TOUR filter condition at ReportUtils.ts is:

task.type === VIEW_TOUR &&
[EMPLOYER, PERSONAL_SPEND, SUBMIT, CHAT_SPLIT, MANAGE_TEAM].includes(introSelected?.choice) &&
engagementChoice === MANAGE_TEAM

This guard correctly includes PERSONAL_SPEND in the introSelected.choice check, but the third condition engagementChoice === MANAGE_TEAM is too restrictive — it only filters the task when the engagement choice is MANAGE_TEAM. For PERSONAL_SPEND users creating a workspace post-onboarding, engagementChoice is TRACK_WORKSPACE, so the filter doesn't apply and a duplicate VIEW_TOUR task is created.

What changes do you think we should make in order to solve the problem?

Expand the VIEW_TOUR filter condition in prepareOnboardingOnyxData() in ReportUtils.ts to also cover the TRACK_WORKSPACE engagement choice. The fix is a one-line change:

// Before:
engagementChoice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM

// After:
(engagementChoice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM || engagementChoice === CONST.ONBOARDING_CHOICES.TRACK_WORKSPACE)

This is the minimal, targeted fix because:

1. It fixes the actual deduplication guard rather than adding a new external check at the caller level.
2. TRACK_WORKSPACE is explicitly the remapped engagement choice for PERSONAL_SPEND users (as seen in App.ts L720), so this condition is precise and only affects the affected flow.
3. It follows the existing pattern — the filter already checks specific engagement choices; we're just covering the missing one.
4. No risk of breaking the initial onboarding flow, since during initial onboarding engagementChoice matches introSelected.choice directly (not remapped), and the introSelected.choice check list already includes PERSONAL_SPEND.

What alternative solutions did you explore? (Optional)

• Adding a hasCompletedGuidedSetupFlow check in buildPolicyData() — this would work but adds a new guard at the caller level rather than fixing the existing deduplication logic where it belongs. It also requires threading an additional parameter through buildPolicyData.
• Passing shouldAddOnboardingTasks: false from savePolicyDraftByNewWorkspace — pushes responsibility to every caller instead of fixing the central guard.

Implementation ready — can submit PR immediately upon assignment.

Contributor details Timezone: UTC+8, Available hours: flexible

[abbasifaizan70]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After signing up and selecting Track and budget expenses, Concierge shows a setup checklist that includes Take a test drive.
If the user skips workspace creation and later creates a workspace manually (FAB -> New workspace), Concierge receives another onboarding checklist that also includes Take a test drive.

Expected: only one Take a test drive task should be visible in Concierge.
Actual: two identical Take a test drive tasks are displayed.

What is the root cause of that problem?

The first task comes from the Personal Spend onboarding message, which includes testDriveEmployeeTask (VIEW_TOUR):

App/src/libs/actions/Welcome/OnboardingFlow.ts

Lines 318 to 321 in b565dad

	const onboardingPersonalSpendMessage: OnboardingMessage = {
	message: translate(resolvedLocale, 'onboarding.messages.onboardingPersonalSpendMessage'),
	tasks: [testDriveEmployeeTask, trackExpenseTask],
	};

When creating a workspace from the FAB, savePolicyDraftByNewWorkspace maps Personal Spend users to TRACK_WORKSPACE, which uses another onboarding message that also includes a VIEW_TOUR task (testDriveAdminTask):

App/src/libs/actions/App.ts

Lines 715 to 734 in b565dad

	createWorkspace({
	policyOwnerEmail,
	makeMeAdmin,
	policyName,
	policyID,
	engagementChoice: introSelected?.choice === CONST.ONBOARDING_CHOICES.PERSONAL_SPEND ? CONST.ONBOARDING_CHOICES.TRACK_WORKSPACE : CONST.ONBOARDING_CHOICES.MANAGE_TEAM,
	currency,
	file,
	lastUsedPaymentMethod,
	introSelected,
	activePolicyID,
	currentUserAccountIDParam,
	currentUserEmailParam,
	allReportsParam,
	shouldCreateControlPolicy,
	type,
	isSelfTourViewed,
	betas,
	hasActiveAdminPolicies,
	});

App/src/libs/actions/Welcome/OnboardingFlow.ts

Lines 343 to 353 in b565dad

	const onboardingTrackWorkspaceMessage: OnboardingMessage = {
	message: translate(resolvedLocale, 'onboarding.messages.onboardingTrackWorkspaceMessage'),
	video: {
	url: `${CONST.CLOUDFRONT_URL}/videos/guided-setup-manage-team-v2.mp4`,
	thumbnailUrl: `${CONST.CLOUDFRONT_URL}/images/guided-setup-manage-team.jpg`,
	duration: 55,
	width: 1280,
	height: 960,
	},
	tasks: [createWorkspaceTask, testDriveAdminTask, createReportTask, setupCategoriesTask, inviteAccountantTask, reviewWorkspaceSettingsTask],
	};

buildPolicyData calls prepareOnboardingOnyxData again when introSelected.createWorkspace is not set, so onboarding tasks are generated a second time:

App/src/libs/actions/Policy/Policy.ts

Lines 2827 to 2855 in b565dad

	if (
	introSelected !== undefined &&
	(introSelected.choice === CONST.ONBOARDING_CHOICES.TEST_DRIVE_RECEIVER || !introSelected?.createWorkspace) &&
	engagementChoice &&
	shouldAddOnboardingTasks
	) {
	const {onboardingMessages} = getOnboardingMessages();
	const onboardingData = ReportUtils.prepareOnboardingOnyxData({
	introSelected,
	engagementChoice,
	onboardingMessage: onboardingMessages[engagementChoice],
	adminsChatReportID,
	onboardingPolicyID: policyID,
	onboardingPurposeSelected,
	companySize: companySize ?? (introSelected?.companySize as OnboardingCompanySize),
	isSelfTourViewed,
	betas,
	});
	if (!onboardingData) {
	return {successData, optimisticData, failureData, params};
	}
	const {guidedSetupData, optimisticData: taskOptimisticData, successData: taskSuccessData, failureData: taskFailureData} = onboardingData;
	params.guidedSetupData = JSON.stringify(guidedSetupData);
	params.engagementChoice = engagementChoice;
	optimisticData.push(...taskOptimisticData);
	successData.push(...taskSuccessData);
	failureData.push(...taskFailureData);

Inside prepareOnboardingOnyxData, tasks are filtered for feature/beta conditions, but there is no guard to prevent creating a duplicate VIEW_TOUR task when one already exists from a previous onboarding step:

App/src/libs/ReportUtils.ts

Lines 11829 to 11926 in b565dad

	const tasks = shouldUseFollowupsInsteadOfTasks ? [] : onboardingMessage.tasks;
	const tasksData = tasks
	.filter((task) => {
	if (engagementChoice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM) {
	if (!!selectedInterestedFeatures && TASK_TO_FEATURE[task.type] && !selectedInterestedFeatures.includes(TASK_TO_FEATURE[task.type])) {
	return false;
	}
	}
	if (([CONST.ONBOARDING_TASK_TYPE.SETUP_CATEGORIES, CONST.ONBOARDING_TASK_TYPE.SETUP_TAGS] as string[]).includes(task.type) && userReportedIntegration) {
	return false;
	}
	if (([CONST.ONBOARDING_TASK_TYPE.ADD_ACCOUNTING_INTEGRATION, CONST.ONBOARDING_TASK_TYPE.SETUP_CATEGORIES_AND_TAGS] as string[]).includes(task.type) && !userReportedIntegration) {
	return false;
	}
	type SkipViewTourOnboardingChoices = 'newDotSubmit' | 'newDotSplitChat' | 'newDotPersonalSpend' | 'newDotEmployer';
	if (
	task.type === CONST.ONBOARDING_TASK_TYPE.VIEW_TOUR &&
	[
	CONST.ONBOARDING_CHOICES.EMPLOYER,
	CONST.ONBOARDING_CHOICES.PERSONAL_SPEND,
	CONST.ONBOARDING_CHOICES.SUBMIT,
	CONST.ONBOARDING_CHOICES.CHAT_SPLIT,
	CONST.ONBOARDING_CHOICES.MANAGE_TEAM,
	].includes(introSelected?.choice as SkipViewTourOnboardingChoices) &&
	engagementChoice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM
	) {
	return false;
	}
	// Exclude createWorkspace and viewTour tasks from #admin room, for test drive receivers,
	// since these users already have them in concierge
	if (
	introSelected?.choice === CONST.ONBOARDING_CHOICES.TEST_DRIVE_RECEIVER &&
	([CONST.ONBOARDING_TASK_TYPE.CREATE_WORKSPACE, CONST.ONBOARDING_TASK_TYPE.VIEW_TOUR] as string[]).includes(task.type) &&
	shouldPostTasksInAdminsRoom
	) {
	return false;
	}
	return true;
	})
	.map((task, index) => {
	const taskDescription = typeof task.description === 'function' ? task.description(onboardingTaskParams) : task.description;
	const taskTitle = typeof task.title === 'function' ? task.title(onboardingTaskParams) : task.title;
	const currentTask = buildOptimisticTaskReport(
	actorAccountID,
	targetChatReportID,
	deprecatedCurrentUserAccountID,
	taskTitle,
	taskDescription,
	targetChatPolicyID,
	CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN,
	);
	const emailCreatingAction =
	engagementChoice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM ? (allPersonalDetails?.[actorAccountID]?.login ?? CONST.EMAIL.CONCIERGE) : CONST.EMAIL.CONCIERGE;
	const taskCreatedAction = buildOptimisticCreatedReportAction(emailCreatingAction);
	const taskReportAction = buildOptimisticTaskCommentReportAction(currentTask.reportID, taskTitle, 0, `task for ${taskTitle}`, targetChatReportID, actorAccountID, index + 3);
	currentTask.parentReportActionID = taskReportAction.reportAction.reportActionID;
	let isTaskAutoCompleted: boolean = task.autoCompleted;
	const onboardingSelfTourViewed = isSelfTourViewed ?? onboarding?.selfTourViewed;
	if (task.type === CONST.ONBOARDING_TASK_TYPE.VIEW_TOUR && onboardingSelfTourViewed) {
	// If the user has already viewed the self tour, we mark the task as auto completed
	isTaskAutoCompleted = true;
	}
	if (task.type === CONST.ONBOARDING_TASK_TYPE.INVITE_ACCOUNTANT && isInvitedAccountant) {
	isTaskAutoCompleted = true;
	}
	const completedTaskReportAction = isTaskAutoCompleted
	? buildOptimisticTaskReportAction(currentTask.reportID, CONST.REPORT.ACTIONS.TYPE.TASK_COMPLETED, 'marked as complete', actorAccountID, 2)
	: null;
	if (task.type === CONST.ONBOARDING_TASK_TYPE.CREATE_WORKSPACE) {
	createWorkspaceTaskReportID = currentTask.reportID;
	}
	if (task.type === CONST.ONBOARDING_TASK_TYPE.ADD_EXPENSE_APPROVALS) {
	addExpenseApprovalsTaskReportID = currentTask.reportID;
	}
	if (task.type === CONST.ONBOARDING_TASK_TYPE.SETUP_TAGS) {
	setupTagsTaskReportID = currentTask.reportID;
	}
	if (task.type === CONST.ONBOARDING_TASK_TYPE.SETUP_CATEGORIES_AND_TAGS) {
	setupCategoriesAndTagsTaskReportID = currentTask.reportID;
	}
	return {
	task,
	currentTask,
	taskCreatedAction,
	taskReportAction,
	taskDescription: currentTask.description,
	completedTaskReportAction,
	};
	});

Also, NVP_INTRO_SELECTED stores some task report IDs (createWorkspace, addExpenseApprovals, etc.) but not viewTour, so there is no persisted signal to suppress re-creation of this specific task:

App/src/libs/ReportUtils.ts

Lines 12119 to 12127 in b565dad

	onyxMethod: Onyx.METHOD.MERGE,
	key: ONYXKEYS.NVP_INTRO_SELECTED,
	value: {
	choice: engagementChoice,
	createWorkspace: createWorkspaceTaskReportID,
	addExpenseApprovals: addExpenseApprovalsTaskReportID,
	setupTags: setupTagsTaskReportID,
	setupCategoriesAndTags: setupCategoriesAndTagsTaskReportID,
	},

What changes do you think we should make in order to solve the problem?

1. Persist the VIEW_TOUR task report ID in NVP_INTRO_SELECTED and reuse it as a dedupe signal.

App/src/libs/ReportUtils.ts

Lines 11824 to 11916 in b565dad

	let createWorkspaceTaskReportID;
	let addExpenseApprovalsTaskReportID;
	let setupTagsTaskReportID;
	let setupCategoriesAndTagsTaskReportID;
	// If shouldUseFollowupsInsteadOfTasks we do not want to generate tasks in favour of followups.
	const tasks = shouldUseFollowupsInsteadOfTasks ? [] : onboardingMessage.tasks;
	const tasksData = tasks
	.filter((task) => {
	if (engagementChoice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM) {
	if (!!selectedInterestedFeatures && TASK_TO_FEATURE[task.type] && !selectedInterestedFeatures.includes(TASK_TO_FEATURE[task.type])) {
	return false;
	}
	}
	if (([CONST.ONBOARDING_TASK_TYPE.SETUP_CATEGORIES, CONST.ONBOARDING_TASK_TYPE.SETUP_TAGS] as string[]).includes(task.type) && userReportedIntegration) {
	return false;
	}
	if (([CONST.ONBOARDING_TASK_TYPE.ADD_ACCOUNTING_INTEGRATION, CONST.ONBOARDING_TASK_TYPE.SETUP_CATEGORIES_AND_TAGS] as string[]).includes(task.type) && !userReportedIntegration) {
	return false;
	}
	type SkipViewTourOnboardingChoices = 'newDotSubmit' | 'newDotSplitChat' | 'newDotPersonalSpend' | 'newDotEmployer';
	if (
	task.type === CONST.ONBOARDING_TASK_TYPE.VIEW_TOUR &&
	[
	CONST.ONBOARDING_CHOICES.EMPLOYER,
	CONST.ONBOARDING_CHOICES.PERSONAL_SPEND,
	CONST.ONBOARDING_CHOICES.SUBMIT,
	CONST.ONBOARDING_CHOICES.CHAT_SPLIT,
	CONST.ONBOARDING_CHOICES.MANAGE_TEAM,
	].includes(introSelected?.choice as SkipViewTourOnboardingChoices) &&
	engagementChoice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM
	) {
	return false;
	}
	// Exclude createWorkspace and viewTour tasks from #admin room, for test drive receivers,
	// since these users already have them in concierge
	if (
	introSelected?.choice === CONST.ONBOARDING_CHOICES.TEST_DRIVE_RECEIVER &&
	([CONST.ONBOARDING_TASK_TYPE.CREATE_WORKSPACE, CONST.ONBOARDING_TASK_TYPE.VIEW_TOUR] as string[]).includes(task.type) &&
	shouldPostTasksInAdminsRoom
	) {
	return false;
	}
	return true;
	})
	.map((task, index) => {
	const taskDescription = typeof task.description === 'function' ? task.description(onboardingTaskParams) : task.description;
	const taskTitle = typeof task.title === 'function' ? task.title(onboardingTaskParams) : task.title;
	const currentTask = buildOptimisticTaskReport(
	actorAccountID,
	targetChatReportID,
	deprecatedCurrentUserAccountID,
	taskTitle,
	taskDescription,
	targetChatPolicyID,
	CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN,
	);
	const emailCreatingAction =
	engagementChoice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM ? (allPersonalDetails?.[actorAccountID]?.login ?? CONST.EMAIL.CONCIERGE) : CONST.EMAIL.CONCIERGE;
	const taskCreatedAction = buildOptimisticCreatedReportAction(emailCreatingAction);
	const taskReportAction = buildOptimisticTaskCommentReportAction(currentTask.reportID, taskTitle, 0, `task for ${taskTitle}`, targetChatReportID, actorAccountID, index + 3);
	currentTask.parentReportActionID = taskReportAction.reportAction.reportActionID;
	let isTaskAutoCompleted: boolean = task.autoCompleted;
	const onboardingSelfTourViewed = isSelfTourViewed ?? onboarding?.selfTourViewed;
	if (task.type === CONST.ONBOARDING_TASK_TYPE.VIEW_TOUR && onboardingSelfTourViewed) {
	// If the user has already viewed the self tour, we mark the task as auto completed
	isTaskAutoCompleted = true;
	}
	if (task.type === CONST.ONBOARDING_TASK_TYPE.INVITE_ACCOUNTANT && isInvitedAccountant) {
	isTaskAutoCompleted = true;
	}
	const completedTaskReportAction = isTaskAutoCompleted
	? buildOptimisticTaskReportAction(currentTask.reportID, CONST.REPORT.ACTIONS.TYPE.TASK_COMPLETED, 'marked as complete', actorAccountID, 2)
	: null;
	if (task.type === CONST.ONBOARDING_TASK_TYPE.CREATE_WORKSPACE) {
	createWorkspaceTaskReportID = currentTask.reportID;
	}
	if (task.type === CONST.ONBOARDING_TASK_TYPE.ADD_EXPENSE_APPROVALS) {
	addExpenseApprovalsTaskReportID = currentTask.reportID;
	}
	if (task.type === CONST.ONBOARDING_TASK_TYPE.SETUP_TAGS) {
	setupTagsTaskReportID = currentTask.reportID;
	}
	if (task.type === CONST.ONBOARDING_TASK_TYPE.SETUP_CATEGORIES_AND_TAGS) {
	setupCategoriesAndTagsTaskReportID = currentTask.reportID;
	}

let createWorkspaceTaskReportID;
let addExpenseApprovalsTaskReportID;
let setupTagsTaskReportID;
let setupCategoriesAndTagsTaskReportID;
let viewTourTaskReportID;

// ...inside tasksData.map(...)
if (task.type === CONST.ONBOARDING_TASK_TYPE.VIEW_TOUR) {
    viewTourTaskReportID = currentTask.reportID;
}

App/src/libs/ReportUtils.ts

Lines 12119 to 12127 in b565dad

	onyxMethod: Onyx.METHOD.MERGE,
	key: ONYXKEYS.NVP_INTRO_SELECTED,
	value: {
	choice: engagementChoice,
	createWorkspace: createWorkspaceTaskReportID,
	addExpenseApprovals: addExpenseApprovalsTaskReportID,
	setupTags: setupTagsTaskReportID,
	setupCategoriesAndTags: setupCategoriesAndTagsTaskReportID,
	},

{
    onyxMethod: Onyx.METHOD.MERGE,
    key: ONYXKEYS.NVP_INTRO_SELECTED,
    value: {
        choice: engagementChoice,
        createWorkspace: createWorkspaceTaskReportID,
        addExpenseApprovals: addExpenseApprovalsTaskReportID,
        setupTags: setupTagsTaskReportID,
        setupCategoriesAndTags: setupCategoriesAndTagsTaskReportID,
        viewTour: viewTourTaskReportID,
    },
}

App/src/libs/ReportUtils.ts

Lines 12223 to 12231 in b565dad

	onyxMethod: Onyx.METHOD.MERGE,
	key: ONYXKEYS.NVP_INTRO_SELECTED,
	value: {
	choice: null,
	createWorkspace: null,
	addExpenseApprovals: null,
	setupCategoriesAndTags: null,
	setupTags: null,
	},

{
    onyxMethod: Onyx.METHOD.MERGE,
    key: ONYXKEYS.NVP_INTRO_SELECTED,
    value: {
        choice: null,
        createWorkspace: null,
        addExpenseApprovals: null,
        setupCategoriesAndTags: null,
        setupTags: null,
        viewTour: null,
    },
}

2. Skip VIEW_TOUR task generation when a viewTour task is already tracked in introSelected.

App/src/libs/ReportUtils.ts

Lines 11829 to 11871 in b565dad

	const tasks = shouldUseFollowupsInsteadOfTasks ? [] : onboardingMessage.tasks;
	const tasksData = tasks
	.filter((task) => {
	if (engagementChoice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM) {
	if (!!selectedInterestedFeatures && TASK_TO_FEATURE[task.type] && !selectedInterestedFeatures.includes(TASK_TO_FEATURE[task.type])) {
	return false;
	}
	}
	if (([CONST.ONBOARDING_TASK_TYPE.SETUP_CATEGORIES, CONST.ONBOARDING_TASK_TYPE.SETUP_TAGS] as string[]).includes(task.type) && userReportedIntegration) {
	return false;
	}
	if (([CONST.ONBOARDING_TASK_TYPE.ADD_ACCOUNTING_INTEGRATION, CONST.ONBOARDING_TASK_TYPE.SETUP_CATEGORIES_AND_TAGS] as string[]).includes(task.type) && !userReportedIntegration) {
	return false;
	}
	type SkipViewTourOnboardingChoices = 'newDotSubmit' | 'newDotSplitChat' | 'newDotPersonalSpend' | 'newDotEmployer';
	if (
	task.type === CONST.ONBOARDING_TASK_TYPE.VIEW_TOUR &&
	[
	CONST.ONBOARDING_CHOICES.EMPLOYER,
	CONST.ONBOARDING_CHOICES.PERSONAL_SPEND,
	CONST.ONBOARDING_CHOICES.SUBMIT,
	CONST.ONBOARDING_CHOICES.CHAT_SPLIT,
	CONST.ONBOARDING_CHOICES.MANAGE_TEAM,
	].includes(introSelected?.choice as SkipViewTourOnboardingChoices) &&
	engagementChoice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM
	) {
	return false;
	}
	// Exclude createWorkspace and viewTour tasks from #admin room, for test drive receivers,
	// since these users already have them in concierge
	if (
	introSelected?.choice === CONST.ONBOARDING_CHOICES.TEST_DRIVE_RECEIVER &&
	([CONST.ONBOARDING_TASK_TYPE.CREATE_WORKSPACE, CONST.ONBOARDING_TASK_TYPE.VIEW_TOUR] as string[]).includes(task.type) &&
	shouldPostTasksInAdminsRoom
	) {
	return false;
	}
	return true;
	})

const tasksData = tasks
    .filter((task) => {
        if (task.type === CONST.ONBOARDING_TASK_TYPE.VIEW_TOUR && !!introSelected?.viewTour) {
            return false;
        }

        // existing filters remain unchanged...
        return true;
    })
    .map((task, index) => {
        // existing mapping logic
    });

3. Add unit coverage to ensure prepareOnboardingOnyxData does not emit duplicate VIEW_TOUR tasks when onboarding is invoked again after Personal Spend.

App/tests/unit/ReportUtilsTest.ts

Lines 541 to 934 in b565dad

	describe('prepareOnboardingOnyxData', () => {
	const REPORT_ID = '5';
	beforeEach(async () => {
	Onyx.merge(ONYXKEYS.SESSION, {email: 'test+test@example.com'});
	const chatReport: Report = {
	reportID: REPORT_ID,
	type: CONST.REPORT.TYPE.CHAT,
	participants: {
	[CONST.ACCOUNT_ID.CONCIERGE]: {notificationPreference: CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS},
	[currentUserAccountID]: {notificationPreference: CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS},
	},
	};
	await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${chatReport.reportID}`, chatReport);
	});
	it('provides test drive url to task title', () => {
	const title = jest.fn();
	prepareOnboardingOnyxData({
	introSelected: undefined,
	engagementChoice: CONST.ONBOARDING_CHOICES.MANAGE_TEAM,
	onboardingMessage: {
	message: 'This is a test',
	tasks: [
	{
	type: CONST.ONBOARDING_TASK_TYPE.CREATE_REPORT,
	title,
	description: () => '',
	autoCompleted: false,
	},
	],
	},
	adminsChatReportID: '1',
	companySize: CONST.ONBOARDING_COMPANY_SIZE.MICRO,
	});
	expect(title).toHaveBeenCalledWith(
	expect.objectContaining<OnboardingTaskLinks>({
	// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
	testDriveURL: expect.any(String),
	}),
	);
	});
	it('provides test drive url to task description', () => {
	const description = jest.fn();
	prepareOnboardingOnyxData({
	introSelected: undefined,
	engagementChoice: CONST.ONBOARDING_CHOICES.MANAGE_TEAM,
	onboardingMessage: {
	message: 'This is a test',
	tasks: [
	{
	type: CONST.ONBOARDING_TASK_TYPE.CREATE_REPORT,
	title: () => '',
	description,
	autoCompleted: false,
	},
	],
	},
	adminsChatReportID: '1',
	companySize: CONST.ONBOARDING_COMPANY_SIZE.MICRO,
	});
	expect(description).toHaveBeenCalledWith(
	expect.objectContaining<OnboardingTaskLinks>({
	// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
	testDriveURL: expect.any(String),
	}),
	);
	});
	it('should not add anything to guidedSetupData when posting into the admin room with suggestedFollowups beta', async () => {
	const adminsChatReportID = '1';
	// Not having `+` in the email allows for `isPostingTasksInAdminsRoom` flow
	await Onyx.merge(ONYXKEYS.SESSION, {email: 'test@example.com'});
	// Enable the suggestedFollowups beta so tasks are skipped in favor of backend-generated followups
	await Onyx.merge(ONYXKEYS.BETAS, [CONST.BETAS.SUGGESTED_FOLLOWUPS]);
	await waitForBatchedUpdates();
	const result = prepareOnboardingOnyxData({
	introSelected: undefined,
	engagementChoice: CONST.ONBOARDING_CHOICES.MANAGE_TEAM,
	onboardingMessage: {
	message: 'This is a test',
	tasks: [{type: CONST.ONBOARDING_TASK_TYPE.CONNECT_CORPORATE_CARD, title: () => '', description: () => '', autoCompleted: false}],
	},
	adminsChatReportID,
	selectedInterestedFeatures: ['areCompanyCardsEnabled'],
	companySize: CONST.ONBOARDING_COMPANY_SIZE.MICRO,
	});
	expect(result?.guidedSetupData).toHaveLength(0);
	// suggestedFollowups beta adds a bespoke Concierge welcome action optimistically for all company sizes
	const reportActionsEntries = result?.optimisticData.filter((i) => i.key === `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${adminsChatReportID}`);
	expect(reportActionsEntries).toHaveLength(1);
	expect(result?.bespokeWelcomeMessage).toBeDefined();
	// The bespoke message sent to the backend should be HTML (not raw markdown)
	// so the server can pass it through to AddComment without formatting loss.
	expect(result?.bespokeWelcomeMessage).toMatch(/<[^>]+>/);
	expect(result?.optimisticConciergeReportActionID).toBeDefined();
	});
	it('should generate bespoke welcome message for SMALL company sizes with suggestedFollowups beta', async () => {
	const adminsChatReportID = '1';
	await Onyx.merge(ONYXKEYS.SESSION, {email: 'test@example.com'});
	await Onyx.merge(ONYXKEYS.BETAS, [CONST.BETAS.SUGGESTED_FOLLOWUPS]);
	await waitForBatchedUpdates();
	const result = prepareOnboardingOnyxData({
	introSelected: undefined,
	engagementChoice: CONST.ONBOARDING_CHOICES.MANAGE_TEAM,
	onboardingMessage: {
	message: 'This is a test',
	tasks: [{type: CONST.ONBOARDING_TASK_TYPE.CONNECT_CORPORATE_CARD, title: () => '', description: () => '', autoCompleted: false}],
	},
	adminsChatReportID,
	selectedInterestedFeatures: ['areCompanyCardsEnabled'],
	companySize: CONST.ONBOARDING_COMPANY_SIZE.SMALL,
	});
	expect(result?.guidedSetupData).toHaveLength(0);
	expect(result?.bespokeWelcomeMessage).toContain('growing team');
	expect(result?.optimisticConciergeReportActionID).toBeDefined();
	});
	it('should generate bespoke welcome message for LARGE company sizes with suggestedFollowups beta', async () => {
	const adminsChatReportID = '1';
	await Onyx.merge(ONYXKEYS.SESSION, {email: 'test@example.com'});
	await Onyx.merge(ONYXKEYS.BETAS, [CONST.BETAS.SUGGESTED_FOLLOWUPS]);
	await waitForBatchedUpdates();
	const result = prepareOnboardingOnyxData({
	introSelected: undefined,
	engagementChoice: CONST.ONBOARDING_CHOICES.MANAGE_TEAM,
	onboardingMessage: {
	message: 'This is a test',
	tasks: [{type: CONST.ONBOARDING_TASK_TYPE.CONNECT_CORPORATE_CARD, title: () => '', description: () => '', autoCompleted: false}],
	},
	adminsChatReportID,
	selectedInterestedFeatures: ['areCompanyCardsEnabled'],
	companySize: CONST.ONBOARDING_COMPANY_SIZE.LARGE,
	});
	expect(result?.guidedSetupData).toHaveLength(0);
	expect(result?.bespokeWelcomeMessage).toContain('organization your size');
	expect(result?.optimisticConciergeReportActionID).toBeDefined();
	});
	it('should generate bespoke welcome message for MEDIUM_SMALL company sizes with suggestedFollowups beta', async () => {
	const adminsChatReportID = '1';
	await Onyx.merge(ONYXKEYS.SESSION, {email: 'test@example.com'});
	await Onyx.merge(ONYXKEYS.BETAS, [CONST.BETAS.SUGGESTED_FOLLOWUPS]);
	await waitForBatchedUpdates();
	const result = prepareOnboardingOnyxData({
	introSelected: undefined,
	engagementChoice: CONST.ONBOARDING_CHOICES.MANAGE_TEAM,
	onboardingMessage: {
	message: 'This is a test',
	tasks: [{type: CONST.ONBOARDING_TASK_TYPE.CONNECT_CORPORATE_CARD, title: () => '', description: () => '', autoCompleted: false}],
	},
	adminsChatReportID,
	selectedInterestedFeatures: ['areCompanyCardsEnabled'],
	companySize: CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL,
	});
	expect(result?.guidedSetupData).toHaveLength(0);
	expect(result?.bespokeWelcomeMessage).toContain('growing team');
	expect(result?.optimisticConciergeReportActionID).toBeDefined();
	});
	it('should generate bespoke welcome message for MEDIUM company sizes with suggestedFollowups beta', async () => {
	const adminsChatReportID = '1';
	await Onyx.merge(ONYXKEYS.SESSION, {email: 'test@example.com'});
	await Onyx.merge(ONYXKEYS.BETAS, [CONST.BETAS.SUGGESTED_FOLLOWUPS]);
	await waitForBatchedUpdates();
	const result = prepareOnboardingOnyxData({
	introSelected: undefined,
	engagementChoice: CONST.ONBOARDING_CHOICES.MANAGE_TEAM,
	onboardingMessage: {
	message: 'This is a test',
	tasks: [{type: CONST.ONBOARDING_TASK_TYPE.CONNECT_CORPORATE_CARD, title: () => '', description: () => '', autoCompleted: false}],
	},
	adminsChatReportID,
	selectedInterestedFeatures: ['areCompanyCardsEnabled'],
	companySize: CONST.ONBOARDING_COMPANY_SIZE.MEDIUM,
	});
	expect(result?.guidedSetupData).toHaveLength(0);
	expect(result?.bespokeWelcomeMessage).toContain('organization your size');
	expect(result?.optimisticConciergeReportActionID).toBeDefined();
	});
	it('should append accounting integration suffix to bespoke welcome message', async () => {
	const adminsChatReportID = '1';
	await Onyx.merge(ONYXKEYS.SESSION, {email: 'test@example.com'});
	await Onyx.merge(ONYXKEYS.BETAS, [CONST.BETAS.SUGGESTED_FOLLOWUPS]);
	await waitForBatchedUpdates();
	const result = prepareOnboardingOnyxData({
	introSelected: undefined,
	engagementChoice: CONST.ONBOARDING_CHOICES.MANAGE_TEAM,
	onboardingMessage: {
	message: 'This is a test',
	tasks: [{type: CONST.ONBOARDING_TASK_TYPE.CONNECT_CORPORATE_CARD, title: () => '', description: () => '', autoCompleted: false}],
	},
	adminsChatReportID,
	selectedInterestedFeatures: ['areCompanyCardsEnabled'],
	companySize: CONST.ONBOARDING_COMPANY_SIZE.SMALL,
	userReportedIntegration: 'quickbooksOnline',
	});
	expect(result?.bespokeWelcomeMessage).toContain('QuickBooks Online');
	expect(result?.bespokeWelcomeMessage).toContain('expenses sync automatically');
	});
	it('should add guidedSetupData when posting into admin room WITHOUT suggestedFollowups beta', async () => {
	const adminsChatReportID = '1';
	// Not having `+` in the email allows for `isPostingTasksInAdminsRoom` flow
	await Onyx.merge(ONYXKEYS.SESSION, {email: 'test@example.com'});
	// Do NOT set the suggestedFollowups beta - user should get the old task list behavior
	await Onyx.merge(ONYXKEYS.BETAS, []);
	await waitForBatchedUpdates();
	const result = prepareOnboardingOnyxData({
	introSelected: undefined,
	engagementChoice: CONST.ONBOARDING_CHOICES.MANAGE_TEAM,
	onboardingMessage: {
	message: 'This is a test',
	tasks: [{type: CONST.ONBOARDING_TASK_TYPE.CONNECT_CORPORATE_CARD, title: () => '', description: () => '', autoCompleted: false}],
	},
	adminsChatReportID,
	selectedInterestedFeatures: ['areCompanyCardsEnabled'],
	companySize: CONST.ONBOARDING_COMPANY_SIZE.MICRO,
	});
	// Without the beta, tasks SHOULD be generated (old behavior)
	expect(result?.guidedSetupData).toHaveLength(3);
	});
	it('should add guidedSetupData when email has a +', async () => {
	const adminsChatReportID = '1';
	await waitForBatchedUpdates();
	const result = prepareOnboardingOnyxData({
	introSelected: undefined,
	engagementChoice: CONST.ONBOARDING_CHOICES.MANAGE_TEAM,
	onboardingMessage: {
	message: 'This is a test',
	tasks: [{type: CONST.ONBOARDING_TASK_TYPE.CONNECT_CORPORATE_CARD, title: () => '', description: () => '', autoCompleted: false}],
	},
	adminsChatReportID,
	selectedInterestedFeatures: ['areCompanyCardsEnabled'],
	companySize: CONST.ONBOARDING_COMPANY_SIZE.MICRO,
	});
	expect(result?.guidedSetupData).toHaveLength(3);
	expect(result?.optimisticData.filter((i) => i.key === `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${adminsChatReportID}`)).toHaveLength(0);
	});
	it('should not create tasks if the task feature is not in the selected interested features', () => {
	const result = prepareOnboardingOnyxData({
	introSelected: undefined,
	engagementChoice: CONST.ONBOARDING_CHOICES.MANAGE_TEAM,
	onboardingMessage: {
	message: 'This is a test',
	tasks: [{type: CONST.ONBOARDING_TASK_TYPE.CONNECT_CORPORATE_CARD, title: () => '', description: () => '', autoCompleted: false}],
	},
	adminsChatReportID: '1',
	selectedInterestedFeatures: ['categories', 'accounting', 'tags'],
	companySize: CONST.ONBOARDING_COMPANY_SIZE.MICRO,
	});
	expect(result?.guidedSetupData.filter((data) => data.type === 'task')).toHaveLength(0);
	});
	it('includes avatar and accountID in optimistic Setup Specialist personal detail', async () => {
	// Reset personal details to remove any Setup Specialist entry added by previous tests,
	// so the optimistic creation path (else branch) is exercised.
	await Onyx.set(ONYXKEYS.PERSONAL_DETAILS_LIST, participantsPersonalDetails);
	await waitForBatchedUpdates();
	const mergeSpy = jest.spyOn(Onyx, 'merge');
	prepareOnboardingOnyxData({
	introSelected: undefined,
	engagementChoice: CONST.ONBOARDING_CHOICES.MANAGE_TEAM,
	onboardingMessage: {
	message: 'This is a test',
	tasks: [],
	},
	adminsChatReportID: '1',
	companySize: CONST.ONBOARDING_COMPANY_SIZE.MICRO,
	});
	const personalDetailsCall = mergeSpy.mock.calls.find((call) => call[0] === ONYXKEYS.PERSONAL_DETAILS_LIST);
	const personalDetailsData = personalDetailsCall?.[1] as Record<string, {accountID: number; avatar?: string; login?: string; displayName?: string}>;
	const setupSpecialistDetail = Object.values(personalDetailsData ?? {}).at(0);
	expect(setupSpecialistDetail).toBeDefined();
	expect(setupSpecialistDetail?.accountID).toBeDefined();
	expect(setupSpecialistDetail?.accountID).toBe(515109196);
	expect(setupSpecialistDetail?.avatar).toBeDefined();
	expect(setupSpecialistDetail?.avatar).toContain('images/avatars/');
	mergeSpy.mockRestore();
	});
	it('passes MICRO company size to onboarding task parameters', () => {
	const title = jest.fn();
	const description = jest.fn();
	prepareOnboardingOnyxData({
	introSelected: undefined,
	engagementChoice: CONST.ONBOARDING_CHOICES.MANAGE_TEAM,
	onboardingMessage: {
	message: 'This is a test',
	tasks: [
	{
	type: CONST.ONBOARDING_TASK_TYPE.CREATE_WORKSPACE,
	title,
	description,
	autoCompleted: false,
	},
	],
	},
	adminsChatReportID: '1',
	companySize: CONST.ONBOARDING_COMPANY_SIZE.MICRO,
	});
	expect(title).toHaveBeenCalledWith(
	expect.objectContaining<OnboardingTaskLinks>({
	onboardingCompanySize: CONST.ONBOARDING_COMPANY_SIZE.MICRO,
	}),
	);
	expect(description).toHaveBeenCalledWith(
	expect.objectContaining<OnboardingTaskLinks>({
	onboardingCompanySize: CONST.ONBOARDING_COMPANY_SIZE.MICRO,
	}),
	);
	});
	it('should produce empty guidedSetupData for LOOKING_AROUND intent with empty message', () => {
	const result = prepareOnboardingOnyxData({
	introSelected: undefined,
	engagementChoice: CONST.ONBOARDING_CHOICES.LOOKING_AROUND,
	onboardingMessage: {
	message: '',
	tasks: [],
	},
	adminsChatReportID: '1',
	companySize: CONST.ONBOARDING_COMPANY_SIZE.MICRO,
	});
	expect(result?.guidedSetupData).toHaveLength(0);
	});
	it('should not include sign-off message for LOOKING_AROUND intent', () => {
	const result = prepareOnboardingOnyxData({
	introSelected: undefined,
	engagementChoice: CONST.ONBOARDING_CHOICES.LOOKING_AROUND,
	onboardingMessage: {
	message: '',
	tasks: [],
	},
	adminsChatReportID: '1',
	companySize: CONST.ONBOARDING_COMPANY_SIZE.MICRO,
	});
	// For LOOKING_AROUND with empty message and no tasks, guidedSetupData should be empty
	// because both the message and the sign-off are suppressed
	expect(result?.guidedSetupData).toHaveLength(0);
	// The sign-off message should not be in the optimistic data for the target report
	const reportActionsKeys = result?.optimisticData.filter((i) => i.key === `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${REPORT_ID}`).map((i) => i.key);
	expect(reportActionsKeys).toHaveLength(0);
	});
	it('should include guidedSetupData for non-LOOKING_AROUND intents', () => {
	const result = prepareOnboardingOnyxData({
	introSelected: undefined,
	engagementChoice: CONST.ONBOARDING_CHOICES.PERSONAL_SPEND,
	onboardingMessage: {
	message: 'Here is how to track your spend in a few clicks.',
	tasks: [],
	},
	adminsChatReportID: '1',
	companySize: CONST.ONBOARDING_COMPANY_SIZE.MICRO,
	});
	// Non-LOOKING_AROUND intents with a message should have guidedSetupData entries
	// At minimum: the message itself and the sign-off
	expect(result?.guidedSetupData.length).toBeGreaterThanOrEqual(1);
	const messageEntries = result?.guidedSetupData.filter((data) => data.type === 'message');
	expect(messageEntries?.length).toBeGreaterThanOrEqual(1);
	});
	});

it('should skip creating VIEW_TOUR task when introSelected.viewTour already exists', () => {
    const result = prepareOnboardingOnyxData({
        introSelected: {
            choice: CONST.ONBOARDING_CHOICES.PERSONAL_SPEND,
            viewTour: '12345',
        },
        engagementChoice: CONST.ONBOARDING_CHOICES.TRACK_WORKSPACE,
        onboardingMessage: {
            message: 'This is a test',
            tasks: [
                {
                    type: CONST.ONBOARDING_TASK_TYPE.VIEW_TOUR,
                    title: () => 'Take a test drive',
                    description: () => 'desc',
                    autoCompleted: false,
                },
                {
                    type: CONST.ONBOARDING_TASK_TYPE.CREATE_WORKSPACE,
                    title: () => 'Create workspace',
                    description: () => 'desc',
                    autoCompleted: false,
                },
            ],
        },
        companySize: CONST.ONBOARDING_COMPANY_SIZE.MICRO,
    });

    const taskEntries = result?.guidedSetupData.filter((entry) => entry.type === 'task').map((entry) => entry.task);
    expect(taskEntries).not.toContain(CONST.ONBOARDING_TASK_TYPE.VIEW_TOUR);
    expect(taskEntries).toContain(CONST.ONBOARDING_TASK_TYPE.CREATE_WORKSPACE);
});

[hoangzinh]

Thanks for posting your proposals. @gps949 @abbasifaizan70. Both proposas make sense to me. However, as MelvinBot pointed out, they work for the “Take a test drive” task but won’t prevent similar bugs from occurring.

but would not prevent other task types from being duplicated via the same mechanism.

Therefore, I believe we should proceed with MelvinBot's proposal.

[Coincatcher]

Proposal

Problem

After signup with PERSONAL_SPEND, skipping workspace creation, and then creating a new workspace via FAB, two identical "Take a test drive" (VIEW_TOUR) tasks appear in Concierge chat.

Root Cause

The duplicate occurs because the onboarding task creation logic in GuidedSetupList (or the equivalent task-dispatch code) does not check whether a task of the same type already exists before creating a new one. When a workspace is created post-signup, the onboarding flow re-triggers and blindly appends another VIEW_TOUR task.

Generic Solution (prevents ALL task type duplicates, not just VIEW_TOUR)

Instead of fixing only the "Take a test drive" case, I propose adding a deduplication guard at the point where onboarding tasks are created/dispatched:

1. Before creating any onboarding task, query the existing Concierge messages for tasks of the same taskType
2. If a task with that taskType already exists (regardless of workspace context), skip creation
3. This is a single check that covers VIEW_TOUR, SETUP_WORKSPACE, and any future task types — no per-type patches needed

Implementation:

• In the task creation function (likely in libs/actions/Task.ts or the onboarding action), add a guard:

  const existingTasks = getConciergeTasksByType(taskType);
  if (existingTasks.length > 0) return; // Already exists, skip
  

• This can leverage the existing ReportActionsUtils to scan for task reports in the Concierge chat

This approach is generic — it prevents duplicate tasks of ANY type, not just VIEW_TOUR, addressing the reviewer's concern about similar bugs with other task types.

Platforms

All platforms (Web, iOS, Android)

[Coincatcher]

Contributor details
Your Expensify account email: moksha@avartist.art
Upwork Profile Link: https://www.upwork.com/freelancers/~coincatcher