Android & iOS - Expense - Amount field shows flip button on confirm page

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.48-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #83695
Email or phone of affected tester (no customers): applausetester+jsodisjsdnodsjs2i@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone 15 Pro Max / iOS 26.3
App Component: Money Requests

Action Performed:

Precondition:

• Log in with Expensifail account.

1. Launch Expensify app.
2. Open 1:1 DM with any user.
3. Tap + > Create expense > Manual.
4. Enter amount > Next.

Expected Result:

On confirm page, Amount field will not show flip button because IOU expense does not support negative expense.

Actual Result:

On confirm page, Amount field shows flip button.
Flip button also appears when spltting IOU expense where negative amount is not supported.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @ChavdaSachin

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #83695

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #83695 - "Manual expense flow UI refactor r1" by @ChavdaSachin (High confidence)
Related Issues: None

Recommendation: REVERT

PR #83695 introduced a regression where the flip button (+/-) is shown unconditionally in the new manual expense flow, even for IOU types that do not support negative amounts (like REQUEST type in 1:1 DMs).

Labels: This is a Frontend bug. Keeping DeployBlockerCash label as appropriate. No label changes needed.

📋 Detailed Analysis

Evidence

• The issue is only reproducible on staging (version 9.3.48-1), not production
• PR Manual expense flow UI refactor r1 #83695 was merged on 2026-03-24 and is included in the current staging deploy checklist
• The bug appears specifically in the manual expense flow for 1:1 DM money requests (IOU REQUEST type)
• Melvin-bot automatically assigned this issue to the PR author

Verification

I reviewed the PR diff and confirmed:

File: src/components/MoneyRequestConfirmationListFooter.tsx (line 612 in current code)

The PR added a new inline amount input field with:

<NumberWithSymbolForm
    displayAsTextInput
    value={transactionAmount}
    decimals={decimals}
    currency={currency}
    symbol={getLocalizedCurrencySymbol(preferredLocale, currency) ?? ""}
    label={translate("iou.amount")}
    errorText={shouldShowAmountRequiredError ? translate("common.error.fieldRequired") : ""}
    onInputChange={handleAmountChange}
    allowNegativeInput={allowNegative}
    shouldShowFlipButton          // ❌ HARDCODED TO TRUE
    shouldShowCurrencyButton
    shouldShowBigNumberPad={false}
    onCurrencyButtonPress={showCurrencyPicker}
    disabled={isAmountFieldDisabled}
/>

Root Cause

The shouldShowFlipButton prop is hardcoded to true without checking whether negative amounts are supported for the current IOU type.

While the component correctly sets allowNegativeInput={allowNegative} (which uses the shouldEnableNegative function), the flip button visibility is not tied to this logic.

According to src/libs/ReportUtils.ts line 1995-2008, the shouldEnableNegative function returns false for:

• IOU REQUEST type in 1:1 DMs (not an expense report, not a group policy, not a self DM, not CREATE type)
• IOU SPLIT type (explicitly excluded)
• IOU INVOICE type (explicitly excluded)

The fix: shouldShowFlipButton should be set to {allowNegative} instead of being hardcoded to true, ensuring the flip button only appears when negative amounts are actually supported.

[MelvinBot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On the expense confirmation page, the amount field shows a flip (+/-) button for IOU and split expenses. Since these expense types do not support negative amounts, the flip button should not appear.

What is the root cause of that problem?

PR #83695 introduced an inline NumberWithSymbolForm component on the confirmation page (when the newManualExpenseFlow beta is enabled). In MoneyRequestConfirmationListFooter.tsx at line 612, shouldShowFlipButton is passed as a bare boolean prop — equivalent to shouldShowFlipButton={true} — so the flip button renders unconditionally for all expense types.

The correct gating logic already exists: allowNegative is computed via shouldEnableNegative() (in ReportUtils.ts:1995-2009), which returns false for IOU/SUBMIT expenses and explicitly excludes SPLIT and INVOICE types. This value is correctly passed as allowNegativeInput (controlling whether the input field accepts negative values), but it is not used to control the flip button's visibility.

Additionally, handleFlipPress in NumberWithSymbolForm.tsx:407-412 does not check allowNegativeInput before toggling the sign, so pressing the button could produce a negative amount even when it's not supposed to be allowed.

What changes do you think we should make in order to solve the problem?

In src/components/MoneyRequestConfirmationListFooter.tsx, change the bare shouldShowFlipButton prop on line 612 to shouldShowFlipButton={allowNegative}. The allowNegative variable is already computed on line 524 and correctly evaluates to false for IOU, SPLIT, and INVOICE expense types.

This mirrors how the amount step page (IOURequestStepAmount.tsx:474) already gates the flip button with allowFlippingAmount={!isSplitBill && allowNegative}.

What alternative solutions did you explore? (Optional)

An alternative would be to add a guard inside NumberWithSymbolForm.tsx's handleFlipPress to check allowNegativeInput before toggling the sign, and to conditionally hide the button when allowNegativeInput is false. However, this would be less clean since the parent component already has all the information needed to make this decision — it's better to pass the correct prop value from the parent rather than adding redundant logic in the child.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.