Expense - No radio button present while changing workspace of an expense.

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.50.1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #83799
Email or phone of affected tester (no customers): ibellicotest+2250@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Account has at least two workspaces available.

1. Open the staging.new.expensify.com website.
2. Open any workspace chat.
3. Create a manual expense.
4. Open the just created expense.
5. Click on "More" > "Change Workspace"
6. Note that radio button is not present next to workspaces and that actual workspace is not displayed with a checkmark.
7. Select another workspace to move the expense to.
8. Navigate to the new workspace and reopen expense.
9. Click on "More" > "Change Worksapce"
10. Note that radio button is still not present and new workspace is not displayed with a checkmark either.

Expected Result:

Radio button should be visible next to workspaces while moving an expense, and selected workspace should display a checkmark.

Actual Result:

Radio button is not present while moving an expense to a different workspace and selected workspace doesn´t display a checkmark either.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @zfurtak

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #83799

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #83799 - "Enhance icons UI consistency" by @zfurtak (High confidence)
Related Issues: None

Recommendation: REVERT

PR #83799 introduced a new design for selection lists with radio buttons and checkboxes but did not update all affected pages. The ReportChangeWorkspacePage was missed, resulting in no radio button being rendered when changing an expense workspace.

Labels: Keeping DeployBlockerCash - this is a frontend bug requiring an App PR fix

📋 Detailed Analysis

Evidence

PR #83799 changed the design of single and multi-choice lists to add radio buttons and checkboxes for consistency. The PR modified the UserListItem component to conditionally render radio buttons based on a new shouldShowRadioButton prop being passed down.

The PR updated several pages to pass this prop (e.g., ApproverSelectionList.tsx, BaseVacationDelegateSelectionComponent.tsx), but ReportChangeWorkspacePage.tsx was not updated.

Verification

Affected file: /home/runner/_work/App/App/src/pages/ReportChangeWorkspacePage.tsx

Line 200 uses UserListItem without the required shouldShowRadioButton prop:

<SelectionList<WorkspaceListItemType>
    ListItem={UserListItem}
    data={data}
    onSelectRow={(option) => selectPolicy(option.policyID)}
    // Missing: shouldShowRadioButton={true}

PR changes to UserListItem (src/components/SelectionList/ListItem/UserListItem.tsx):
The component now only renders the radio button when:

{((!!shouldUseDefaultRightHandSideCheckmark && !!canSelectMultiple) || !!shouldShowRadioButton) && (
    <SelectionCheckbox ... />
)}

Since canSelectMultiple is not set and shouldShowRadioButton is not passed, the checkbox/radio button is never rendered.

Root Cause

The PR introduced a breaking change to the UserListItem component by making radio button rendering conditional on a new prop. The change workspace page was not updated to provide this prop, causing the radio buttons to not render at all.

This is an incomplete implementation - the PR should have either:

1. Made the prop default to true for backward compatibility, OR
2. Updated ALL pages using UserListItem for single selection

[MelvinBot]

Proposal

What is the root cause of that problem?

ReportChangeWorkspacePage.tsx renders a <SelectionList> with UserListItem but does not pass the shouldShowRadioButton prop (line 199-207).

In UserListItem, the radio button (rendered via SelectionCheckbox) only appears when shouldShowRadioButton is truthy (line 168). Since the prop is not passed, no selection indicator is rendered at all — no radio button and no checkmark.

The comparable page NewReportWorkspaceSelectionPage.tsx does pass shouldShowRadioButton (line 286), which is why radio buttons work correctly there.

This regression was introduced by PR #83799 ("Enhance icons UI consistency"), which changed the default for shouldUseDefaultRightHandSideCheckmark from true to false in BaseListItem and migrated most pages to use SingleSelectListItem. However, ReportChangeWorkspacePage uses UserListItem and was not updated to explicitly opt in to radio button rendering.

What changes do you think we should make in order to solve the problem?

Add the shouldShowRadioButton prop to the <SelectionList> in ReportChangeWorkspacePage.tsx, matching the pattern already used in NewReportWorkspaceSelectionPage.tsx.

What alternative solutions did you explore? (Optional)

An alternative would be to switch the ListItem from UserListItem to SingleSelectListItem (which always renders a radio button), but this would change the visual layout of the workspace items — UserListItem shows avatars and subscription info that SingleSelectListItem does not. Adding shouldShowRadioButton is the minimal, consistent fix.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.