[HOLD for payment 2022-05-20][$250] After changing language to Espanol "Are you sure" didn't change - reported by @Puneet-here

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Change the default language to Espanol
2. Add bank account manually
3. Fill the company form and submit it, after that you will see personal information page
4. Press the cross on top right to exit to the homepage
5. Now from homepage go back to bank account page you will see an option to start over click on it

Expected Result:

You should see the correct translated text

Actual Result:

After changing language to Espanol "Are you sure" is not translated

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.54-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @Puneet-here
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1649326577396609

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Puneet-here]

Proposal

App/src/pages/workspace/WorkspaceResetBankAccountModal.js

Line 39 in 6c53be1

title="Are you sure?"

need to change it to

title={props.translate('workspace.bankAccount.deleteConfirmation')}

and we also need to add that key at en.js and es.js

I think the translation of "Are you sure" in spanish would be "Estás seguro". Correct me if the translation is wrong.

[robertjchen]

Looks good, though I believe the exact translation would have to be "¿Estás seguro?". Tagging as External for next steps, thanks!

[melvin-bot]

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[adelekennedy]

internal
external