[Due for payment 2026-04-14] Expense - Tapping on expense row does not deselect or select expense

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.51-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #85818
Email or phone of affected tester (no customers): snodijosdnjoijiosnj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone 15 Pro Max / iOS 26.3
App Component: Search

Action Performed:

1. Launch Expensify app.
2. Go to workspace chat.
3. Create an expense.
4. Delete the expense.
5. Go to Reports > Expenses.
6. Click Status, select Deleted and click Apply.
7. Long tap on the expense > Select.
8. Tap on the expense row.

Expected Result:

Tapping on the expense row will deselect or select the expense.

Actual Result:

Tapping on the expense row does not deselect or select the expense.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7118367_1774987648921.ScreenRecording_04-01-2026_04-06-14_1.mp4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #85818

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #85818 - "Deleted transactions on search" by @jnowakow (High confidence)
Related Issues: None

Recommendation: REVERT

PR #85818 introduced logic that disables the onPress handler for deleted transactions. While this prevents opening transaction details (which was likely the intent), it also breaks the ability to select/deselect deleted transactions in multi-select mode. Users can enter selection mode via long-press but then cannot tap rows to toggle selection.

Labels: Keeping DeployBlockerCash (App deploy is blocked), removing DeployBlocker (not a backend issue)

📋 Detailed Analysis

Evidence

PR #85818 added support for viewing and undeleting transactions that have been deleted. The PR introduced changes to TransactionListItem.tsx that disable row tap functionality for deleted transactions.

Verification

The affected file is /home/runner/_work/App/App/src/components/Search/SearchList/ListItem/TransactionListItem.tsx

PR #85818 modified this file and added the following logic (lines 184 and 236):

onPress={isDeletedTransaction ? undefined : () => onSelectRow(item, transactionPreviewData)}

This change disables the onPress handler when isDeletedTransaction is true, which prevents the selection/deselection behavior described in the bug report.

Root Cause

The PR added a conditional that sets onPress={undefined} for deleted transactions. The likely intent was to prevent navigation to transaction details for deleted items. However, onSelectRow is responsible for both:

1. Navigating to transaction details (when not in selection mode)
2. Toggling selection state (when in selection mode)

By disabling onPress entirely, both behaviors are broken for deleted transactions. Users can long-press to enter selection mode, but subsequent taps on the row do nothing because the onPress handler is disabled.

The fix should allow selection/deselection in multi-select mode while preventing navigation in normal mode for deleted transactions.