[Due for payment 2026-04-14] [Due for payment 2026-04-14] Reports - Clicking on disabled Submit button opens the expense report when offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.52-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #86731
Email or phone of affected tester (no customers): jsdjosidjiojisojio3@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Search

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create an expense.
4. Go to Reports > Reports.
5. Go offline.
6. Click on the disabled Submit button.

Expected Result:

Submit button is disabled. Clicking on it should do nothing.

Actual Result:

Clicking on disabled Submit button opens the expense report when offline.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7120162_1775160538793.3.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #86738

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

What is the root cause of that problem?

When the Submit button is disabled (offline), clicking it still propagates the click event to the parent row pressable, which navigates to the report.

The Button component (src/components/Button/index.tsx:492-494) correctly blocks its own onPress when disabled. However, it does NOT stop event propagation. The underlying GenericPressable (src/components/Pressable/GenericPressable/implementation/BaseGenericPressable.tsx:180) passes disabled={fullDisabled} to the native Pressable, and fullDisabled defaults to false — so the DOM element remains interactive and click events bubble up.

The parent BaseListItem (src/components/SelectionList/ListItem/BaseListItem.tsx:157-165) wraps each row in a PressableWithFeedback that calls onSelectRow(item) on press. When the disabled Submit button swallows the press but doesn't stop propagation, the parent row catches it and navigates to the report.

What changes do you think we should make in order to solve the problem?

In the Button component's onPress handler (src/components/Button/index.tsx:492-494), add e.stopPropagation() before the early return when isDisabled || isLoading is true. This prevents the click from bubbling to the parent row pressable.

What alternative solutions did you explore? (Optional)

1. Add pointerEventsNone style to ActionCell when offline — rejected because that would make clicks pass through to the parent row, causing the same navigation.
2. Set fullDisabled={true} on GenericPressable when disabled — this would work but has broader impact across all pressables, with higher risk of unintended side effects.
3. Add an offline check in BaseListItem's onPress — rejected because BaseListItem is generic and shouldn't know about offline state.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.