[HOLD for payment 2022-05-27] [$250] Notification Growl on Workspace manage member show-up only once - reported by @Tushu17

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open website in Desktop > settings > workspace
2. Go to Manage member
3. Touch on Admin multiple times

Expected Result:

It should show Notification Growl on every attempt.

Actual Result:

It show growl only once.

Workaround:

unknown

Platform:

Where is this issue occurring?

• iOS
• Android
• Mobile Web

Version Number: 1.1.57-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2022-04-14.at.1.00.07.AM.mov

Upwork job link: https://www.upwork.com/jobs/~01bc20ad2e82856ef6
Issue reported by: @Tushu17
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1649878756138299

View all open jobs on GitHub

[melvin-bot]

A Contributor Manager will be assigned to issue payment via Upwork if we deploy an associated Pull Request to production. Per Contributing.md.

[melvin-bot]

A Contributor Manager will be assigned to issue payment via Upwork if we deploy an associated Pull Request to production. Per Contributing.md.

[melvin-bot]

Triggered auto assignment to @kadiealexander (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[kakajann]

Proposal

Revoking the showTooltipForLogin state back to empty string, immediately after setting it to login will fix this issue.

Code:

diff --git a/src/pages/workspace/WorkspaceMembersPage.js b/src/pages/workspace/WorkspaceMembersPage.js
index b6415ca7d..88d1343ad 100644
--- a/src/pages/workspace/WorkspaceMembersPage.js
+++ b/src/pages/workspace/WorkspaceMembersPage.js
@@ -153,7 +153,13 @@ class WorkspaceMembersPage extends React.Component {

         const canBeRemoved = this.props.policy.owner !== login && this.props.session.email !== login;
         if (!canBeRemoved) {
-            this.setState({showTooltipForLogin: login});
+            this.setState({
+                showTooltipForLogin: login,
+            }, () => {
+                this.setState({
+                    showTooltipForLogin: '',
+                });
+            });
         }

         return !canBeRemoved;

Result

Screen.Recording.2022-05-03.at.12.23.10.AM.mov

[tgolen]

@kakajann Can you please explain how the tooltip causes a problem with the growl?

[melvin-bot]

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.