Expensify Card - Issue card RHP opens after clicking Got it on Bank account verified RHP

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.64-9
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #85234
Email or phone of affected tester (no customers): applausetester+khcategory20@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Workspace Settings

Action Performed:

1. Go to staging.new.expensify.com
2. Create a USD workspace.
3. Go to workspace settings > More features.
4. Enable Expensify Card.
5. Go to Expensify Card.
6. Click Issue new card > Issue new card > Log into your bank.
7. Add a bank account.
8. Click Issue new card > select bank account.
9. Click Got it.

Expected Result:

Issue card RHP will not open after clicking Got it.

Actual Result:

Issue card RHP opens after clicking Got it on Bank account verified RHP.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7140296_1777390488488.12.mp4

View all open jobs on GitHub

[melvin-bot]

@mountiny recently merged #85234, but they are OOO right now, so I'll auto-assign someone else.

[melvin-bot]

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #85234 - "Add TabNavigator" by @WojtekBoman (High confidence)
Related Issues: None identified

Recommendation: REVERT

PR #85234 introduced a new TabNavigator (a proper createBottomTabNavigator) that wraps all full-screen navigators. This restructured the root navigation stack from individual screen entries to a single TAB_NAVIGATOR entry. The handleVerifiedButtonPress handler in WorkspaceExpensifyCardBankAccounts.tsx calls Navigation.dismissModal() followed immediately by Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW.getRoute(policyID)). Under the new navigation architecture, this pattern causes the Issue New Card RHP to re-open after dismissal instead of the modal closing cleanly.

Assigned: @WojtekBoman (PR author), @ZhenjaHorbach and @mountiny (approving reviewers)
Labels: DeployBlockerCash kept (frontend App PR caused the issue). DeployBlocker not present.

📋 Detailed Analysis

Evidence

• The bug is reproducible on staging (version 9.3.64-9) but not production, meaning it was introduced in the current staging release.
• PR Introduce a Bottom Tab Navigator for Top-Level Navigation #85234 is listed in the StagingDeployCash deploy checklist and was merged on April 24, 2026.
• The melvin-bot comment on the issue directly links this PR: "@mountiny recently merged Introduce a Bottom Tab Navigator for Top-Level Navigation #85234".
• PR Introduce a Bottom Tab Navigator for Top-Level Navigation #85234 made a fundamental change: all full-screen navigators (ReportsSplitNavigator, SearchFullscreenNavigator, SettingsSplitNavigator, WorkspaceNavigator) were moved from individual root stack screens into a new TabNavigator created with @react-navigation/bottom-tabs.
• The bug reproduces when pressing "Got it" on the Bank account verified RHP, which triggers handleVerifiedButtonPress in src/pages/workspace/expensifyCard/WorkspaceExpensifyCardBankAccounts.tsx.

Verification

• Affected file: src/pages/workspace/expensifyCard/WorkspaceExpensifyCardBankAccounts.tsx
• PR Introduce a Bottom Tab Navigator for Top-Level Navigation #85234 restructured the navigation architecture that underlies how dismissModal() + navigate() interact. Many callsites were updated in the PR to use dismissModal({afterTransition: () => navigate(route)}) instead of sequential calls, but handleVerifiedButtonPress was not updated.
• The WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW route is an RHP screen (confirmed via src/libs/Navigation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts). Navigating to it after a dismissModal() under the new TabNavigator structure re-opens the Issue New Card RHP instead of navigating away.

Root Cause

handleVerifiedButtonPress calls Navigation.dismissModal() (which is asynchronous — it queues a DISMISS_MODAL action via TransitionTracker) and then immediately calls Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW...). Under the old navigation structure, this had a different effect. Under PR #85234's new TabNavigator structure, the synchronous navigate() call to an RHP route runs before the dismiss transition completes, resulting in the Issue New Card RHP being pushed back onto the stack. PR #85234 updated many similar patterns to use dismissModal({afterTransition: () => navigate(route)}) but missed this one.