Expensify Card - RHP back button on Reconciliation account page is unresponsive

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.64-9
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #85234
Email or phone of affected tester (no customers): applausetester+khcategory20@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Workspace is set up with Expensify Card feature.
• Workspace is connected to QBO.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Accounting.
3. Click Card reconciliation.
4. Enable Continuous Reconciliation.
5. Click Expensify Card settlement account.
6. Click Reconciliation account.
7. Click Expensify Card settlement account.
8. Click Reconciliation account.
9. Click RHP back button twice.
10. Click RHP back button again.

Expected Result:

RHP back button will return to Settlement account page.

Actual Result:

RHP back button on Reconciliation account page is unresponsive.
Account list on this page is empty.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7140302_1777390927178.13.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @mananjadhav

[melvin-bot]

@mountiny recently merged #85234, but they are OOO right now, so I'll auto-assign someone else.

[melvin-bot]

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #85234 - "Introduce a Bottom Tab Navigator for Top-Level Navigation" by @WojtekBoman (High confidence)
Related Issues: #85260

Recommendation: REVERT

PR #85234 introduced a major navigation refactor including a new createRightModalNavigator with state preservation logic (RightModalRouter + usePreserveNavigatorState). The preserved-state mechanism appears to incorrectly restore a stale RHP stack when the same RHP modal (workspace accounting reconciliation) is opened multiple times in sequence, causing both the empty account list and unresponsive back button.

Assigned: @WojtekBoman (PR author), @ZhenjaHorbach (approving reviewer), @mountiny (approving reviewer)
Labels: DeployBlockerCash kept (Frontend bug, App PR caused the issue). DeployBlocker not present, no change needed.

Detailed Analysis

Evidence

• The melvin-bot comment on the issue directly links PR Introduce a Bottom Tab Navigator for Top-Level Navigation #85234 as the recently merged PR associated with the bug.
• PR Introduce a Bottom Tab Navigator for Top-Level Navigation #85234 introduced a new createRightModalNavigator factory (src/libs/Navigation/AppNavigator/createRightModalNavigator/index.tsx) that wraps the RightModalNavigator with usePreserveNavigatorState, and a new RightModalRouter (src/libs/Navigation/AppNavigator/createRightModalNavigator/RightModalRouter.ts) that calls getPreservedNavigatorState(options.parentRoute.key) to restore the previous RHP stack state on mount.
• The bug is reproducible by navigating into the Reconciliation account page, going back, and then re-entering it (steps 7-10 in the repro). This pattern directly exercises the state preservation/restoration path introduced by PR Introduce a Bottom Tab Navigator for Top-Level Navigation #85234: on the second visit, the RHP is initialized from the preserved state of the previous visit, but the preserved state may not accurately reflect the current navigation intent, resulting in an empty account list and a broken back button.
• The bug is staging-only (not reproducible in production), which aligns perfectly with PR Introduce a Bottom Tab Navigator for Top-Level Navigation #85234 being merged on 2026-04-24 and present only in the staging build (version 9.3.64-9).

Verification

• Affected navigation files touched by PR Introduce a Bottom Tab Navigator for Top-Level Navigation #85234:
  • src/libs/Navigation/AppNavigator/createRightModalNavigator/RightModalRouter.ts (new file)
  • src/libs/Navigation/AppNavigator/createRightModalNavigator/index.tsx (new file)
  • src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.tsx (uses createRightModalNavigator)
  • src/libs/Navigation/AppNavigator/createSplitNavigator/usePreserveNavigatorState.ts (used by RightModalRouter)
• The reconciliation account pages (src/pages/workspace/accounting/reconciliation/) are opened as RHP screens, placing them squarely in the path of the new createRightModalNavigator state preservation logic.

Root Cause

PR #85234 introduced RightModalRouter, which calls getPreservedNavigatorState(options.parentRoute.key) to restore a previously preserved RHP stack when the RightModalNavigator is instantiated. When the user navigates through the reconciliation flow multiple times (steps 7-9 in the repro), the preserved state from a previous RHP instance is restored on the new RHP mount. This preserved state does not match the current navigation intent: it contains an outdated route stack where the account list data may no longer be bound (resulting in an empty list), and the back action on that restored stack resolves to an unexpected destination (making the back button appear unresponsive).